[ofa-general] Re: [PATCH] iblinkinfo, ibqueryerrors: clean up ibdiag_process_opts call

[Sasha Khapyorsky]

On 18:22 Wed 24 Jun     , Ira Weiny wrote:
> 
> From: Ira Weiny <weiny2 at llnl.gov>
> Date: Wed, 24 Jun 2009 18:22:14 -0700
> Subject: [PATCH] iblinkinfo, ibqueryerrors: clean up ibdiag_process_opts call
> 
> 
> Signed-off-by: Ira Weiny <weiny2 at llnl.gov>

Applied. Thanks. The comment is below.

> ---
>  infiniband-diags/src/iblinkinfo.c    |    2 +-
>  infiniband-diags/src/ibqueryerrors.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/infiniband-diags/src/iblinkinfo.c b/infiniband-diags/src/iblinkinfo.c
> index f2dca6b..bba5c5c 100644
> --- a/infiniband-diags/src/iblinkinfo.c
> +++ b/infiniband-diags/src/iblinkinfo.c
> @@ -293,7 +293,7 @@ main(int argc, char **argv)
>  	};
>  	char usage_args[] = "";
>  
> -	ibdiag_process_opts(argc, argv, "sDLG", "SDandlpgR", opts, process_opt,
> +	ibdiag_process_opts(argc, argv, NULL, "SDandlpgRGL", opts, process_opt,
>  			    usage_args, NULL);

This is correct. And actually it is not needed to specify custom options
letters in 'exclude_string' (4th parameter), only ones which can
conflict with common options should be enough.

Sasha