[ofa-general] [PATCH] dtestx: fix conn establishment event checking

Davis, Arlin R arlin.r.davis at intel.com
Fri Jun 26 16:47:42 PDT 2009


test is not catching error cases on client side
when checking for event number and UD type
&& should have been ||

Signed-off-by: Arlin Davis <arlin.r.davis at intel.com>
---
 test/dtest/dtestx.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/test/dtest/dtestx.c b/test/dtest/dtestx.c
index 2d062f1..a14785b 100755
--- a/test/dtest/dtestx.c
+++ b/test/dtest/dtestx.c
@@ -344,12 +344,13 @@ void process_conn(int idx)
 	status = dat_evd_wait(con_evd, CONN_TIMEOUT, 1, &event, &nmore);
 	_OK(status, "CONN dat_evd_wait");
 
-	LOGPRINTF("%s got connect[%d] event, pdata %p sz=%d\n",
+	LOGPRINTF("%s got connect[%d] event 0x%x, pdata %p sz=%d\n",
 		  server ? "Server" : "Client", idx,
-		  conn_event->private_data, conn_event->private_data_size);
+		  event.event_number, conn_event->private_data, 
+		  conn_event->private_data_size);
 
 	/* Waiting on CR's or CONN_EST */
-	if (event.event_number != DAT_CONNECTION_EVENT_ESTABLISHED &&
+	if (event.event_number != DAT_CONNECTION_EVENT_ESTABLISHED ||
 	    (ud_test && event.event_number !=
 	     DAT_IB_UD_CONNECTION_EVENT_ESTABLISHED)) {
 		printf("unexpected event, !conn established: 0x%x\n",
-- 
1.5.2.5




More information about the general mailing list