[ofa-general] Re: [PATCH][TRIVIAL] opensm/osm_trap_rcv.c: Cosmetic changes
Sasha Khapyorsky
sashak at voltaire.com
Thu Mar 5 23:49:53 PST 2009
On 10:25 Tue 03 Mar , Hal Rosenstock wrote:
>
> Removed extraneous parentheses
> Eliminated unneeded __ and __osm_ prefixes to static routine names
> Fixed some commentary typos
>
> Signed-off-by: Hal Rosenstock <hal.rosenstock at gmail.com>
Applied (with small change noted below). Thanks.
> @@ -173,7 +173,7 @@ static uint32_t __osm_trap_calc_crc32(void *buffer, uint32_t count)
> crc = i;
> for (j = 8; j > 0; j--)
> if (crc & 1)
> - crc = (crc >> 1) ^ CRC32_POLYNOMIAL;
> + crc = crc >> 1 ^ CRC32_POLYNOMIAL;
I leaved it as it was - look slightly clearer with parentheses (at least
for me).
Sasha
More information about the general
mailing list