***SPAM*** Re: [ofa-general] Re: [PATCH][TRIVIAL] ibsim: Some cosmetic changes

Hal Rosenstock hal.rosenstock at gmail.com
Tue Mar 10 07:56:43 PDT 2009


On Tue, Mar 10, 2009 at 4:43 AM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
> On 15:50 Fri 06 Mar     , Hal Rosenstock wrote:
>>
>> Signed-off-by: Hal Rosenstock <hal.rosenstock at gmail.com>
>
> Applied with modification noted below. Thanks.
>
>> diff --git a/ibsim/sim_cmd.c b/ibsim/sim_cmd.c
>> index 94e0a14..bbd51b9 100644
>> --- a/ibsim/sim_cmd.c
>> +++ b/ibsim/sim_cmd.c
>> @@ -274,10 +274,9 @@ static void port_change_lid(Port * port, int lid, int lmc)
>>       if (lmc > 0)
>>               port->lmc = lmc;
>>
>> -     if (port->node->type == SWITCH_NODE) {
>> -             if (port->node->sw)
>> -                     port->node->sw->portchange = 1;
>> -     } else if (port->remotenode && port->remotenode->sw)
>> +     if (port->node->type == SWITCH_NODE && port->node->sw)
>> +             port->node->sw->portchange = 1;
>> +     else if (port->remotenode && port->remotenode->sw)
>>               port->remotenode->sw->portchange = 1;
>>  }
>
> This is not equivalent.

Why not ?

-- Hal

> So I'm removing this chunk.
>
> Sasha
> - Show quoted text -
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>



More information about the general mailing list