***SPAM*** Re: [ofa-general] ***SPAM*** [PATCH] infiniband-diags/mcm_rereg_test.c: Add missing mad_rpc_close_port call
Hal Rosenstock
hal.rosenstock at gmail.com
Wed Mar 11 10:10:11 PDT 2009
On Wed, Mar 11, 2009 at 11:03 AM, Ira Weiny <weiny2 at llnl.gov> wrote:
> On Wed, 11 Mar 2009 08:53:20 -0500
> Hal Rosenstock <hnrose at comcast.net> wrote:
>
>>
>> Signed-off-by: Hal Rosenstock <hal.rosenstock at gmail.com>
>>
>> ---
>> diff --git a/infiniband-diags/src/mcm_rereg_test.c b/infiniband-diags/src/mcm_rereg_test.c
>> index de5ea90..d087e4a 100644
>> --- a/infiniband-diags/src/mcm_rereg_test.c
>> +++ b/infiniband-diags/src/mcm_rereg_test.c
>> @@ -492,9 +492,13 @@ int main(int argc, char **argv)
>> mad = umad_get_mad(umad);
>>
>> free(umad);
>> +#if 1
>> + mad_rpc_close_port(srcport);
>> +#else
>> umad_unregister(port, agent);
>> umad_close_port(port);
>> umad_done();
>> +#endif
>
> Why use "#if 1" here? Why not just replace the umad calls with
> mad_rpc_close_port?
Just consistency with what's been done in other places in that file.
Other similar places are ifdef'd so I kept that.
-- Hal
> Ira
>
>>
>> return 0;
>> }
>> _______________________________________________
>> general mailing list
>> general at lists.openfabrics.org
>> http:// lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>>
>> To unsubscribe, please visit http:// openib.org/mailman/listinfo/openib-general
>>
>
>
> --
> Ira Weiny
> Math Programer/Computer Scientist
> Larence Livermore National Lab
> weiny2 at llnl.gov
> - Show quoted text -
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>
More information about the general
mailing list