[ofa-general] Re: [PATCH 2/2] opensm: setup routing engine when in use and delete when fail

[Sasha Khapyorsky]

On 17:36 Thu 26 Feb     , Eli Dorfman (Voltaire) wrote:
> diff --git a/opensm/opensm/osm_opensm.c b/opensm/opensm/osm_opensm.c
> index 7de2e5b..a2620d5 100644
> --- a/opensm/opensm/osm_opensm.c
> +++ b/opensm/opensm/osm_opensm.c
> @@ -169,21 +169,14 @@ static void setup_routing_engine(osm_opensm_t *osm, const char *name)
>  			memset(re, 0, sizeof(struct osm_routing_engine));
>  
>  			re->name = m->name;
> -			if (m->setup(re, osm)) {
> -				OSM_LOG(&osm->log, OSM_LOG_VERBOSE,
> -					"setup of routing"
> -					" engine \'%s\' failed\n", name);
> -				return;
> -			}
> -			OSM_LOG(&osm->log, OSM_LOG_DEBUG,
> -				"\'%s\' routing engine set up\n", re->name);
> +			re->setup = m->setup;

Also this make compile warning:

osm_opensm.c: In function 'setup_routing_engine':
osm_opensm.c:172: warning: assignment from incompatible pointer type

Sasha