[ofa-general] Re: [PATCH v2] opensm: support routing engine update

[Sasha Khapyorsky]

On 12:16 Tue 17 Mar     , Eli Dorfman (Voltaire) wrote:
> This patch fixes a bug in "support routing engine update" patch.
> (Do you want a new patch that includes both?)

Yes. But wait a little with V3 posting - I have a comments for the
current (V2) version.

> It fixes cleanup of last routing engine
> Also use routing engine context instead of initialized flag.
> 
> Signed-off-by: Eli Dorfman <elid at voltaire.com>
> ---
>  opensm/include/opensm/osm_opensm.h |    1 -
>  opensm/opensm/osm_opensm.c         |    1 -
>  opensm/opensm/osm_ucast_mgr.c      |    7 ++++---
>  3 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/opensm/include/opensm/osm_opensm.h b/opensm/include/opensm/osm_opensm.h
> index d297dd8..401a73f 100644
> --- a/opensm/include/opensm/osm_opensm.h
> +++ b/opensm/include/opensm/osm_opensm.h
> @@ -122,7 +122,6 @@ typedef enum _osm_routing_engine_type {
>  struct osm_routing_engine {
>  	const char *name;
>  	void *context;
> -	int initialized;

Assumption that routing engine setup will always set context value can
be not correct.

Sasha