[ofa-general] Re: [PATCH] libibmad/sa.c: No need to specify NumbPath field in Get request of SA PathRecord

[Sasha Khapyorsky]

On 06:51 Fri 20 Mar     , Hal Rosenstock wrote:
> 
> Also, cosmetic formatting changes

It would be really nice to not mix cosmetic and functional changes in
one patch.

> @@ -110,8 +110,7 @@ uint8_t *sa_call(void *rcvbuf, ib_portid_t * portid, ib_sa_call_t * sa,
>  #define	IB_PR_COMPMASK_PREFERENCE			(1ull<<22)
>  
>  #define IB_PR_DEF_MASK (IB_PR_COMPMASK_DGID |\
> -			IB_PR_COMPMASK_SGID |\
> -			IB_PR_COMPMASK_NUMBPATH)
> +			IB_PR_COMPMASK_SGID)
>  
>  int ib_path_query_via(const struct ibmad_port *srcport, ibmad_gid_t srcgid,
>  		      ibmad_gid_t destgid, ib_portid_t * sm_id, void *buf)
> @@ -130,7 +129,6 @@ int ib_path_query_via(const struct ibmad_port *srcport, ibmad_gid_t srcgid,
>  
>  	memset(buf, 0, IB_SA_PR_RECSZ);
>  
> -	mad_encode_field(buf, IB_SA_PR_NPATH_F, &npath);

Then you may want to remove unused npath variable.

Also do you think (or know) that it could break some non-OpenSM SAs?

Sasha