***SPAM*** Re: [ofa-general] Re: [PATCH] libibmad: Add PortSelect and CounterSelect fields for PortXmit/RcvDataSL attributes

[Hal Rosenstock]

On Fri, Mar 20, 2009 at 9:36 AM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
> On 15:36 Fri 13 Mar     , Hal Rosenstock wrote:
>>
>> Signed-off-by: Hal Rosenstock <hal.rosenstock at gmail.com>
>> ---
>> diff --git a/libibmad/include/infiniband/mad.h b/libibmad/include/infiniband/mad.h
>> index b8290a7..96bb482 100644
>> --- a/libibmad/include/infiniband/mad.h
>> +++ b/libibmad/include/infiniband/mad.h
>> @@ -564,7 +564,9 @@ enum MAD_FIELDS {
>>       IB_CPI_TRAP_QKEY_F,
>>
>>       IB_PC_XMT_DATA_SL_FIRST_F,
>> -     IB_PC_XMT_DATA_SL0_F = IB_PC_XMT_DATA_SL_FIRST_F,
>> +     IB_PC_XMT_DATA_SL_PORT_SELECT_F = IB_PC_XMT_DATA_SL_FIRST_F,
>> +     IB_PC_XMT_DATA_SL_COUNTER_SELECT_F,
>> +     IB_PC_XMT_DATA_SL0_F,
>>       IB_PC_XMT_DATA_SL1_F,
>>       IB_PC_XMT_DATA_SL2_F,
>>       IB_PC_XMT_DATA_SL3_F,
>> @@ -583,7 +585,9 @@ enum MAD_FIELDS {
>>       IB_PC_XMT_DATA_SL_LAST_F,
>>
>>       IB_PC_RCV_DATA_SL_FIRST_F,
>> -     IB_PC_RCV_DATA_SL0_F = IB_PC_RCV_DATA_SL_FIRST_F,
>> +     IB_PC_RCV_DATA_SL_PORT_SELECT_F = IB_PC_RCV_DATA_SL_FIRST_F,
>> +     IB_PC_RCV_DATA_SL_COUNTER_SELECT_F,
>> +     IB_PC_RCV_DATA_SL0_F,
>>       IB_PC_RCV_DATA_SL1_F,
>>       IB_PC_RCV_DATA_SL2_F,
>>       IB_PC_RCV_DATA_SL3_F,
>> diff --git a/libibmad/src/fields.c b/libibmad/src/fields.c
>> index 19c8fc1..ff94c45 100644
>> --- a/libibmad/src/fields.c
>> +++ b/libibmad/src/fields.c
>> @@ -402,6 +402,8 @@ static const ib_field_t ib_mad_f[] = {
>>       {BITSOFFS(520, 24), "TrapQP", mad_dump_hex},
>>       {544, 32, "TrapQKey", mad_dump_hex},
>>
>> +     {BITSOFFS(8, 8), "PortSelect", mad_dump_uint},
>> +     {BITSOFFS(16, 16), "CounterSelect", mad_dump_hex},
>>       {32,  32, "XmtDataSL0", mad_dump_uint},
>>       {64,  32, "XmtDataSL1", mad_dump_uint},
>>       {96,  32, "XmtDataSL2", mad_dump_uint},
>> @@ -420,6 +422,8 @@ static const ib_field_t ib_mad_f[] = {
>>       {512, 32, "XmtDataSL15", mad_dump_uint},
>>       {0, 0},                 /* IB_PC_XMT_DATA_SL_LAST_F */
>>
>> +     {BITSOFFS(8, 8), "PortSelect", mad_dump_uint},
>> +     {BITSOFFS(16, 16), "CounterSelect", mad_dump_hex},
>
> What will this actually buy for us?

Consistency with other PerfMgt attributes for starters.

> We will just have duplicated entries now.

Not sure what you mean by this.

-- Hal

> Sasha
>
>>       {32,  32, "RcvDataSL0", mad_dump_uint},
>>       {64,  32, "RcvDataSL1", mad_dump_uint},
>>       {96,  32, "RcvDataSL2", mad_dump_uint},
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>