[ofa-general] Re: [PATCH v2] rdma_cm: Add debugfs entries to monitor rdma_cm connections

[Moni Shoua]

Jason Gunthorpe wrote:
> On Thu, Apr 30, 2009 at 04:27:05PM +0300, Or Gerlitz wrote:
>> Jason Gunthorpe wrote:
>>> including a PID is not best, you should include enough information to 
>>> figure out the pid(s) from proc/xx/fd, and vice versa.
> 
>> maybe its not the best solution but it seems to me good enough
> 
> Well, we have to live with these interfaces literally forever,
> shortcuts ultimately just cause more problems down the road..
> 
> Reall the thinking should be 'I want to make lsof work usefully' not
> 'I want some random and different hack to let me see something'. And
> yes, that is harder. But the IB stack is now at the point where these
> small hard things are the sort of work that is needed to get parity
> with the other stuff in linux..
> 
> Jason
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
> 
debugfs is a common way to export data from kernel to users (IPoIB uses it) and it has it's advantages. On the other hand, netlink has it's disadvantages so, I don't think that debugfs is the wrong way. It's just another way.

Besides, remember that rdmacm is only aware of part of the opened QPs on the host which may lead to a confusion for one who reads the output of lsof ("I know that there is an open QP but I don't see it in the list")