[ofa-general] Re: [PATCH 1/2] osm_port.c: check if op_vls = 0 before max_op_vls comparison
Sasha Khapyorsky
sashak at voltaire.com
Tue May 12 12:00:36 PDT 2009
On 11:17 Sun 10 May , Doron Shoham wrote:
> check if op_vls = 0 before max_op_vls comparison
>
> Signed-off-by: Doron Shoham <dorons at voltaire.com>
Applied. Thanks. See comments below.
> ---
> opensm/opensm/osm_port.c | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/opensm/opensm/osm_port.c b/opensm/opensm/osm_port.c
> index 2e6c642..41b67ad 100644
> --- a/opensm/opensm/osm_port.c
> +++ b/opensm/opensm/osm_port.c
> @@ -376,15 +376,16 @@ uint8_t osm_physp_calc_link_op_vls(IN osm_log_t * p_log,
> } else
> op_vls = ib_port_info_get_op_vls(&p_physp->port_info);
>
> - /* support user limitation of max_op_vls */
> - if (op_vls > p_subn->opt.max_op_vls)
> - op_vls = p_subn->opt.max_op_vls;
> -
> if (op_vls == 0) {
> - OSM_LOG(p_log, OSM_LOG_DEBUG, "ERR 4102: "
> + /* for non compliant implementations */
^^^^
Please care to not introduce trailing spaces.
> + OSM_LOG(p_log, OSM_LOG_ERROR, "ERR 4102: "
Log level is OSM_LOG_VERBOSE now - merged with Hal's patches.
Sasha
More information about the general
mailing list