[ofa-general] Re: [PATCH] opensm: Add support for MulticastFDBTop

[Sasha Khapyorsky]

On 10:20 Mon 21 Sep     , Hal Rosenstock wrote:
> > > +
> > > +     if (p_physp->port_info.capability_mask &
> > IB_PORT_CAP_HAS_MCAST_FDB_TOP) {
> >
> > BTW any reason why this capability bit if placed in PortInfo and not in
> > SwitchInfo (it is not port but switch related feature)?
> 
> 
> I don't recall.

Could this be verified?

For me it does not look very reasonable to leak PortInfo:CapabilityMask
bits for this purpose, it is meanless for CA and switch external ports.

> > Switch's StateChange and LifeState are handled when unicast routing is
> > configured. Why do we need duplicate it here?
> >
> 
> I thought we could lose a PortStateChange

Basically we could lose this bit when doing reset twice - link state can
change in window between two resets.

Sasha