[ofa-general] Re: osm_link_mgr.c:link_mgr_get_smsl question

[Hal Rosenstock]

On Tue, Sep 22, 2009 at 10:53 PM, Sasha Khapyorsky <sashak at voltaire.com>wrote:

> On 16:44 Tue 22 Sep     , Hal Rosenstock wrote:
> >
> > Yeah, the port lid table will be OK but port's PortInfo won't (so base
> > LID/LMC will be broken) for this scenario but it wouldn't affect this
> code
> > in this way.
>

 Let me try this again... The port LID table is fine but the lookup is done
based on the LID in the received portInfo as it is the result of
osm_physp_get_base_lid() (osm_link_mgr.c:link_mgr_get_smsl line 83). In the
case of failed Sets, this is invalid so LID 0 is used and that's what causes
the NULL p_src_port which in turn causes the seg fault.

So I'm back to:

I can see two ways to fix this:
1. Replace with port GUID search
2. Have osm_get_lash_sl handle NULL for p_src_port
Maybe you see other ways to deal with this.

Do you have a preferred approach ?

-- Hal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20090923/0761e128/attachment.html>