[nvmewin] ***UNCHECKED*** Aug 28 - Patch (NVMe 1.0c Compliance and others)

[Luse, Paul E]

Great, thanks Alex!  We'll take a look this week for sure

Thx
Paul

From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Chang, Alex
Sent: Tuesday, August 28, 2012 4:40 PM
To: nvmewin at lists.openfabrics.org
Subject: [nvmewin] ***UNCHECKED*** Aug 28 - Patch (NVMe 1.0c Compliance and others)

Hi all,

Here's the next patch (password is idt123). Main changes related to NVMe 1.0c compliance, INTx race condition fix, etc. I'll be looking for feedback/approval by end of next week (September 7). Please let me know if you need more time. Tested as per our guidelines, and no issues.
NVMe 1.0c compliance:
- Added two functions, NVMeIoctlTxDataToDev and NVMeIoctlTxDataToHost, to handle data transferring via IOCTL vendor defined command
- Ensure transfer size is not zero when issuing IOCTL vendor unique command to transfer data.
- Added one new IOCTL code NVME_RESET_DEVICE to allow controller reset request from applications if necessary, such as after Firmware Activate command completed successfully.
- Changed NUMD to be 0's based for Firmware Image Download and Get Log Page commands.
- Changed LID field of Get Log Page command to be 8 bit in length.
- Changed Status field of Error Information Log Entry.
- Added checking Admin/NVM Vendor Specific Command Configuration bits before processing vendor-defined commands.
- Changed Length field of Security Send/Receive commands from 16 to 32 bits.
- Added supporting Admin/NVM Vendor Specific command format
- Fixed other errors in NVMe related structures
INTx race condition fix:
- Return TRUE only after confirming the ownership of the interrupt.
- Masking interrupt only after confirming the ownership of the interrupt.
- Moved interrupt unmasking within the DPC lock, just like masking.
Added ensuring all queues are deleted before shutting down the controller normally.
Added RDY bit checking whenever EN bit of CC is programmed.

Thanks,
Alex



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120829/3bb963a1/attachment.html>