[nvmewin] Patch Review Request

[Chang, Alex]

Hi all,

The updated patch is attached. The changes are made per feedbacks in the code review last Tuesday. I had done all the tests to ensure Format NVM command is working fine. Please review it and let me know if you have any questions.

Thanks,
Alex


________________________________
From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Chang, Alex
Sent: Friday, January 27, 2012 4:03 PM
To: nvmewin at lists.openfabrics.org
Subject: [nvmewin] Patch Review Request

Hi all,

 I am re-sending the requst. Please disgard the previous one I sent last week.
 Attached please find the implementation of handling Format NVM command and Namespace Hot Add/Remove via IOCTL Pass Through:
- nvmeinit.c: Removed redundant codes in MSI enumeration.
- nvmestd.c : Main implementation of Format NVM
- nvmesnti.c :
    a. Includes blocking IO for the target namespace while it's under formatting  and namespace add back logic
    b. Removed supporting Read/Write16 due to a bugcheck (0x19) when running SCSI Compliance 2.0
- nvmestd.h : Added definition of FORMAT_NVM_INFO structure.
- nvmeioctl.h:
    a. Added  three  more error codes, associated with Format NVM, that can be returned in ReturnCode of SRB_IO_CONTROL .
    b. Added two IOCTL codes, NVME_HOT_ADD_NAMESPACE and NVME_HOT_REMOVE_NAMESPACE.

Now, Format NVM can be done in two ways:
1. A single Format NVM command via IOCTL Pass Through request. The steps driver takes to complete the request are:
a. Removes the target namespace(s) first
b. Issues Format NVM command
c. Re-fetch Identify Controller structure
d. Re-fetch Identify Namespace structure(s)
e. Adds back the formatted namespace(s)

2. With NVME_HOT_ADD/REMOVE_NAMESPACE IOCTL calls and a Format NVM command via IOCTL Pass Through request:
a. Issue NVME_HOT_REMOVE_NAMESPACE IOCTL request to remove the target namespace(s)
b. Issue Format NVM command via IOCTL Pass Through request, which convers Step b, c and d of first method.
c. Issue NVME_HOT_ADD_NAMESPACE IOCTl request to add back the formatted namespace(s)

Thanks,
Alex

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120202/3d9c3024/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FormatNVM_new.zip
Type: application/x-zip-compressed
Size: 92960 bytes
Desc: FormatNVM_new.zip
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120202/3d9c3024/attachment.bin>