[nvmewin] StartIo Function Return value for NVMePowerControl

[Robles, Raymond C]

I must admit that I didn't quite understand the original problem stated and I should have asked for clarification sooner.  Ravi, can you please explain the problem that you see in the SRB_FUNCTION_POWER case by using line numbers from the source code so that we can track where the potential issue before submitting a code patch?

Are you inferring that the StartIo function will return FALSE even when the power request has been successfully completed?  As Alex mentioned, the StartIo function will return TRUE in the case of handling a SRB_FUNCTION_POWER request.  However, please note that we call StorPortNotification with the correct SrbStatus immediately after the call to NVMePowerControl.  This will complete the command appropriately back to Storport (with the correct status).  The StartIo will always return TRUE indicating the command was successfully started.

Thanks,
Ray

From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Chang, Alex
Sent: Wednesday, May 02, 2012 9:23 AM
To: Ravi Kumar; Luse, Paul E
Cc: nvmewin at lists.openfabrics.org
Subject: Re: [nvmewin] StartIo Function Return value for NVMePowerControl

Hi Ravi,

For SRB_FUNCTION_POWER requests, NVMeStartIo always returns TRUE (Line 1205 in nvmestd.c) to indicate the request had been successfully initiated/processed. I am not sure why you mentioned it returns FALSE to Storport driver?

Thanks,
Alex

________________________________
From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org]<mailto:[mailto:nvmewin-bounces at lists.openfabrics.org]> On Behalf Of Ravi Kumar
Sent: Tuesday, May 01, 2012 8:42 PM
To: Luse, Paul E
Cc: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: Re: [nvmewin] StartIo Function Return value for NVMePowerControl
Hi Paul,

I'll put the patch with proper fix in a day and update the same.

Regards,
Ravi Kumar
On Wed, May 2, 2012 at 1:14 AM, Luse, Paul E <paul.e.luse at intel.com<mailto:paul.e.luse at intel.com>> wrote:
Thanks for the note Ravi.  Can you please either put a patch together with the fix or simply enter a bug at https://www.openfabrics.org/resources/developer-tools/nvme-windows-development.html.  Using the list to simply report something is a good way to make sure it gets lost :)

From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org>] On Behalf Of Ravi Kumar
Sent: Sunday, April 29, 2012 10:32 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] StartIo Function Return value for NVMePowerControl

Hi,

As per observation on Windows the function NVMeStarIo(NVMeStd.c) for Power management, in case NVMePowerControl()
returns false it is still completed the request in NVMeStartIo and returns FALSE to StorPort driver. Whereas in case of StartIo returns FALSE StorPort driver treats IO has some issue and try to complete its own in AdapterControl call which create the BSOD to system (Multiple_IO_Request_Complete error).
  Don't we required to put the check in case failure of handle the power management system need not to be complete the Io as PortDriver makes it complete its own.


Regards,
Ravi Kumar



--
Regards,
Ravi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120502/5e133e45/attachment.html>