[nvmewin] Bug Fix Patch - Review Request

[Knoblaugh, Rick]

Hi Ray,
                  Sounds good to me as well. I have been in touch with Kris on one question that I had. So, far, no issues with the changes.

         Thanks,
                              -Rick

From: Robles, Raymond C [mailto:raymond.c.robles at intel.com]
Sent: Thursday, October 18, 2012 4:43 PM
To: NVMe Open Source Mailing List (mailto:nvmewin at lists.openfabrics.org); 'Chang, Alex (Alex.Chang at idt.com)'; Kong, Kwok; Knoblaugh, Rick; Patel, Arpit
Cc: Murray, Kris R; Luse, Paul E
Subject: RE: Bug Fix Patch - Review Request

IDT and LSI,

Just so we have a timeframe on the review, how does feedback by next Thursday (October 25th) EOD sound?

Thanks,
Ray

From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Murray, Kris R
Sent: Tuesday, October 16, 2012 10:07 AM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] Bug Fix Patch - Review Request

Hi all,

The attached NVMe.zip file changes include the below fixes:

*         nvmeStd.c

o   Added a call to StorPortGetUncachedExtension to fix a checked OS assertion

*         nvmeSnti.c

o   Fixed SntiTranslateRead6 function to use the Read mask for the lba instead of the write mask

o   Fixed SntiTranslateWrite6 function to use the correct macro for getting 24 bits from the CDB using the correct offset

*         nvmeSntiTypes.h

o   Updated READ_6_CDB_LBA_MASK definition to match the one for write

o   Fixed WRITE_6_CDB_LBA_OFFSET from 0 to 1

The attached Results.zip file contains results from the test matrix below:

Operating Systems:

*         Windows 7

*         Windows 8

*         Windows Server 2008

*         Windows Server 2012

Tests:

*         IOMeter

*         SCSI Compliance

*         PCMark

Please review the changes, feeling free to send me comments and questions.

Thanks,
~Kris Murray
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20121018/2d416f56/attachment.html>