[nvmewin] question in NVMeDetectPendingCmds

[Luse, Paul E]

Thanks Rick, appreciate that.  I probably won't have my patch ready this week after all, no big complexity or anything just time.  I'll take the AERs into account through for sure

Thx
Paul

From: Knoblaugh, Rick [mailto:Rick.Knoblaugh at lsi.com]
Sent: Tuesday, October 23, 2012 4:03 PM
To: Luse, Paul E; nvmewin at lists.openfabrics.org
Subject: RE: question in NVMeDetectPendingCmds

Hi Paul,
                      Yes, we did write that one. We wanted to check to ensure that no I/O commands were pending prior to shutting down. We weren't worried about Admin, as we would expect AERs to be always pending, and there probably wouldn't be much else - other than if there happened to be an AEN event and there was a subsequent Get Log Page pending. Actually, I suppose snti code may also issue something to Admin or potentially activity via pass through.

                      It could be enhanced to look at Admin as well, but I think we'd have to skip over AERs, as they will "always" be present/pending.

                    Thanks,

                                 -Rick


From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org]<mailto:[mailto:nvmewin-bounces at lists.openfabrics.org]> On Behalf Of Luse, Paul E
Sent: Sunday, October 21, 2012 7:08 AM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] question in NVMeDetectPendingCmds

Rick-

I *think* you might have put this in originally but am not positive, I'm currently fixing an issue in the recovery DPC routine (logic is wrong for determining the commands to complete on a reset) and I'm looking to re-use NVMeDetectPendingCmds() however I'm not sure why the function doesn't include looking at the admin queue.  For purposes of power mgmt., which is this was added, I'd think we'd be just as concerned with outstanding admin commands as we would IO commands so wondering why admin was excluded?

Thx
Paul

PS:  I'll prepare a patch for this error recovery logic fix in the next week or so

____________________________________
Paul Luse
Sr. Staff Engineer
PCG Server Software Engineering
Desk: 480.554.3688, Mobile: 480.334.4630

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20121023/660eeb4b/attachment.html>