From Kwok.Kong at pmcs.com Fri Aug 2 17:46:42 2013 From: Kwok.Kong at pmcs.com (Kwok Kong) Date: Fri, 2 Aug 2013 17:46:42 -0700 Subject: [nvmewin] NVMe Windows Driver Released As Revision 1.2 In-Reply-To: <40A0B8B92CE0F94685A03264958540C4EB0594@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> References: <40A0B8B92CE0F94685A03264958540C4EB0594@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> Message-ID: <40A0B8B92CE0F94685A03264958540C4F01DFE@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> Alex, Thanks for the 1.2 release. I would like to thank everyone who contributed to the 1.2 release. 1.2 release is now behind us and Let's focus on the 1.3 release. Thanks -Kwok From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Alex Chang Sent: Wednesday, July 31, 2013 11:41 AM To: nvmewin at lists.openfabrics.org Subject: [nvmewin] NVMe Windows Driver Released As Revision 1.2 Dear all, As we planned in our meeting of June, the first formal release as revision 1.2 from NVMe Windows Work Group has been made available now. You may download it from NVMe Windows Work Group SVN Repository: http://www.openfabrics.org/svnrepo/nvmewin After downloading it, you may find the release package under the newly-created directory called "releases". More information can also be found in readme.txt file. Should you have any questions, please reply to this email list. Thanks, Alex -------------- next part -------------- An HTML attachment was scrubbed... URL: From raymond.c.robles at intel.com Mon Aug 5 16:37:54 2013 From: raymond.c.robles at intel.com (Robles, Raymond C) Date: Mon, 5 Aug 2013 23:37:54 +0000 Subject: [nvmewin] Pulling a version- where to go, tag/ or trunk/? In-Reply-To: <05CD7821AE397547A01AC160FBC231474BCB0D15@corpmail1.na.ads.idt.com> References: <2D98093777D3FD46A36253F35FE9D6936FFD899C@ORSMSX109.amr.corp.intel.com> <05CD7821AE397547A01AC160FBC231474BCB0D15@corpmail1.na.ads.idt.com> Message-ID: <49158E750348AA499168FD41D88983606259FA13@FMSMSX105.amr.corp.intel.com> For future reference, any tags created mean that it is also in the trunk. So the 1.0e compliance changes are in the tag directory of IDT_NVMe_1_0_e_compliance as well as in the main trunk. I create the tags to be able to revert back to specific changesets. Thanks, Ray From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Kong, Kwok Sent: Tuesday, June 25, 2013 5:35 PM To: Freyensee, James P; nvmewin at lists.openfabrics.org Subject: Re: [nvmewin] Pulling a version- where to go, tag/ or trunk/? Jay, The latest OFA driver supports NVMe 1.00e specification. NVMe 1.1 is not supported. You can use the tag IDT_NVMe_1_0_e_compliance to pull the source code that conforms to the 1.00e NVMe specification. -Kwok From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Freyensee, James P Sent: Tuesday, June 25, 2013 5:17 PM To: nvmewin at lists.openfabrics.org Subject: [nvmewin] Pulling a version- where to go, tag/ or trunk/? I would like to pull a 1.0e or 1.1 version of the NVMe windows driver. Where in the source repo (I'm looking at http://www.openfabrics.org/svnrepo/nvmewin/) should I pull from? Trunk/? Or should I be using the tag IDT_NVMe_1_0_e_compliance (if I wanted a 1.0e version of the driver)? I don't see a tag that clues me in on a 1.1 version so I assume I would target Trunk/ for this version? Thanks for the help! Jay -------------- next part -------------- An HTML attachment was scrubbed... URL: From Alex.Chang at pmcs.com Wed Aug 7 15:45:41 2013 From: Alex.Chang at pmcs.com (Alex Chang) Date: Wed, 7 Aug 2013 15:45:41 -0700 Subject: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Message-ID: <40A0B8B92CE0F94685A03264958540C4F02871@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> Hi Dharani, Sorry to take such long time to get back to you and thank you for the effort. I just finished reviewing your changes and noticed you added a flag called "MultiplecoresToSingleQueueFlag". Does it mean there is only one IO queue being allocated and shared by all the cores? If yes, then the line you added (line#2828) in nvmeinit.c should be moved up to "fall back to use only one queue" case. Let me know what you think. By the way, have you tests it with drive formatting, IOMeter, SDStress and SCSI compliance yet? Thanks, Alex From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Dharani Kotte Sent: Wednesday, July 31, 2013 9:53 AM To: nvmewin at lists.openfabrics.org Subject: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Date: %%SENT_DATE%% Subject: Suspect Message Quarantined WARNING: The virus scanner was unable to scan an attachment in an email message sent to you. This attachment could possibly contain viruses or other malicious programs. The attachment could not be scanned for the following reasons: %%DESC%% The full message and the attachment have been stored in the quarantine. The identifier for this message is '%%QID%%'. Access the quarantine at: https://puremessage.pmc-sierra.bc.ca:28443/ For more information on PMC's Anti-Spam system: http://pmc-intranet/wiki/index.php/Outlook:Anti-Spam_FAQ IT Services PureMessage Admin The attached is the code with 32-bit support tested on the Win7/Win8 32-bit systems. Please review it and let me know the comments. Password: sndk1234 Thanks, Dharani. From: Kwok Kong [mailto:Kwok.Kong at pmcs.com] Sent: Wednesday, July 31, 2013 9:29 AM To: Dharani Kotte Cc: Dave Landsman; Gurpreet Anand; Sumant Patro Subject: RE: [WARNING - ENCRYPTED ATTACHMENT NOT VIRUS SCANNED] OFA NVMe Windows driver contribution Dharani, This is great. Would you please email it out to the following mailing list asking for review and approval ? nvmewin at lists.openfabrics.org thanks -Kwok From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Wednesday, July 31, 2013 9:08 AM To: Kong, Kwok (Kwok.Kong at idt.com); Kwok Kong Cc: Dave Landsman; Gurpreet Anand; Sumant Patro Subject: [WARNING - ENCRYPTED ATTACHMENT NOT VIRUS SCANNED] OFA NVMe Windows driver contribution Hi Kwok, The attached is the code with 32-bit support tested on the Win7/Win8 32-bit systems. Can you please send it for review and let me know the comments. Password: sndk1234 Thanks, Dharani. -----Original Message----- From: Kong, Kwok [mailto:Kwok.Kong at idt.com] Sent: Wednesday, June 26, 2013 12:58 To: Dave Landsman Subject: OFA NVMe Windows driver contribution Dave, We are working on a NVMe Windows driver feature planning for the Dec 2013 release. Samsung cannot take on the task to get the driver to support windows 32-bit systems. I wonder if Sandisk can take on the task to get the driver to work in Windows 32-bit system. It is much appreciated if Sandisk can take this task on. Please let me know what you think. Thanks -Kwok ________________________________ PLEASE NOTE: The information contained in this electronic mail message is intended only for the use of the designated recipient(s) named above. If the reader of this message is not the intended recipient, you are hereby notified that you have received this message in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. If you have received this communication in error, please notify the sender by telephone or e-mail (as shown above) immediately and destroy any and all copies of this message in your possession (whether hard copies or electronically stored copies). -------------- next part -------------- An HTML attachment was scrubbed... URL: From Dharani.Kotte at sandisk.com Wed Aug 7 15:59:55 2013 From: Dharani.Kotte at sandisk.com (Dharani Kotte) Date: Wed, 7 Aug 2013 22:59:55 +0000 Subject: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 In-Reply-To: <40A0B8B92CE0F94685A03264958540C4F02871@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> References: <40A0B8B92CE0F94685A03264958540C4F02871@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> Message-ID: <23EC73C80FB59046A6B7B8EB7B3826593205F851@SACMBXIP01.sdcorp.global.sandisk.com> Hi Alex, The situation was that when "pQI->NumSubIoQAllocFromAdapter" variable is set to 1 which means that the controller want only 1 IO queue. In this case it doesn't even enter into "if (pQI->NumSubIoQAllocated < QueueID){}" statement. But we need to use StartLocks when ever 2 or more cores shares the same queue. The "fall back to use only one queue" case is covered only in the situation where the NVMeAllocQueues() fails for the Queue, This condition I didn't hit but you are right we may have to add this flag in that condition as well. drive formatting - If it is windows NTFS format I tested for Win8/Win7 32-bit IOMeter - I tested for Win8/Win7 32-bit SDStress - I have not tested is it part of WHQL SCSI compliance - I have not tested since I didn't touch any part of the code that is related to SCSI Compliance but I can test it Thanks, Dharani. From: Alex Chang [mailto:Alex.Chang at pmcs.com] Sent: Wednesday, August 07, 2013 3:46 PM To: Dharani Kotte; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Dharani, Sorry to take such long time to get back to you and thank you for the effort. I just finished reviewing your changes and noticed you added a flag called "MultiplecoresToSingleQueueFlag". Does it mean there is only one IO queue being allocated and shared by all the cores? If yes, then the line you added (line#2828) in nvmeinit.c should be moved up to "fall back to use only one queue" case. Let me know what you think. By the way, have you tests it with drive formatting, IOMeter, SDStress and SCSI compliance yet? Thanks, Alex From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Dharani Kotte Sent: Wednesday, July 31, 2013 9:53 AM To: nvmewin at lists.openfabrics.org Subject: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Date: %%SENT_DATE%% Subject: Suspect Message Quarantined WARNING: The virus scanner was unable to scan an attachment in an email message sent to you. This attachment could possibly contain viruses or other malicious programs. The attachment could not be scanned for the following reasons: %%DESC%% The full message and the attachment have been stored in the quarantine. The identifier for this message is '%%QID%%'. Access the quarantine at: https://puremessage.pmc-sierra.bc.ca:28443/ For more information on PMC's Anti-Spam system: http://pmc-intranet/wiki/index.php/Outlook:Anti-Spam_FAQ IT Services PureMessage Admin The attached is the code with 32-bit support tested on the Win7/Win8 32-bit systems. Please review it and let me know the comments. Password: sndk1234 Thanks, Dharani. From: Kwok Kong [mailto:Kwok.Kong at pmcs.com] Sent: Wednesday, July 31, 2013 9:29 AM To: Dharani Kotte Cc: Dave Landsman; Gurpreet Anand; Sumant Patro Subject: RE: [WARNING - ENCRYPTED ATTACHMENT NOT VIRUS SCANNED] OFA NVMe Windows driver contribution Dharani, This is great. Would you please email it out to the following mailing list asking for review and approval ? nvmewin at lists.openfabrics.org thanks -Kwok From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Wednesday, July 31, 2013 9:08 AM To: Kong, Kwok (Kwok.Kong at idt.com); Kwok Kong Cc: Dave Landsman; Gurpreet Anand; Sumant Patro Subject: [WARNING - ENCRYPTED ATTACHMENT NOT VIRUS SCANNED] OFA NVMe Windows driver contribution Hi Kwok, The attached is the code with 32-bit support tested on the Win7/Win8 32-bit systems. Can you please send it for review and let me know the comments. Password: sndk1234 Thanks, Dharani. -----Original Message----- From: Kong, Kwok [mailto:Kwok.Kong at idt.com] Sent: Wednesday, June 26, 2013 12:58 To: Dave Landsman Subject: OFA NVMe Windows driver contribution Dave, We are working on a NVMe Windows driver feature planning for the Dec 2013 release. Samsung cannot take on the task to get the driver to support windows 32-bit systems. I wonder if Sandisk can take on the task to get the driver to work in Windows 32-bit system. It is much appreciated if Sandisk can take this task on. Please let me know what you think. Thanks -Kwok ________________________________ PLEASE NOTE: The information contained in this electronic mail message is intended only for the use of the designated recipient(s) named above. If the reader of this message is not the intended recipient, you are hereby notified that you have received this message in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. If you have received this communication in error, please notify the sender by telephone or e-mail (as shown above) immediately and destroy any and all copies of this message in your possession (whether hard copies or electronically stored copies). -------------- next part -------------- An HTML attachment was scrubbed... URL: From Alex.Chang at pmcs.com Wed Aug 7 17:06:21 2013 From: Alex.Chang at pmcs.com (Alex Chang) Date: Wed, 7 Aug 2013 17:06:21 -0700 Subject: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 In-Reply-To: <23EC73C80FB59046A6B7B8EB7B3826593205F851@SACMBXIP01.sdcorp.global.sandisk.com> References: <40A0B8B92CE0F94685A03264958540C4F02871@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> <23EC73C80FB59046A6B7B8EB7B3826593205F851@SACMBXIP01.sdcorp.global.sandisk.com> Message-ID: <40A0B8B92CE0F94685A03264958540C4F028B5@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> Hi Dharani, Please see my comments in red... Thanks, Alex From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Wednesday, August 07, 2013 4:00 PM To: Alex Chang; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Alex, The situation was that when "pQI->NumSubIoQAllocFromAdapter" variable is set to 1 which means that the controller want only 1 IO queue. In this case it doesn't even enter into "if (pQI->NumSubIoQAllocated < QueueID){}" statement. If that's true, then there is no IO queue allocated at all, isn't it? But we need to use StartLocks when ever 2 or more cores shares the same queue. The "fall back to use only one queue" case is covered only in the situation where the NVMeAllocQueues() fails for the Queue, This condition I didn't hit but you are right we may have to add this flag in that condition as well. drive formatting - If it is windows NTFS format I tested for Win8/Win7 32-bit. IOMeter - I tested for Win8/Win7 32-bit SDStress - I have not tested is it part of WHQL. Please test it if you have chance. SCSI compliance - I have not tested since I didn't touch any part of the code that is related to SCSI Compliance but I can test it Thanks, Dharani. From: Alex Chang [mailto:Alex.Chang at pmcs.com] Sent: Wednesday, August 07, 2013 3:46 PM To: Dharani Kotte; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Dharani, Sorry to take such long time to get back to you and thank you for the effort. I just finished reviewing your changes and noticed you added a flag called "MultiplecoresToSingleQueueFlag". Does it mean there is only one IO queue being allocated and shared by all the cores? If yes, then the line you added (line#2828) in nvmeinit.c should be moved up to "fall back to use only one queue" case. Let me know what you think. By the way, have you tests it with drive formatting, IOMeter, SDStress and SCSI compliance yet? Thanks, Alex From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Dharani Kotte Sent: Wednesday, July 31, 2013 9:53 AM To: nvmewin at lists.openfabrics.org Subject: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Date: %%SENT_DATE%% Subject: Suspect Message Quarantined WARNING: The virus scanner was unable to scan an attachment in an email message sent to you. This attachment could possibly contain viruses or other malicious programs. The attachment could not be scanned for the following reasons: %%DESC%% The full message and the attachment have been stored in the quarantine. The identifier for this message is '%%QID%%'. Access the quarantine at: https://puremessage.pmc-sierra.bc.ca:28443/ For more information on PMC's Anti-Spam system: http://pmc-intranet/wiki/index.php/Outlook:Anti-Spam_FAQ IT Services PureMessage Admin The attached is the code with 32-bit support tested on the Win7/Win8 32-bit systems. Please review it and let me know the comments. Password: sndk1234 Thanks, Dharani. From: Kwok Kong [mailto:Kwok.Kong at pmcs.com] Sent: Wednesday, July 31, 2013 9:29 AM To: Dharani Kotte Cc: Dave Landsman; Gurpreet Anand; Sumant Patro Subject: RE: [WARNING - ENCRYPTED ATTACHMENT NOT VIRUS SCANNED] OFA NVMe Windows driver contribution Dharani, This is great. Would you please email it out to the following mailing list asking for review and approval ? nvmewin at lists.openfabrics.org thanks -Kwok From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Wednesday, July 31, 2013 9:08 AM To: Kong, Kwok (Kwok.Kong at idt.com); Kwok Kong Cc: Dave Landsman; Gurpreet Anand; Sumant Patro Subject: [WARNING - ENCRYPTED ATTACHMENT NOT VIRUS SCANNED] OFA NVMe Windows driver contribution Hi Kwok, The attached is the code with 32-bit support tested on the Win7/Win8 32-bit systems. Can you please send it for review and let me know the comments. Password: sndk1234 Thanks, Dharani. -----Original Message----- From: Kong, Kwok [mailto:Kwok.Kong at idt.com] Sent: Wednesday, June 26, 2013 12:58 To: Dave Landsman Subject: OFA NVMe Windows driver contribution Dave, We are working on a NVMe Windows driver feature planning for the Dec 2013 release. Samsung cannot take on the task to get the driver to support windows 32-bit systems. I wonder if Sandisk can take on the task to get the driver to work in Windows 32-bit system. It is much appreciated if Sandisk can take this task on. Please let me know what you think. Thanks -Kwok ________________________________ PLEASE NOTE: The information contained in this electronic mail message is intended only for the use of the designated recipient(s) named above. If the reader of this message is not the intended recipient, you are hereby notified that you have received this message in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. If you have received this communication in error, please notify the sender by telephone or e-mail (as shown above) immediately and destroy any and all copies of this message in your possession (whether hard copies or electronically stored copies). -------------- next part -------------- An HTML attachment was scrubbed... URL: From Dharani.Kotte at sandisk.com Wed Aug 7 17:16:22 2013 From: Dharani.Kotte at sandisk.com (Dharani Kotte) Date: Thu, 8 Aug 2013 00:16:22 +0000 Subject: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 In-Reply-To: <40A0B8B92CE0F94685A03264958540C4F028B5@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> References: <40A0B8B92CE0F94685A03264958540C4F02871@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> <23EC73C80FB59046A6B7B8EB7B3826593205F851@SACMBXIP01.sdcorp.global.sandisk.com>, <40A0B8B92CE0F94685A03264958540C4F028B5@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> Message-ID: <23EC73C80FB59046A6B7B8EB7B3826593205F8B2@SACMBXIP01.sdcorp.global.sandisk.com> Hi Alex. Comments in Green ... Thanks, Dharani. ________________________________ From: Alex Chang [Alex.Chang at pmcs.com] Sent: Wednesday, August 07, 2013 5:06 PM To: Dharani Kotte; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Dharani, Please see my comments in red… Thanks, Alex From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Wednesday, August 07, 2013 4:00 PM To: Alex Chang; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Alex, The situation was that when “pQI->NumSubIoQAllocFromAdapter” variable is set to 1 which means that the controller want only 1 IO queue. In this case it doesn’t even enter into “if (pQI->NumSubIoQAllocated < QueueID){}” statement. If that’s true, then there is no IO queue allocated at all, isn’t it? 1 Queue is created but after that the Queue number will be forced to 1 and hence all the cores available are getting mapped to Queue 1. But we need to use StartLocks when ever 2 or more cores shares the same queue. The “fall back to use only one queue” case is covered only in the situation where the NVMeAllocQueues() fails for the Queue, This condition I didn’t hit but you are right we may have to add this flag in that condition as well. drive formatting – If it is windows NTFS format I tested for Win8/Win7 32-bit. IOMeter – I tested for Win8/Win7 32-bit SDStress – I have not tested is it part of WHQL. Please test it if you have chance. I don't have a WHQL setup right now, Can you pass the SDStress exe if anything available with you. SCSI compliance – I have not tested since I didn’t touch any part of the code that is related to SCSI Compliance but I can test it Thanks, Dharani. From: Alex Chang [mailto:Alex.Chang at pmcs.com] Sent: Wednesday, August 07, 2013 3:46 PM To: Dharani Kotte; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Dharani, Sorry to take such long time to get back to you and thank you for the effort. I just finished reviewing your changes and noticed you added a flag called “MultiplecoresToSingleQueueFlag”. Does it mean there is only one IO queue being allocated and shared by all the cores? If yes, then the line you added (line#2828) in nvmeinit.c should be moved up to “fall back to use only one queue” case. Let me know what you think. By the way, have you tests it with drive formatting, IOMeter, SDStress and SCSI compliance yet? Thanks, Alex From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Dharani Kotte Sent: Wednesday, July 31, 2013 9:53 AM To: nvmewin at lists.openfabrics.org Subject: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Date: %%SENT_DATE%% Subject: Suspect Message Quarantined WARNING: The virus scanner was unable to scan an attachment in an email message sent to you. This attachment could possibly contain viruses or other malicious programs. The attachment could not be scanned for the following reasons: %%DESC%% The full message and the attachment have been stored in the quarantine. The identifier for this message is '%%QID%%'. Access the quarantine at: https://puremessage.pmc-sierra.bc.ca:28443/ For more information on PMC's Anti-Spam system: http://pmc-intranet/wiki/index.php/Outlook:Anti-Spam_FAQ IT Services PureMessage Admin The attached is the code with 32-bit support tested on the Win7/Win8 32-bit systems. Please review it and let me know the comments. Password: sndk1234 Thanks, Dharani. From: Kwok Kong [mailto:Kwok.Kong at pmcs.com] Sent: Wednesday, July 31, 2013 9:29 AM To: Dharani Kotte Cc: Dave Landsman; Gurpreet Anand; Sumant Patro Subject: RE: [WARNING - ENCRYPTED ATTACHMENT NOT VIRUS SCANNED] OFA NVMe Windows driver contribution Dharani, This is great. Would you please email it out to the following mailing list asking for review and approval ? nvmewin at lists.openfabrics.org thanks -Kwok From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Wednesday, July 31, 2013 9:08 AM To: Kong, Kwok (Kwok.Kong at idt.com); Kwok Kong Cc: Dave Landsman; Gurpreet Anand; Sumant Patro Subject: [WARNING - ENCRYPTED ATTACHMENT NOT VIRUS SCANNED] OFA NVMe Windows driver contribution Hi Kwok, The attached is the code with 32-bit support tested on the Win7/Win8 32-bit systems. Can you please send it for review and let me know the comments. Password: sndk1234 Thanks, Dharani. -----Original Message----- From: Kong, Kwok [mailto:Kwok.Kong at idt.com] Sent: Wednesday, June 26, 2013 12:58 To: Dave Landsman Subject: OFA NVMe Windows driver contribution Dave, We are working on a NVMe Windows driver feature planning for the Dec 2013 release. Samsung cannot take on the task to get the driver to support windows 32-bit systems. I wonder if Sandisk can take on the task to get the driver to work in Windows 32-bit system. It is much appreciated if Sandisk can take this task on. Please let me know what you think. Thanks -Kwok ________________________________ PLEASE NOTE: The information contained in this electronic mail message is intended only for the use of the designated recipient(s) named above. If the reader of this message is not the intended recipient, you are hereby notified that you have received this message in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. If you have received this communication in error, please notify the sender by telephone or e-mail (as shown above) immediately and destroy any and all copies of this message in your possession (whether hard copies or electronically stored copies). -------------- next part -------------- An HTML attachment was scrubbed... URL: From Alex.Chang at pmcs.com Wed Aug 7 17:25:43 2013 From: Alex.Chang at pmcs.com (Alex Chang) Date: Wed, 7 Aug 2013 17:25:43 -0700 Subject: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 In-Reply-To: <23EC73C80FB59046A6B7B8EB7B3826593205F8B2@SACMBXIP01.sdcorp.global.sandisk.com> References: <40A0B8B92CE0F94685A03264958540C4F02871@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> <23EC73C80FB59046A6B7B8EB7B3826593205F851@SACMBXIP01.sdcorp.global.sandisk.com>, <40A0B8B92CE0F94685A03264958540C4F028B5@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> <23EC73C80FB59046A6B7B8EB7B3826593205F8B2@SACMBXIP01.sdcorp.global.sandisk.com> Message-ID: <40A0B8B92CE0F94685A03264958540C4F028C5@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> Hi Dharani, When you said "it doesn't even enter into "if (pQI->NumSubIoQAllocated < QueueID){}" statement.", which is not true. And you're right that there will be one IO queue allocation attempt at least. Looks like whenever any given queue is shared by multiple cores, you need to set the flag to be ture. Thanks, Alex From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Wednesday, August 07, 2013 5:16 PM To: Alex Chang; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Alex. Comments in Green ... Thanks, Dharani. ________________________________ From: Alex Chang [Alex.Chang at pmcs.com] Sent: Wednesday, August 07, 2013 5:06 PM To: Dharani Kotte; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Dharani, Please see my comments in red... Thanks, Alex From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Wednesday, August 07, 2013 4:00 PM To: Alex Chang; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Alex, The situation was that when "pQI->NumSubIoQAllocFromAdapter" variable is set to 1 which means that the controller want only 1 IO queue. In this case it doesn't even enter into "if (pQI->NumSubIoQAllocated < QueueID){}" statement. If that's true, then there is no IO queue allocated at all, isn't it? 1 Queue is created but after that the Queue number will be forced to 1 and hence all the cores available are getting mapped to Queue 1. But we need to use StartLocks when ever 2 or more cores shares the same queue. The "fall back to use only one queue" case is covered only in the situation where the NVMeAllocQueues() fails for the Queue, This condition I didn't hit but you are right we may have to add this flag in that condition as well. drive formatting - If it is windows NTFS format I tested for Win8/Win7 32-bit. IOMeter - I tested for Win8/Win7 32-bit SDStress - I have not tested is it part of WHQL. Please test it if you have chance. I don't have a WHQL setup right now, Can you pass the SDStress exe if anything available with you. SCSI compliance - I have not tested since I didn't touch any part of the code that is related to SCSI Compliance but I can test it Thanks, Dharani. From: Alex Chang [mailto:Alex.Chang at pmcs.com] Sent: Wednesday, August 07, 2013 3:46 PM To: Dharani Kotte; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Dharani, Sorry to take such long time to get back to you and thank you for the effort. I just finished reviewing your changes and noticed you added a flag called "MultiplecoresToSingleQueueFlag". Does it mean there is only one IO queue being allocated and shared by all the cores? If yes, then the line you added (line#2828) in nvmeinit.c should be moved up to "fall back to use only one queue" case. Let me know what you think. By the way, have you tests it with drive formatting, IOMeter, SDStress and SCSI compliance yet? Thanks, Alex From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Dharani Kotte Sent: Wednesday, July 31, 2013 9:53 AM To: nvmewin at lists.openfabrics.org Subject: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Date: %%SENT_DATE%% Subject: Suspect Message Quarantined WARNING: The virus scanner was unable to scan an attachment in an email message sent to you. This attachment could possibly contain viruses or other malicious programs. The attachment could not be scanned for the following reasons: %%DESC%% The full message and the attachment have been stored in the quarantine. The identifier for this message is '%%QID%%'. Access the quarantine at: https://puremessage.pmc-sierra.bc.ca:28443/ For more information on PMC's Anti-Spam system: http://pmc-intranet/wiki/index.php/Outlook:Anti-Spam_FAQ IT Services PureMessage Admin The attached is the code with 32-bit support tested on the Win7/Win8 32-bit systems. Please review it and let me know the comments. Password: sndk1234 Thanks, Dharani. From: Kwok Kong [mailto:Kwok.Kong at pmcs.com] Sent: Wednesday, July 31, 2013 9:29 AM To: Dharani Kotte Cc: Dave Landsman; Gurpreet Anand; Sumant Patro Subject: RE: [WARNING - ENCRYPTED ATTACHMENT NOT VIRUS SCANNED] OFA NVMe Windows driver contribution Dharani, This is great. Would you please email it out to the following mailing list asking for review and approval ? nvmewin at lists.openfabrics.org thanks -Kwok From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Wednesday, July 31, 2013 9:08 AM To: Kong, Kwok (Kwok.Kong at idt.com); Kwok Kong Cc: Dave Landsman; Gurpreet Anand; Sumant Patro Subject: [WARNING - ENCRYPTED ATTACHMENT NOT VIRUS SCANNED] OFA NVMe Windows driver contribution Hi Kwok, The attached is the code with 32-bit support tested on the Win7/Win8 32-bit systems. Can you please send it for review and let me know the comments. Password: sndk1234 Thanks, Dharani. -----Original Message----- From: Kong, Kwok [mailto:Kwok.Kong at idt.com] Sent: Wednesday, June 26, 2013 12:58 To: Dave Landsman Subject: OFA NVMe Windows driver contribution Dave, We are working on a NVMe Windows driver feature planning for the Dec 2013 release. Samsung cannot take on the task to get the driver to support windows 32-bit systems. I wonder if Sandisk can take on the task to get the driver to work in Windows 32-bit system. It is much appreciated if Sandisk can take this task on. Please let me know what you think. Thanks -Kwok ________________________________ PLEASE NOTE: The information contained in this electronic mail message is intended only for the use of the designated recipient(s) named above. If the reader of this message is not the intended recipient, you are hereby notified that you have received this message in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. If you have received this communication in error, please notify the sender by telephone or e-mail (as shown above) immediately and destroy any and all copies of this message in your possession (whether hard copies or electronically stored copies). -------------- next part -------------- An HTML attachment was scrubbed... URL: From judy.brock at ssi.samsung.com Wed Aug 7 19:25:28 2013 From: judy.brock at ssi.samsung.com (Judy Brock-SSI) Date: Thu, 8 Aug 2013 02:25:28 +0000 Subject: [nvmewin] Building for Windows 8 and Windows 8+ In-Reply-To: <70C73440F9F7C24F81A11355C292A9B5902DB0FE@NTXBOIMBX04.micron.com> References: <70C73440F9F7C24F81A11355C292A9B5902DB0FE@NTXBOIMBX04.micron.com> Message-ID: <36E8D38D6B771A4BBDB1C0D800158A513127EC3F@SSIEXCH-MB3.ssi.samsung.com> I think Robert makes an important point below. Where are the VS solutions (both free and checked build) that were used to build OFA release 1.2? To establish/be able to rely on a stable reproducible baseline, we cannot not all use private build environments. To do so risks running into potentially serious divergences in driver behavior/stability such as that which was uncovered when some were building with the old COMPLETE_IN_DPC flag while others of us were not. It also potentially wastes a lot of dev/test time. Second question: which tools were used? VS 2012 or 2013? WDK 8.0 or 8.1? Thanks, Judy From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Robert Randall (rrandall) Sent: Monday, July 22, 2013 12:28 PM To: nvmewin at lists.openfabrics.org Subject: [nvmewin] Building for Windows 8 and Windows 8+ All, Are there plans to supply a build environment for v8 of the WDK and forward? The current source tree appears to rely only on the older tools (build, etc). With Microsoft forcing folks to use Visual Studio 11 / 2012 starting with v8 of the WDK does everyone use a private build environment or are there plans to add a VS Solution or VS compatible makefile to the repository? I tend to be IDE agnostic and prefer makefiles but either one would work fine. I may be able to volunteer for the task... Best regards, Robert. -------------- next part -------------- An HTML attachment was scrubbed... URL: From Alex.Chang at pmcs.com Thu Aug 8 09:18:29 2013 From: Alex.Chang at pmcs.com (Alex Chang) Date: Thu, 8 Aug 2013 09:18:29 -0700 Subject: [nvmewin] Building for Windows 8 and Windows 8+ Message-ID: <40A0B8B92CE0F94685A03264958540C4F029E7@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> Hi all, I agree that it would be very convenient just like other open sources if we have the associated VS 2012 solution/project files released. They will be ready early next week. Please note that the solution/project files are for free builds only. If you need to do check builds, you may configure from Project Configuration Property after launching the solution files. Thanks, Alex From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Judy Brock-SSI Sent: Wednesday, August 07, 2013 7:25 PM To: nvmewin at lists.openfabrics.org Subject: Re: [nvmewin] Building for Windows 8 and Windows 8+ I think Robert makes an important point below. Where are the VS solutions (both free and checked build) that were used to build OFA release 1.2? To establish/be able to rely on a stable reproducible baseline, we cannot not all use private build environments. To do so risks running into potentially serious divergences in driver behavior/stability such as that which was uncovered when some were building with the old COMPLETE_IN_DPC flag while others of us were not. It also potentially wastes a lot of dev/test time. Second question: which tools were used? VS 2012 or 2013? WDK 8.0 or 8.1? Thanks, Judy From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Robert Randall (rrandall) Sent: Monday, July 22, 2013 12:28 PM To: nvmewin at lists.openfabrics.org Subject: [nvmewin] Building for Windows 8 and Windows 8+ All, Are there plans to supply a build environment for v8 of the WDK and forward? The current source tree appears to rely only on the older tools (build, etc). With Microsoft forcing folks to use Visual Studio 11 / 2012 starting with v8 of the WDK does everyone use a private build environment or are there plans to add a VS Solution or VS compatible makefile to the repository? I tend to be IDE agnostic and prefer makefiles but either one would work fine. I may be able to volunteer for the task... Best regards, Robert. -------------- next part -------------- An HTML attachment was scrubbed... URL: From Dharani.Kotte at sandisk.com Thu Aug 8 09:27:01 2013 From: Dharani.Kotte at sandisk.com (Dharani Kotte) Date: Thu, 8 Aug 2013 16:27:01 +0000 Subject: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 In-Reply-To: <40A0B8B92CE0F94685A03264958540C4F028C5@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> References: <40A0B8B92CE0F94685A03264958540C4F02871@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> <23EC73C80FB59046A6B7B8EB7B3826593205F851@SACMBXIP01.sdcorp.global.sandisk.com>, <40A0B8B92CE0F94685A03264958540C4F028B5@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> <23EC73C80FB59046A6B7B8EB7B3826593205F8B2@SACMBXIP01.sdcorp.global.sandisk.com> <40A0B8B92CE0F94685A03264958540C4F028C5@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> Message-ID: <23EC73C80FB59046A6B7B8EB7B3826593205FA13@SACMBXIP01.sdcorp.global.sandisk.com> Hi Alex, I will add the flag where ever necessary. Can you please send me the SDStress application that you are using so that I can perform this test as well. Thanks, Dharani. From: Alex Chang [mailto:Alex.Chang at pmcs.com] Sent: Wednesday, August 07, 2013 5:26 PM To: Dharani Kotte; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Dharani, When you said "it doesn't even enter into "if (pQI->NumSubIoQAllocated < QueueID){}" statement.", which is not true. And you're right that there will be one IO queue allocation attempt at least. Looks like whenever any given queue is shared by multiple cores, you need to set the flag to be ture. Thanks, Alex From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Wednesday, August 07, 2013 5:16 PM To: Alex Chang; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Alex. Comments in Green ... Thanks, Dharani. ________________________________ From: Alex Chang [Alex.Chang at pmcs.com] Sent: Wednesday, August 07, 2013 5:06 PM To: Dharani Kotte; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Dharani, Please see my comments in red... Thanks, Alex From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Wednesday, August 07, 2013 4:00 PM To: Alex Chang; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Alex, The situation was that when "pQI->NumSubIoQAllocFromAdapter" variable is set to 1 which means that the controller want only 1 IO queue. In this case it doesn't even enter into "if (pQI->NumSubIoQAllocated < QueueID){}" statement. If that's true, then there is no IO queue allocated at all, isn't it? 1 Queue is created but after that the Queue number will be forced to 1 and hence all the cores available are getting mapped to Queue 1. But we need to use StartLocks when ever 2 or more cores shares the same queue. The "fall back to use only one queue" case is covered only in the situation where the NVMeAllocQueues() fails for the Queue, This condition I didn't hit but you are right we may have to add this flag in that condition as well. drive formatting - If it is windows NTFS format I tested for Win8/Win7 32-bit. IOMeter - I tested for Win8/Win7 32-bit SDStress - I have not tested is it part of WHQL. Please test it if you have chance. I don't have a WHQL setup right now, Can you pass the SDStress exe if anything available with you. SCSI compliance - I have not tested since I didn't touch any part of the code that is related to SCSI Compliance but I can test it Thanks, Dharani. From: Alex Chang [mailto:Alex.Chang at pmcs.com] Sent: Wednesday, August 07, 2013 3:46 PM To: Dharani Kotte; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Dharani, Sorry to take such long time to get back to you and thank you for the effort. I just finished reviewing your changes and noticed you added a flag called "MultiplecoresToSingleQueueFlag". Does it mean there is only one IO queue being allocated and shared by all the cores? If yes, then the line you added (line#2828) in nvmeinit.c should be moved up to "fall back to use only one queue" case. Let me know what you think. By the way, have you tests it with drive formatting, IOMeter, SDStress and SCSI compliance yet? Thanks, Alex From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Dharani Kotte Sent: Wednesday, July 31, 2013 9:53 AM To: nvmewin at lists.openfabrics.org Subject: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Date: %%SENT_DATE%% Subject: Suspect Message Quarantined WARNING: The virus scanner was unable to scan an attachment in an email message sent to you. This attachment could possibly contain viruses or other malicious programs. The attachment could not be scanned for the following reasons: %%DESC%% The full message and the attachment have been stored in the quarantine. The identifier for this message is '%%QID%%'. Access the quarantine at: https://puremessage.pmc-sierra.bc.ca:28443/ For more information on PMC's Anti-Spam system: http://pmc-intranet/wiki/index.php/Outlook:Anti-Spam_FAQ IT Services PureMessage Admin The attached is the code with 32-bit support tested on the Win7/Win8 32-bit systems. Please review it and let me know the comments. Password: sndk1234 Thanks, Dharani. From: Kwok Kong [mailto:Kwok.Kong at pmcs.com] Sent: Wednesday, July 31, 2013 9:29 AM To: Dharani Kotte Cc: Dave Landsman; Gurpreet Anand; Sumant Patro Subject: RE: [WARNING - ENCRYPTED ATTACHMENT NOT VIRUS SCANNED] OFA NVMe Windows driver contribution Dharani, This is great. Would you please email it out to the following mailing list asking for review and approval ? nvmewin at lists.openfabrics.org thanks -Kwok From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Wednesday, July 31, 2013 9:08 AM To: Kong, Kwok (Kwok.Kong at idt.com); Kwok Kong Cc: Dave Landsman; Gurpreet Anand; Sumant Patro Subject: [WARNING - ENCRYPTED ATTACHMENT NOT VIRUS SCANNED] OFA NVMe Windows driver contribution Hi Kwok, The attached is the code with 32-bit support tested on the Win7/Win8 32-bit systems. Can you please send it for review and let me know the comments. Password: sndk1234 Thanks, Dharani. -----Original Message----- From: Kong, Kwok [mailto:Kwok.Kong at idt.com] Sent: Wednesday, June 26, 2013 12:58 To: Dave Landsman Subject: OFA NVMe Windows driver contribution Dave, We are working on a NVMe Windows driver feature planning for the Dec 2013 release. Samsung cannot take on the task to get the driver to support windows 32-bit systems. I wonder if Sandisk can take on the task to get the driver to work in Windows 32-bit system. It is much appreciated if Sandisk can take this task on. Please let me know what you think. Thanks -Kwok ________________________________ PLEASE NOTE: The information contained in this electronic mail message is intended only for the use of the designated recipient(s) named above. If the reader of this message is not the intended recipient, you are hereby notified that you have received this message in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. If you have received this communication in error, please notify the sender by telephone or e-mail (as shown above) immediately and destroy any and all copies of this message in your possession (whether hard copies or electronically stored copies). -------------- next part -------------- An HTML attachment was scrubbed... URL: From Dharani.Kotte at sandisk.com Thu Aug 8 09:57:04 2013 From: Dharani.Kotte at sandisk.com (Dharani Kotte) Date: Thu, 8 Aug 2013 16:57:04 +0000 Subject: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 In-Reply-To: <40A0B8B92CE0F94685A03264958540C4F02A08@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> References: <40A0B8B92CE0F94685A03264958540C4F02871@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> <23EC73C80FB59046A6B7B8EB7B3826593205F851@SACMBXIP01.sdcorp.global.sandisk.com>, <40A0B8B92CE0F94685A03264958540C4F028B5@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> <23EC73C80FB59046A6B7B8EB7B3826593205F8B2@SACMBXIP01.sdcorp.global.sandisk.com> <40A0B8B92CE0F94685A03264958540C4F028C5@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> <23EC73C80FB59046A6B7B8EB7B3826593205FA13@SACMBXIP01.sdcorp.global.sandisk.com> <40A0B8B92CE0F94685A03264958540C4F02A08@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> Message-ID: <23EC73C80FB59046A6B7B8EB7B3826593205FA72@SACMBXIP01.sdcorp.global.sandisk.com> Thank you Alex. Dharani. From: Alex Chang [mailto:Alex.Chang at pmcs.com] Sent: Thursday, August 08, 2013 9:37 AM To: Dharani Kotte; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Dharani, Please find the attached SDStress.zip, which includes the required binaries and a batch file for your reference. Before running it, you need to create a volume and its drive letter is passed as first parameter to the batch file, for example: sdstress.bat E Please let me know if you have any questions. Thanks for your help. Alex From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Thursday, August 08, 2013 9:27 AM To: Alex Chang; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Alex, I will add the flag where ever necessary. Can you please send me the SDStress application that you are using so that I can perform this test as well. Thanks, Dharani. From: Alex Chang [mailto:Alex.Chang at pmcs.com] Sent: Wednesday, August 07, 2013 5:26 PM To: Dharani Kotte; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Dharani, When you said "it doesn't even enter into "if (pQI->NumSubIoQAllocated < QueueID){}" statement.", which is not true. And you're right that there will be one IO queue allocation attempt at least. Looks like whenever any given queue is shared by multiple cores, you need to set the flag to be ture. Thanks, Alex From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Wednesday, August 07, 2013 5:16 PM To: Alex Chang; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Alex. Comments in Green ... Thanks, Dharani. ________________________________ From: Alex Chang [Alex.Chang at pmcs.com] Sent: Wednesday, August 07, 2013 5:06 PM To: Dharani Kotte; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Dharani, Please see my comments in red... Thanks, Alex From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Wednesday, August 07, 2013 4:00 PM To: Alex Chang; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Alex, The situation was that when "pQI->NumSubIoQAllocFromAdapter" variable is set to 1 which means that the controller want only 1 IO queue. In this case it doesn't even enter into "if (pQI->NumSubIoQAllocated < QueueID){}" statement. If that's true, then there is no IO queue allocated at all, isn't it? 1 Queue is created but after that the Queue number will be forced to 1 and hence all the cores available are getting mapped to Queue 1. But we need to use StartLocks when ever 2 or more cores shares the same queue. The "fall back to use only one queue" case is covered only in the situation where the NVMeAllocQueues() fails for the Queue, This condition I didn't hit but you are right we may have to add this flag in that condition as well. drive formatting - If it is windows NTFS format I tested for Win8/Win7 32-bit. IOMeter - I tested for Win8/Win7 32-bit SDStress - I have not tested is it part of WHQL. Please test it if you have chance. I don't have a WHQL setup right now, Can you pass the SDStress exe if anything available with you. SCSI compliance - I have not tested since I didn't touch any part of the code that is related to SCSI Compliance but I can test it Thanks, Dharani. From: Alex Chang [mailto:Alex.Chang at pmcs.com] Sent: Wednesday, August 07, 2013 3:46 PM To: Dharani Kotte; nvmewin at lists.openfabrics.org Subject: RE: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Hi Dharani, Sorry to take such long time to get back to you and thank you for the effort. I just finished reviewing your changes and noticed you added a flag called "MultiplecoresToSingleQueueFlag". Does it mean there is only one IO queue being allocated and shared by all the cores? If yes, then the line you added (line#2828) in nvmeinit.c should be moved up to "fall back to use only one queue" case. Let me know what you think. By the way, have you tests it with drive formatting, IOMeter, SDStress and SCSI compliance yet? Thanks, Alex From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Dharani Kotte Sent: Wednesday, July 31, 2013 9:53 AM To: nvmewin at lists.openfabrics.org Subject: [nvmewin] ***UNCHECKED*** [WARNING - ENCRYPTED ATTACHMENT NOT VIRUSSCANNED] OFA NVMe Windows driver contribution - 32-bitsupport Win7/Win8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Date: %%SENT_DATE%% Subject: Suspect Message Quarantined WARNING: The virus scanner was unable to scan an attachment in an email message sent to you. This attachment could possibly contain viruses or other malicious programs. The attachment could not be scanned for the following reasons: %%DESC%% The full message and the attachment have been stored in the quarantine. The identifier for this message is '%%QID%%'. Access the quarantine at: https://puremessage.pmc-sierra.bc.ca:28443/ For more information on PMC's Anti-Spam system: http://pmc-intranet/wiki/index.php/Outlook:Anti-Spam_FAQ IT Services PureMessage Admin The attached is the code with 32-bit support tested on the Win7/Win8 32-bit systems. Please review it and let me know the comments. Password: sndk1234 Thanks, Dharani. From: Kwok Kong [mailto:Kwok.Kong at pmcs.com] Sent: Wednesday, July 31, 2013 9:29 AM To: Dharani Kotte Cc: Dave Landsman; Gurpreet Anand; Sumant Patro Subject: RE: [WARNING - ENCRYPTED ATTACHMENT NOT VIRUS SCANNED] OFA NVMe Windows driver contribution Dharani, This is great. Would you please email it out to the following mailing list asking for review and approval ? nvmewin at lists.openfabrics.org thanks -Kwok From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com] Sent: Wednesday, July 31, 2013 9:08 AM To: Kong, Kwok (Kwok.Kong at idt.com); Kwok Kong Cc: Dave Landsman; Gurpreet Anand; Sumant Patro Subject: [WARNING - ENCRYPTED ATTACHMENT NOT VIRUS SCANNED] OFA NVMe Windows driver contribution Hi Kwok, The attached is the code with 32-bit support tested on the Win7/Win8 32-bit systems. Can you please send it for review and let me know the comments. Password: sndk1234 Thanks, Dharani. -----Original Message----- From: Kong, Kwok [mailto:Kwok.Kong at idt.com] Sent: Wednesday, June 26, 2013 12:58 To: Dave Landsman Subject: OFA NVMe Windows driver contribution Dave, We are working on a NVMe Windows driver feature planning for the Dec 2013 release. Samsung cannot take on the task to get the driver to support windows 32-bit systems. I wonder if Sandisk can take on the task to get the driver to work in Windows 32-bit system. It is much appreciated if Sandisk can take this task on. Please let me know what you think. Thanks -Kwok ________________________________ PLEASE NOTE: The information contained in this electronic mail message is intended only for the use of the designated recipient(s) named above. If the reader of this message is not the intended recipient, you are hereby notified that you have received this message in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. If you have received this communication in error, please notify the sender by telephone or e-mail (as shown above) immediately and destroy any and all copies of this message in your possession (whether hard copies or electronically stored copies). -------------- next part -------------- An HTML attachment was scrubbed... URL: From Alex.Chang at pmcs.com Mon Aug 12 14:34:27 2013 From: Alex.Chang at pmcs.com (Alex Chang) Date: Mon, 12 Aug 2013 14:34:27 -0700 Subject: [nvmewin] Solution/Project Files Released Message-ID: <40A0B8B92CE0F94685A03264958540C4F572C5@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> Hi all, I had checked in the release 1.2 associated Visual Studio 2012 solution/project files for your references. You may find them under ~\releases\revision_1.2\nvme directory. In addition, I also updated ~\releases\revision_1.2\readme.txt accordingly and you may find more details from it. Please feel free to let me know if you have any questions. Thanks, Alex -------------- next part -------------- An HTML attachment was scrubbed... URL: From ram_sunee at yahoo.com Thu Aug 22 19:21:12 2013 From: ram_sunee at yahoo.com (Ramesh Mangamuri) Date: Thu, 22 Aug 2013 19:21:12 -0700 (PDT) Subject: [nvmewin] Release of the nvmewin driver In-Reply-To: <40A0B8B92CE0F94685A03264958540C4EB0438@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> References: <1375282091.54104.YahooMailNeo@web163904.mail.gq1.yahoo.com> <40A0B8B92CE0F94685A03264958540C4EB0438@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> Message-ID: <1377224472.81706.YahooMailNeo@web163905.mail.gq1.yahoo.com> Dear nvmewin, Can one of you please let me know what version of IOMETER you are using for testing the driver ?   Best Regards, Ramesh   ******************************************************************************************************************************************** This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the sender.If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited. *********************************************************************************************************************************************   ________________________________ From: Kwok Kong To: Ramesh Mangamuri ; nvmewin at lists.openfabrics.org Sent: Wednesday, July 31, 2013 8:16 AM Subject: RE: [nvmewin] Release of the nvmewin driver Ramesh,   A release is planned today or the latest this Friday. Announcement will be made to this mailing list after a release is made.   Thanks   -Kwok   From:nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Ramesh Mangamuri Sent: Wednesday, July 31, 2013 7:48 AM To: nvmewin at lists.openfabrics.org Subject: [nvmewin] Release of the nvmewin driver     Hello,   Can someone please confirm if there will be official release of nvmewin driver today, as planned in JUNE meeting ?. If so, when can I download the driver ?     Best Regards, Ramesh   ******************************************************************************************************************************************** This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the sender.If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited. ********************************************************************************************************************************************* -------------- next part -------------- An HTML attachment was scrubbed... URL: From Alex.Chang at pmcs.com Thu Aug 22 20:21:02 2013 From: Alex.Chang at pmcs.com (Alex Chang) Date: Thu, 22 Aug 2013 20:21:02 -0700 Subject: [nvmewin] Release of the nvmewin driver In-Reply-To: <1377224472.81706.YahooMailNeo@web163905.mail.gq1.yahoo.com> References: <1375282091.54104.YahooMailNeo@web163904.mail.gq1.yahoo.com><40A0B8B92CE0F94685A03264958540C4EB0438@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> <1377224472.81706.YahooMailNeo@web163905.mail.gq1.yahoo.com> Message-ID: <40A0B8B92CE0F94685A03264958540C40107E8B3@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> Hi Ramesh, I am using Iometer 2006.07.27. However you may download newer one like version 1.1.0, which comes with both 32 and 64 bit installers. Alex From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Ramesh Mangamuri Sent: Thursday, August 22, 2013 7:21 PM To: Kwok Kong; nvmewin at lists.openfabrics.org Subject: Re: [nvmewin] Release of the nvmewin driver Dear nvmewin, Can one of you please let me know what version of IOMETER you are using for testing the driver ? Best Regards, Ramesh ************************************************************************ ******************************************************************** This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the sender.If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited. ************************************************************************ ********************************************************************* ________________________________ From: Kwok Kong To: Ramesh Mangamuri ; nvmewin at lists.openfabrics.org Sent: Wednesday, July 31, 2013 8:16 AM Subject: RE: [nvmewin] Release of the nvmewin driver Ramesh, A release is planned today or the latest this Friday. Announcement will be made to this mailing list after a release is made. Thanks -Kwok From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Ramesh Mangamuri Sent: Wednesday, July 31, 2013 7:48 AM To: nvmewin at lists.openfabrics.org Subject: [nvmewin] Release of the nvmewin driver Hello, Can someone please confirm if there will be official release of nvmewin driver today, as planned in JUNE meeting ?. If so, when can I download the driver ? Best Regards, Ramesh ************************************************************************ ******************************************************************** This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the sender.If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited. ************************************************************************ ********************************************************************* -------------- next part -------------- An HTML attachment was scrubbed... URL: From anupshendkar at gmail.com Tue Aug 27 23:47:14 2013 From: anupshendkar at gmail.com (anup shendkar) Date: Wed, 28 Aug 2013 12:17:14 +0530 Subject: [nvmewin] Exercising nvme IOCTLS on windows Message-ID: Hi All, I want to experiment with Windows NVME ioctls. What is the best way to do that ? Does anybody have sample code/learning material ? I wanted to start with NVME ADMIN commands like identify, format, getlogpage etc. Regards, -- anup shendkar From Kwok.Kong at pmcs.com Wed Aug 28 08:48:54 2013 From: Kwok.Kong at pmcs.com (Kwok Kong) Date: Wed, 28 Aug 2013 08:48:54 -0700 Subject: [nvmewin] Exercising nvme IOCTLS on windows In-Reply-To: References: Message-ID: <40A0B8B92CE0F94685A03264958540C40107F32D@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> The file PT_IOCTL.doc at the following path http://www.openfabrics.org/svnrepo/nvmewin/trunk/docs/ documents the windows IOCTL pass thru. -Kwok -----Original Message----- From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of anup shendkar Sent: Tuesday, August 27, 2013 11:47 PM To: nvmewin at lists.openfabrics.org Subject: [nvmewin] Exercising nvme IOCTLS on windows Hi All, I want to experiment with Windows NVME ioctls. What is the best way to do that ? Does anybody have sample code/learning material ? I wanted to start with NVME ADMIN commands like identify, format, getlogpage etc. Regards, -- anup shendkar _______________________________________________ nvmewin mailing list nvmewin at lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/nvmewin From Alex.Chang at pmcs.com Wed Aug 28 08:51:50 2013 From: Alex.Chang at pmcs.com (Alex Chang) Date: Wed, 28 Aug 2013 08:51:50 -0700 Subject: [nvmewin] Exercising nvme IOCTLS on windows In-Reply-To: References: Message-ID: <40A0B8B92CE0F94685A03264958540C40107F330@bby1exm14.pmc_nt.nt.pmc-sierra.bc.ca> Hi Anup, If you have access to the source codes under ~\trunk\source, you should have a directory called docs under trunk, where you can find a document called PT_IOCTL.doc. You may start with the document and feel free to ask if you have any questions later. Thanks, Alex -----Original Message----- From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of anup shendkar Sent: Tuesday, August 27, 2013 11:47 PM To: nvmewin at lists.openfabrics.org Subject: [nvmewin] Exercising nvme IOCTLS on windows Hi All, I want to experiment with Windows NVME ioctls. What is the best way to do that ? Does anybody have sample code/learning material ? I wanted to start with NVME ADMIN commands like identify, format, getlogpage etc. Regards, -- anup shendkar _______________________________________________ nvmewin mailing list nvmewin at lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/nvmewin