[nvmewin] New Patch - Mode Select

[Chang, Alex]

Another typo, huh? I will fix it as well.

Thanks,
Alex

________________________________
From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com]
Sent: Friday, January 25, 2013 4:03 PM
To: Chang, Alex; nvmewin at lists.openfabrics.org
Subject: RE: New Patch - Mode Select

Hi Alex,

Can you please correct the print as well missing %x in the file nvmeInit.c and function NVMeInitCallback()

                case NVMeWaitOnLearnMapping:
            if ((pCplEntry->DW3.SF.SC == 0) &&
                (pCplEntry->DW3.SF.SCT == 0)) {
                PRES_MAPPING_TBL pRMT = &pAE->ResMapTbl;

                /*
                 * see if we still have more core/vector mapping to learn
                 * or if we're ready to redo the queues based on the new map
                 */
                pAE->DriverState.StateChkCount = 0;
                if (pAE->LearningCores < pRMT->NumActiveCores) {
                    pAE->DriverState.NextDriverState = NVMeWaitOnLearnMapping;
                } else {
#if DBG
                    PRES_MAPPING_TBL pRMT = &pAE->ResMapTbl;
                    PCORE_TBL pCT = NULL;
                    ULONG i;

                    /* print out the learned table */
                    StorPortDebugPrint(INFO, "Learning Complete.  Core Table:\n");
                    for (i=0; i < pRMT->NumActiveCores; i++) {
                        pCT = pRMT->pCoreTbl + i;
                        StorPortDebugPrint(INFO,
                                           "\tCore(0x%x) MSID(0x%x) QueuePair(0x%x)\n",
                                           pCT->CoreNum,
                                           pCT->MsiMsgID,
                                           pCT->SubQueue);

                    }

                    pAE->LearningComplete = TRUE;
#endif
                    pAE->DriverState.NextDriverState = NVMeWaitOnReSetupQueues;
                }
            } else {
                PRES_MAPPING_TBL pRMT = &pAE->ResMapTbl;

                /* possibly no NS exists at all, either way this isn't fatal */
                StorPortDebugPrint(INFO,
                    "NVMeInitCallback: WARNING: no learning possible, SC 0x%x SCT 0x%x\n", // BUG
                     pCplEntry->DW3.SF.SC, pCplEntry->DW3.SF.SCT);
                pAE->LearningCores = pRMT->NumActiveCores;
                pAE->DriverState.NextDriverState = NVMeStartComplete;
            }
        break;

thanks,
Dharani.


From: Chang, Alex [mailto:Alex.Chang at idt.com]
Sent: Friday, January 25, 2013 3:57 PM
To: Dharani Kotte; nvmewin at lists.openfabrics.org
Subject: RE: New Patch - Mode Select

Good catch, Dharani.

Hi Ray,

Is this just a typo?

Thanks,
Alex
________________________________
From: Dharani Kotte [mailto:Dharani.Kotte at sandisk.com]
Sent: Friday, January 25, 2013 3:46 PM
To: Chang, Alex; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: New Patch - Mode Select
    Hi Alex,

In the file nvmeSnti.c and function SntiTranslateModeData()

/* Mode Select 10 */
        pModeHeader10 = (PMODE_PARAMETER_HEADER10)(GET_DATA_BUFFER(pSrb));

#pragma prefast(suppress:6011,"This pointer is not NULL")
        blockDescLength = pModeHeader6->BlockDescriptorLength;  // BUG -  pModeHeader6 is not initialized probably it should be pModeHeader10

thanks,
Dharani.

From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Chang, Alex
Sent: Friday, January 25, 2013 3:27 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [WARNING - ENCRYPTED ATTACHMENT NOT VIRUS SCANNED] [nvmewin] ***UNCHECKED*** New Patch - Mode Select

Hi all,

I am adding a patch to fix a bug related to Mode Select command when users enable/disable Volatile Write Cache. The changes I made are within SntiTranslateModeData routine of nvmeSnti.c to correctly locate the page code and program Dword 11 of NVMe submission entry before issuing Set Features command. The password is idt123. Please review it and provide feedbacks in next couple weeks.

Thanks,
Alex

________________________________

PLEASE NOTE: The information contained in this electronic mail message is intended only for the use of the designated recipient(s) named above. If the reader of this message is not the intended recipient, you are hereby notified that you have received this message in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. If you have received this communication in error, please notify the sender by telephone or e-mail (as shown above) immediately and destroy any and all copies of this message in your possession (whether hard copies or electronically stored copies).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20130126/c22171c0/attachment.html>