[nvmewin] LSI Trim Patch

Mon Jun 24 08:11:33 PDT 2013

Thanks a lot, Kris.
I will do more testing today and then push the patch today after the tests.

Thanks,
Alex 

-----Original Message-----
From: Murray, Kris R [mailto:kris.r.murray at intel.com] 
Sent: Monday, June 24, 2013 8:02 AM
To: Chang, Alex; Knoblaugh, Rick; Kong, Kwok; Robles, Raymond C; nvmewin at lists.openfabrics.org
Cc: Sheth, Parag A
Subject: RE: LSI Trim Patch

Rick,
Changes look good to me.
~Kris

-----Original Message-----
From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Chang, Alex
Sent: Thursday, June 20, 2013 4:50 PM
To: Knoblaugh, Rick; Kong, Kwok; Robles, Raymond C; nvmewin at lists.openfabrics.org
Cc: Sheth, Parag A
Subject: Re: [nvmewin] LSI Trim Patch

Thank you, Rick.
I will re-run the tests and let you know later.

Hi Kris,
Could you please provide your feedbacks at your earliest convenience?

Thanks,
Alex

-----Original Message-----
From: Knoblaugh, Rick [mailto:Rick.Knoblaugh at lsi.com]
Sent: Thursday, June 20, 2013 3:07 PM
To: Chang, Alex; Kong, Kwok; Robles, Raymond C; nvmewin at lists.openfabrics.org
Cc: Sheth, Parag A
Subject: LSI Trim Patch

Hi Alex,

             I was hoping to send this earlier, but we had to deal with some logistical stuff getting into our new building. Here is the patch with the minor tweaks we discussed. Even though there is basically no change, we reran tests and such. 

             There were only two changes:

             In nvmesnti.c, in the SntiTranslateBlockLimitsPage fuction, we are being consistent with what Microsoft's AHCI Storport miniport driver does and only explicitly providing values for Maximum UNMAP LBA Count and Maximum UNMAP Block Descriptor Count.  

             Changed conditional compile for Win 8 to use #if _WIN32_WINNT > _WIN32_WINNT_WIN7. (And removed #define WINDOWS_8 from nvmestd.h.)

             Password is lsi1234

        Thanks,

                        -Rick

-----Original Message-----
From: Chang, Alex [mailto:Alex.Chang at idt.com]
Sent: Monday, June 17, 2013 10:30 AM
To: Knoblaugh, Rick; Kong, Kwok; Robles, Raymond C; nvmewin at lists.openfabrics.org
Cc: Sheth, Parag A
Subject: RE: LSI Trim Patch

Hi Rick,

I see your point. We can release one binary for all supported OS flavors only if it works for all of them. We can discuss more in the meeting today in this regard.

Thanks,
Alex

-----Original Message-----
From: Knoblaugh, Rick [mailto:Rick.Knoblaugh at lsi.com]
Sent: Monday, June 17, 2013 9:57 AM
To: Chang, Alex; Kong, Kwok; Robles, Raymond C; nvmewin at lists.openfabrics.org
Cc: Sheth, Parag A
Subject: RE: LSI Trim Patch

Hi Alex,
                 My original thought in conditionally compiling was to preserve compatibility with the existing Win 7 WDK. Driver builds as it always has in that environment. Seems like a convenience for anyone who still wants to build using Win 7  WDK (perhaps they already have some automated builds in place or whatever, so why break it?) And, it exposes the same VPD pages as before, whereas there will be 3 new ones with Win 8 Trim support -- not saying that breaks anything in Win 7 or Win 2008 R2, but we do have proven mileage behind us with things as they are.

                 If the goal is to have a single binary that runs across all of those OS flavors, you may want to put that validation down as a project for someone. I think Parag had tried building the driver as it exists today in the repository for Windows 8 and saw some issues when trying to install that binary under Windows 7. Perhaps if other folks have tried that, they can weigh in on this as well.

          Thanks,
                             -Rick

________________________________________
From: Chang, Alex [Alex.Chang at idt.com]
Sent: Monday, June 17, 2013 9:15 AM
To: Kong, Kwok; Knoblaugh, Rick; Robles, Raymond C; nvmewin at lists.openfabrics.org
Cc: Sheth, Parag A
Subject: RE: LSI Trim Patch

Hi Rick,

Kwok has a good point, especially that we're going to release signed binary later. Please add the changes you mentioned below and re-send your patch after running the basic tests (drive formats, SDStress, SCSICompliance and IOMeter) and TRIM specific tests.

Thank you,
Alex

________________________________
From: Kong, Kwok
Sent: Monday, June 17, 2013 8:39 AM
To: Knoblaugh, Rick; Chang, Alex; Robles, Raymond C; nvmewin at lists.openfabrics.org
Cc: Sheth, Parag A
Subject: RE: LSI Trim Patch

Rick,

Is it possible to run the Windows 8 binary driver with Windows 7, Windows server 2008R2 and Windows server 2012 ?
If it works, then there is no need to have conditional compile .  We can require Windows 8 WDK to compile the source code such that we only need to build a single binary file for Windows 7, 8,  Server 2008R2 and Server 2012.

Thanks

-Kwok

From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Knoblaugh, Rick
Sent: Saturday, June 15, 2013 8:48 PM
To: Chang, Alex; Robles, Raymond C; nvmewin at lists.openfabrics.org
Cc: Sheth, Parag A
Subject: Re: [nvmewin] LSI Trim Patch

Hi Alex,
                    We can make that tweak to change how it checks for Windows 8.

                    Also, I discovered one other item that hasn't affected TRIM, but is not actually correct. In the SntiTranslateBLockLimitsPage function that implements the Block Limits VPD page, two items weren't being returned correctly.  pBLPage->MaximumCompareAndWriteLength and pBLPage->MaximumTransferLength were being assigned the value of  pCntrlIdData->MDTS -- and what needs to be returned there is not this field, but a calculation based on this field and PAE->pCtrlRegister->CAP.MPSMIN.

                    And actually, we have the ability to scale that maximum transfer value back based on a registry setting, so rather than doing that calculation, what should probably be returned there is pAE->InitInfo.MaxTxSize.

                    Another issue with what was being done is that the value for these fields within the BLock Limits VPD Page needs to be in blocks, so for both of those, we should be returning  pAE->InitInfo.MaxTxSize / block size.

                    We can put in those fixes. (Again, these weren't affecting the UNMAP stuff, but should be corrected.)

             Thanks,

                                     -Rick

________________________________
From: Chang, Alex [Alex.Chang at idt.com]
Sent: Tuesday, June 11, 2013 3:48 PM
To: Knoblaugh, Rick; Robles, Raymond C; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: LSI Trim Patch
Hi Rick,

Just a quick note that you don't need to define WINDOWS_8 yourself. In a more WDK way, you may just wrap your changes with:
#if (_WIN32_WINNT > _WIN32_WINNT_WIN7)
#endif
Then, it will be compiled without error on both Windows 8 WDK and 7600 WDK.

Thanks,
Alex

________________________________
From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Knoblaugh, Rick
Sent: Friday, June 07, 2013 6:38 PM
To: Robles, Raymond C; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] ***UNCHECKED*** LSI Trim Patch Hi Ray,
               Per your request, since we will switch order, moving Intel patch to the number 3 position, I'm sending LSI's Trim patch.
Password for the attached file is: lsi1234. Also, I have attached a document here that describes what was changed/added.

              It would be great if everyone can review and please let me know any feedback.

Thanks.

       -Rick

From: Robles, Raymond C [mailto:raymond.c.robles at intel.com]
Sent: Monday, June 03, 2013 5:12 PM
To: Knoblaugh, Rick; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: Sandisk patch delay

Hi Rick,

That's great news! LSI will be 3rd in line after IDT and Intel.  Thanks for the contributions to TRIM.

Thanks,
Ray

From: Knoblaugh, Rick [mailto:Rick.Knoblaugh at lsi.com]
Sent: Monday, June 03, 2013 4:57 PM
To: Robles, Raymond C; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: Sandisk patch delay

Hi Ray,
                    We also have the patch for Trim. It is ready to send. Please let me know when you would like me to send out.

Thanks,
                 -Rick

From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Robles, Raymond C
Sent: Monday, June 03, 2013 4:44 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] Sandisk patch delay

Hello,

It appears the Sandisk patch for Mode Sense is taking longer than expected. In order to keep things moving along with the OFA driver, I'm going to take the Sandisk patch offline for now until they can resolve their issues.  Once they have worked out the kinks, they can re-submit. In the meantime, Alex from IDT has a patch he'd like to push and I also have a patch I'd like to push.

Alex, please send your patch out for code review as soon as possible and then I will send out my patch immediately after.

Thanks,
Ray

[cid:695370816 at 17062013-1A83]
Raymond C. Robles
NVM Solutions Group | Internal SSD Engineering Technology & Manufacturing Group Intel Corporation
Desk: 480.554.2600
Mobile: 480.399.0645

_______________________________________________
nvmewin mailing list
nvmewin at lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/nvmewin