[nvmewin] Intel Byte Enable Patch

[Murray, Kris R]

Are you sure? When we looked at the definition in storport.h (and wdm.h) it doesn't appear to be wrapped in any OS version compile switches. Also, I tested it on Windows 7 in QEMU and it ran without error. I verified in WinDbg that correct values were read using this function.

From: Chang, Alex [mailto:Alex.Chang at idt.com]
Sent: Thursday, June 27, 2013 1:44 PM
To: Murray, Kris R; nvmewin at lists.openfabrics.org
Subject: RE: Intel Byte Enable Patch

Sounds good to me. However, the API is only available on Windows 8. You might want add:
#if _WIN32_WINNT > _WIN32_WINNT_WIN7

Thanks,
Alex

________________________________
From: Murray, Kris R [mailto:kris.r.murray at intel.com]
Sent: Thursday, June 27, 2013 1:32 PM
To: Chang, Alex; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: Intel Byte Enable Patch
Correct, Ray was going to use an array for the doorbell registers but it turns out that didn't need to happen. I saw that after I submitted, but decided to wait till the rebase to remove it from the patch.

Another change I plan to make is adding a compile option for _WIN64 that will use the StorPortReadUlong64(...) function instead of 2x 32-bit reads.

Thanks,
~Kris

From: Chang, Alex [mailto:Alex.Chang at idt.com]
Sent: Thursday, June 27, 2013 1:25 PM
To: Murray, Kris R; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: Intel Byte Enable Patch

Hi Kris,

After reviewing your patch, I notice that, variable "IODB" (Line# 900 and 1013 in nvmeinit.c) is declared/initialized, but never gets used. I think you meant to read back the initial value of doorbell pointer with it?

Thanks,
Alex

________________________________
From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Murray, Kris R
Sent: Wednesday, June 12, 2013 4:45 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] ***UNCHECKED*** Intel Byte Enable Patch
All,

Attached is the patch to fix issues where accessing memory mapped controller register fields directly would generate single byte accesses across the PCIe bus by calling the StorPort functions to read those registers. The 4 places this is done are NVMeFindAdapter, NVMeInitCplQueue, NVMeSubQueue, and NVMeInitCallback.

Password: intel1234

Testing done using IOMeter and SCSI Compliance with logs attached.

Please review and provide feedback in the next couple weeks. Upon acceptance I'll rebase after the other patches make it through.

Thanks,
Kris

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20130627/9b31d4ed/attachment.html>