[nvmewin] Re-submit of Changes for Visual Studio 2013/WDK 8.1 - Ready for Review

[Alex Chang]

Hi Tom,

I do notice you configured the warning level as W4 and treating warning as no error, which is the same as current configuration in VS 2012. I had fixed the issues when changing it to W3 and treating warning as error and the fixes will be included in my patch. For the time being, we will just leave it as it is for your patch. What do you think?

Thanks,
Alex

From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Freyensee, James P
Sent: Monday, August 11, 2014 3:55 PM
To: Thomas Freeman; Foster, Carolyn D; nvmewin at lists.openfabrics.org
Subject: Re: [nvmewin] Re-submit of Changes for Visual Studio 2013/WDK 8.1 - Ready for Review

I was curious to know what are the recommended warning level compile flags for this project for use with WDK8.1.

It looks like this .sln uses /W1 and /WX- flags for every configuration from Win7 to Win8.1, correct (though I am using VS2012 to read the .sln)?

Up until about March 2014, I was able to compile the nvme code cleanly using /W3 and /WX, targeting both Win7 and Win8 with WDK8.  And I believe the code that was causing issues using those flags got recently fixed.

If the code has been compiling at a /W3, what was the issue that motivated the flag change?



From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Thomas Freeman
Sent: Thursday, August 07, 2014 2:29 PM
To: Foster, Carolyn D; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] Re-submit of Changes for Visual Studio 2013/WDK 8.1 - Ready for Review

I've attached my new file with the changes to fix the issues brought up by Carolyn (W7 and W8 Debug/x32 going to the wrong folder).
I won't be addressing Carolyn's first request to re-structure the directories.
The password for the attached file is "hgst1234"


Tom Freeman
Thomas.Freeman at hgst.com<mailto:Thomas.Freeman at hgst.com>
507-322-2311

From: Foster, Carolyn D [mailto:carolyn.d.foster at intel.com]
Sent: Tuesday, August 5, 2014 12:04 PM
To: Thomas Freeman; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: Changes for Visual Studio 2013/WDK 8.1 - Ready for Review

Hi Tom, I found a few minor issues with the patch.

One thing I noticed is that 64 bit builds go to a x64 folder, with sub directories for OS versions, but 32 bit builds don't have a similar Win32 folder.  This isn't a new issue, so if it's not something you want to fix that's fine with me.

I also noticed that the NVMe Package is pointing to the wrong folder during the last build step for two of the configurations.
The Win 7 Debug 32 bit is pointing to the Win 7 Release folder
The Win 8.1 Debug 32-bit is pointing to the Win 8.1 Release folder

Otherwise I was able to build all of the configurations without any issues.

Thanks,
Carolyn

From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Thomas Freeman
Sent: Saturday, July 26, 2014 12:34 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] Changes for Visual Studio 2013/WDK 8.1 - Ready for Review

I've attached the driver changes for updating the driver to run on Visual Studio 2013/WDK 8.1
Please review and respond with comments by August 4. The password for the attachment is "hgst1234"

By opening the driver solution under with Visual Studio 2013/WDK 8.1, the following files were updated:
nvme.vcxproj, nvme.vcxproj.filters, nvme.vcxproj.user
nvmePackage.vcxproj, nvmePackage.vcxproj.filters, nvmePackage.vcxproj.user

In the attachment, the file VS2013WDK81.patch details the changes made to each file.

Using a mixture of real hardware and QEMU, we ran the following tests on Windows 7, 8 and 8.1 (x64 only):
Quick & slow formatting - MBR and GPT, sdstress and IOMETER
There were errors running scsi compliance - those results are documented in the attached zip file.
These errors existed prior to these changes. Alex is aware of these errors and working to address them.


Tom Freeman
Thomas.Freeman at hgst.com<mailto:Thomas.Freeman at hgst.com>
507-322-2311

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20140811/51c9dc67/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 1117 bytes
Desc: image001.gif
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20140811/51c9dc67/attachment.gif>