[nvmewin] Re-submit of Changes for Visual Studio 2013/WDK 8.1 - Ready for Review

[Alex Chang]

Hi Tom,

Thank you for the details. I will include them when releasing 1.4.

Regards,
Alex

From: Thomas Freeman [mailto:thomas.freeman at hgst.com]
Sent: Tuesday, August 12, 2014 8:34 AM
To: Alex Chang; Foster, Carolyn D; nvmewin at lists.openfabrics.org
Subject: RE: [nvmewin] Re-submit of Changes for Visual Studio 2013/WDK 8.1 - Ready for Review

Hi Alex,
It's been a while since I converted to VS2013, but if I recall it was a pretty simple transition

I downloaded and installed VS2013 and WDK 8.1 update from the MSDN website (installing VS2013 first)
Using Visual Studio 2013, I opened the VS2012 version of the solution. At that point Visual Studio prompted me to allow the conversion of my project files to VS2013.
The solution/project files I've shipped are already converted to VS2013 - so the user needs to just click on the nvme.sln, select the appropriate configuration (e.g. Win7 Release) and build.

Here is a link to some more detailed info on the Upgrade of C++ Project files http://msdn.microsoft.com/en-us/library/hh690665.aspx

Tom Freeman
Thomas.Freeman at hgst.com<mailto:Thomas.Freeman at hgst.com>
507-322-2311

From: Alex Chang [mailto:Alex.Chang at pmcs.com]
Sent: Friday, August 8, 2014 5:28 PM
To: Thomas Freeman; Foster, Carolyn D; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: [nvmewin] Re-submit of Changes for Visual Studio 2013/WDK 8.1 - Ready for Review

Hi Tom,

Thank you for the fixes. Do you think it'd be possible for you to write up how you set up VS2013, etc., Users then just click the solution file and they can build the binaries without any problems?

Thanks,
Alex

From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Thomas Freeman
Sent: Thursday, August 07, 2014 2:29 PM
To: Foster, Carolyn D; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] Re-submit of Changes for Visual Studio 2013/WDK 8.1 - Ready for Review


Content-Type: text/plain; charset=UTF-8

Content-Transfer-Encoding: 8bit

Date: %%SENT_DATE%%

Subject: Suspect Message Quarantined







WARNING: The virus scanner was unable to scan an attachment in an email message sent to you.  This attachment could possibly contain viruses or other malicious programs.  The attachment could not be scanned for the following reasons:



%%DESC%%



The full message and the attachment have been stored in the quarantine.



The identifier for this message is '%%QID%%'.



Access the quarantine at:

https://puremessage.pmc-sierra.bc.ca:28443/



For more information on PMC's Anti-Spam system:

http://pmc-intranet/wiki/index.php/Outlook:Anti-Spam_FAQ



IT Services

PureMessage Admin


I've attached my new file with the changes to fix the issues brought up by Carolyn (W7 and W8 Debug/x32 going to the wrong folder).
I won't be addressing Carolyn's first request to re-structure the directories.
The password for the attached file is "hgst1234"


Tom Freeman
Thomas.Freeman at hgst.com<mailto:Thomas.Freeman at hgst.com>
507-322-2311

From: Foster, Carolyn D [mailto:carolyn.d.foster at intel.com]
Sent: Tuesday, August 5, 2014 12:04 PM
To: Thomas Freeman; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: Changes for Visual Studio 2013/WDK 8.1 - Ready for Review

Hi Tom, I found a few minor issues with the patch.

One thing I noticed is that 64 bit builds go to a x64 folder, with sub directories for OS versions, but 32 bit builds don't have a similar Win32 folder.  This isn't a new issue, so if it's not something you want to fix that's fine with me.

I also noticed that the NVMe Package is pointing to the wrong folder during the last build step for two of the configurations.
The Win 7 Debug 32 bit is pointing to the Win 7 Release folder
The Win 8.1 Debug 32-bit is pointing to the Win 8.1 Release folder

Otherwise I was able to build all of the configurations without any issues.

Thanks,
Carolyn

From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Thomas Freeman
Sent: Saturday, July 26, 2014 12:34 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] Changes for Visual Studio 2013/WDK 8.1 - Ready for Review

I've attached the driver changes for updating the driver to run on Visual Studio 2013/WDK 8.1
Please review and respond with comments by August 4. The password for the attachment is "hgst1234"

By opening the driver solution under with Visual Studio 2013/WDK 8.1, the following files were updated:
nvme.vcxproj, nvme.vcxproj.filters, nvme.vcxproj.user
nvmePackage.vcxproj, nvmePackage.vcxproj.filters, nvmePackage.vcxproj.user

In the attachment, the file VS2013WDK81.patch details the changes made to each file.

Using a mixture of real hardware and QEMU, we ran the following tests on Windows 7, 8 and 8.1 (x64 only):
Quick & slow formatting - MBR and GPT, sdstress and IOMETER
There were errors running scsi compliance - those results are documented in the attached zip file.
These errors existed prior to these changes. Alex is aware of these errors and working to address them.


Tom Freeman
Thomas.Freeman at hgst.com<mailto:Thomas.Freeman at hgst.com>
507-322-2311

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20140812/c49c8a4f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.gif
Type: image/gif
Size: 1117 bytes
Desc: image002.gif
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20140812/c49c8a4f/attachment.gif>