[nvmewin] IOCTL_SCSI_MINIPORT_IDENTIFY -> NVMeBuildIdentify()

[Alex Chang]

Thank you very much, Mike, for pointing it out. The codes was added by Paul Luse from Intel.

Hi Paul,

Could you please answer Mike's questions?

Thanks,
Alex

From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Mike Berhan
Sent: Wednesday, August 13, 2014 9:40 AM
To: nvmewin at lists.openfabrics.org
Subject: [nvmewin] IOCTL_SCSI_MINIPORT_IDENTIFY -> NVMeBuildIdentify()

The driver's attempt to map NVMe data to an ATA Identify structure is incorrect in the NVMeBuildIdentify() routine.  I see multiple issues including:


1.       The driver is copying an NVMe ASCII string into an ATA String without doing the required byte swapping

2.       The Checksum Validity Indicator (i.e. Word 255 - Bits 7:0) is not being set to A5h

3.       The Checksum (i.e. Word 255 - Bits 15:8) is not being set to the two's complement of the sum of the previous bytes

I have attached the required source code changes, as well as a DIFF file, that corrects these issues if you want to incorporate them into the 1.4 driver.

Why is the miniport driver processing these SCSIDISK IOCTLs?  What issue does it solve?  Microsoft's NVMe driver does not appear to process these requests.

Mike Berhan
busTRACE Technologies

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20140813/37100e58/attachment.html>