[nvmewin] PMC Patch For SCSI Compliance Fixes And Others

[Alex Chang]

Hi Parag,

After re-testing it, you were right about the failure that my changes had introduced. I have corrected it. Sorry about the confusion.

Thanks,
Alex

From: Parag Sheth [mailto:parag.sheth at avagotech.com]
Sent: Monday, August 25, 2014 4:54 PM
To: Alex Chang; nvmewin at lists.openfabrics.org
Subject: RE: [nvmewin] PMC Patch For SCSI Compliance Fixes And Others

Hi Alex,

I am using “HCK for win 8.1”. The version number displayed is 8.100.26063.
I am testing it out on windows 8 64bit target machine.

Thanks
Parag Sheth

From: Alex Chang [mailto:Alex.Chang at pmcs.com<mailto:Alex.Chang at pmcs.com>]
Sent: Monday, August 25, 2014 4:50 PM
To: Parag Sheth; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: [nvmewin] PMC Patch For SCSI Compliance Fixes And Others

Thank you Parag.
What version of the SCSI Compliance Test utility you use? What OS you were running the tests on?

Alex

From: Parag Sheth [mailto:parag.sheth at avagotech.com]
Sent: Monday, August 25, 2014 2:57 PM
To: Alex Chang; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: [nvmewin] PMC Patch For SCSI Compliance Fixes And Others

Hi Alex,

I did review the changes and they seem ok except

A new error is introduced in SCSI Compliance Test. (Test 1.21 Checking Identification Descriptors in VPD page 0x83 fails). It complains that it did not find identifier of type 3, 2 and 1.

Thanks
Parag Sheth
From: Alex Chang [mailto:Alex.Chang at pmcs.com<mailto:Alex.Chang at pmcs.com>]
Sent: Tuesday, August 19, 2014 4:10 PM
To: Parag Sheth; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: [nvmewin] PMC Patch For SCSI Compliance Fixes And Others

Hi Parag,

We had pushed a patch from Carolyn (Intel) after revision 1.3. I believe that are the changes you saw in nvmeinit.c.

Alex

From: Parag Sheth [mailto:parag.sheth at avagotech.com]
Sent: Tuesday, August 19, 2014 4:00 PM
To: Alex Chang; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: [nvmewin] PMC Patch For SCSI Compliance Fixes And Others

Hi Alex,

I noticed some changes in nvmeInit.c which are not related to the fixes you mentioned in the email below. I am comparing the patch against revision 1.3 source code.

Thanks
Parag Sheth

From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org>] On Behalf Of Alex Chang
Sent: Friday, August 15, 2014 5:56 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] PMC Patch For SCSI Compliance Fixes And Others

Hi all,

I am sending out this patch for your review/test. The password is pmc123. Please provide your feedback as soon as possible and I will start to collect approvals on August 27.
This patch contains the following changes:
1. Fixed compiling errors when configured as /W3 and /WX. (nvmestd.c, nvmesnti.c)
2. Fixed to use Windows 8/SRB Extension defined Storage Request Block for Windows 8 and up. (nvmestd.c)
3. Fixed the following SCSI Compliance test failures: (nvmesnti.c)
- Supporting Log Sense command.
- Log Sense (Temperature Page)
- Log Sense (Informational Exceptional Page)
- Inquiry (Standard Page)
- Inquiry (Device ID Page)
- Inquiry (Unit Serial Page)
- Read Capacity 16 (Need to take care of null CDB buffer)
- Unmap (Anchor bit is not supported)
4. Fixed Get Log Page building, it needs to be 0's based number of DWORDs specified in DWORD 10 (nvmesnti.c).
5. Fixed a Report LUN bug that reports a zero-sized namespace when Namespace IDs are not contiguous (nvmesnti.c).
6. Fixed Flush command related bug that requires correct Namespace ID specified (nvmesnti.c).
7. Fixed system crash on Windows 8 and up when accessing CDB buffer in IO_StorPortNotification (nvmestd.c).

Unit Tests:
Tested the following on Windows 7, Server 2008, 8 and Server 2012:

-          Ran SCSI compliance tests

-          Ran SDStress

-          Ran IOmeter

-          Disk format (quick and slow) as MBR and GPT drive

-          Install/Uninstall, Enable/Disable driver
In addition, I also ran the NVMe SCSI Compliance Test using HCK 8.100.26795 on Windows 8.1 without any errors (see the attached results).

Thank you and have a great weekend!
Alex


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20140826/fd692608/attachment.html>