[nvmewin] PMC Patch For SCSI Compliance Fixes And Others

[Parag Sheth]

Hi Alex,



Your changes look good. We approve the patch.



Thanks

Parag Sheth



*From:* nvmewin-bounces at lists.openfabrics.org [mailto:
nvmewin-bounces at lists.openfabrics.org] *On Behalf Of *Alex Chang
*Sent:* Tuesday, August 26, 2014 9:59 AM
*To:* Alex Chang; nvmewin at lists.openfabrics.org
*Subject:* Re: [nvmewin] PMC Patch For SCSI Compliance Fixes And Others



Hi all,



Thank you for your feedback, Carolyn and Parag. I plan to push this patch
by Friday and please provide your approval when available.

I had revised the patch based on the feedback:

1.       Restored original Device ID page translation for Inquiry command
via EUI-64 type.

2.       Fixed NSID programming for Get Log Page command to be compliant
with NVMe definition.

3.       Revised some comments in source codes.

Unit Tests:

Tested the following on Windows 7, Server 2008, 8 and Server 2012:

-          Ran NVMe SCSI compliance tests on Windows 8.1 (results attached)

-          Ran SDStress

-          Ran IOmeter

-          Disk format (quick and slow) as MBR and GPT drive

-          Install/Uninstall, Enable/Disable driver

Finally, password is pmc123. Please provide your feedback as soon as
possible.



Thank you!

Alex





*From:* nvmewin-bounces at lists.openfabrics.org [
mailto:nvmewin-bounces at lists.openfabrics.org
<nvmewin-bounces at lists.openfabrics.org>] *On Behalf Of *Alex Chang
*Sent:* Friday, August 15, 2014 5:56 PM
*To:* nvmewin at lists.openfabrics.org
*Subject:* [nvmewin] PMC Patch For SCSI Compliance Fixes And Others



Content-Type: text/plain; charset=UTF-8

Content-Transfer-Encoding: 8bit

Date: %%SENT_DATE%%

Subject: Suspect Message Quarantined







WARNING: The virus scanner was unable to scan an attachment in an
email message sent to you.  This attachment could possibly contain
viruses or other malicious programs.  The attachment could not be
scanned for the following reasons:



%%DESC%%



The full message and the attachment have been stored in the quarantine.



The identifier for this message is '%%QID%%'.



Access the quarantine at:

https://puremessage.pmc-sierra.bc.ca:28443/



For more information on PMC's Anti-Spam system:

http://pmc-intranet/wiki/index.php/Outlook:Anti-Spam_FAQ



IT Services

PureMessage Admin



Hi all,



I am sending out this patch for your review/test. The password is pmc123.
Please provide your feedback as soon as possible and I will start to
collect approvals on August 27.

This patch contains the following changes:

1. Fixed compiling errors when configured as /W3 and /WX. (nvmestd.c,
nvmesnti.c)

2. Fixed to use Windows 8/SRB Extension defined Storage Request Block for
Windows 8 and up. (nvmestd.c)

3. Fixed the following SCSI Compliance test failures: (nvmesnti.c)

- Supporting Log Sense command.

- Log Sense (Temperature Page)

- Log Sense (Informational Exceptional Page)

- Inquiry (Standard Page)

- Inquiry (Device ID Page)

- Inquiry (Unit Serial Page)

- Read Capacity 16 (Need to take care of null CDB buffer)

- Unmap (Anchor bit is not supported)

4. Fixed Get Log Page building, it needs to be 0's based number of DWORDs
specified in DWORD 10 (nvmesnti.c).

5. Fixed a Report LUN bug that reports a zero-sized namespace when
Namespace IDs are not contiguous (nvmesnti.c).

6. Fixed Flush command related bug that requires correct Namespace ID
specified (nvmesnti.c).

7. Fixed system crash on Windows 8 and up when accessing CDB buffer in
IO_StorPortNotification (nvmestd.c).



Unit Tests:

Tested the following on Windows 7, Server 2008, 8 and Server 2012:

-          Ran SCSI compliance tests

-          Ran SDStress

-          Ran IOmeter

-          Disk format (quick and slow) as MBR and GPT drive

-          Install/Uninstall, Enable/Disable driver

In addition, I also ran the NVMe SCSI Compliance Test using HCK 8.100.26795
on Windows 8.1 without any errors (see the attached results).



Thank you and have a great weekend!

Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20140828/cc6efa70/attachment.html>