[nvmewin] LBA Range Type Patch

[Freyensee, James P]

1.       line 1407: Couldn't Invalid Command Opcode also be a reasonable status code for "Get/Set Features- LBA Range Type" being optional?  It does look like "INVALID_FIELD_IN_COMMAND" should be the more exact return type, but I was thinking  "Invalid command opcode" could be an acceptable error status code type as well?  My reasoning is that since LBA Range Type is an optional command in the NVMe spec, the driver should not be too strict on what error status codes it receives that will make it an optional command.  In fact, maybe the code should only be checking for "successful completion", and any error makes LBA Range Type optional (and the driver will not fail)



2.       Will the driver ever attempt a re-try on "Get/Set Features- LBA Range Type" if it gets an error?  It does not look like the case, but if there is a chance it does, maybe it should check the "do not retry" bit in case HW sets it?  If this bit is set, then it's pretty certain the HW does not support it.  But if it is not set, maybe the driver needs to try "Get/Set Features- LBA Range Type" again before it makes it an optional command?



Thanks
Jay


From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Alex Chang
Sent: Wednesday, January 29, 2014 2:49 PM
To: Foster, Carolyn D; nvmewin at lists.openfabrics.org
Subject: Re: [nvmewin] LBA Range Type Patch

Thank you very much, Carolyn.

Hi all,

Please review/test the patch and provide your feedback(s) as soon as possible.

Thanks,
Alex

From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Foster, Carolyn D
Sent: Wednesday, January 29, 2014 2:45 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] ***UNCHECKED*** LBA Range Type Patch


Content-Type: text/plain; charset=UTF-8

Content-Transfer-Encoding: 8bit

Date: %%SENT_DATE%%

Subject: Suspect Message Quarantined







WARNING: The virus scanner was unable to scan an attachment in an email message sent to you.  This attachment could possibly contain viruses or other malicious programs.  The attachment could not be scanned for the following reasons:



%%DESC%%



The full message and the attachment have been stored in the quarantine.



The identifier for this message is '%%QID%%'.



Access the quarantine at:

https://puremessage.pmc-sierra.bc.ca:28443/



For more information on PMC's Anti-Spam system:

http://pmc-intranet/wiki/index.php/Outlook:Anti-Spam_FAQ



IT Services

PureMessage Admin


Overview:
The LBA Range Type feature is defined as optional in the spec, but the driver currently fails to complete enumeration if the Get Features request for LBA Range Type fails.  Based on the serious nature of the failure, this could be a problem at the upcoming plugfest.  There will likely be devices at plugfest that do not support LBA Range Type, thus causing the OFA driver to not load on these devices.

Files Modified:
In nvmeInit.c, NVMeSetFeaturesCompletion(), the LBA Range Type Get Features request is treated as mandatory and will cause enumeration to fail if the Get Features command is not successful.  This change looks at the status codes and will allow enumeration to continue if the device returns Invalid.

Password: intel123
Feedback requested by Feb. 5th.

Unit Tests:
Cold boot
Reboot
Reset while running in the OS
SdStress
SCSI Compliance Test (I did see what I believe are known failures in Read Capacity, Mode Select, and Write (10))
Driver Update using INF

Carolyn Dase Foster
Intel Corp.
NVM Solutions Group
Internal SSD Engineering
Phone: 480-554-2421

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20140130/94733767/attachment.html>