[nvmewin] Potential bug in OFA driver 1.3

[Alex Chang]

I did fix the one in IO_StorPortNotification as well.

Thanks,
Alex

From: Parag Sheth [mailto:parag.sheth at avagotech.com]
Sent: Friday, June 27, 2014 12:24 PM
To: Alex Chang; nvmewin at lists.openfabrics.org
Subject: RE: [nvmewin] Potential bug in OFA driver 1.3

Hi Alex,

Yes that should fix one problem. In addition to that we need to modify DebugPrint statement in IO_StorPortNotification function in nvmestd.c (while enabling STORAGE_REQUEST_BLOCK) to avoid a blue screen. See attached email for the description.
Since this is the first time we are testing driver with STORAGE_REQUEST_BLOCK enabled, we will have to go through a detailed testing.

Thanks
Parag Sheth

From: Alex Chang [mailto:Alex.Chang at pmcs.com<mailto:Alex.Chang at pmcs.com>]
Sent: Friday, June 27, 2014 12:10 PM
To: Parag Sheth; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: [nvmewin] Potential bug in OFA driver 1.3

Hi Parag,

I’ve confirmed that the setting for SrbTypeFlags is required in order to receive STORAGE_REQUEST_BLOCK. In addition, I did see that SrbGetCdb macro provided by srbhelper returns NULL pointer and fixed it already. If SrbTypeFlags is used and set to receive STORAGE_REQUEST_BLOCK only for Windows 8 and up, SrbGetScsiData and SrbSetScsiData will only be called to handle STORAGE_REQUEST_BLOCK in our implementation. Will that solve your problem?

Thanks,
Alex
From: Parag Sheth [mailto:parag.sheth at avagotech.com]
Sent: Thursday, June 26, 2014 11:51 AM
To: Alex Chang; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: [nvmewin] Potential bug in OFA driver 1.3

Hi Alex,

I use VS 2012 for the build.

Thanks
Parag Sheth

From: Alex Chang [mailto:Alex.Chang at pmcs.com<mailto:Alex.Chang at pmcs.com>]
Sent: Thursday, June 26, 2014 11:46 AM
To: Parag Sheth; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: [nvmewin] Potential bug in OFA driver 1.3

Thanks, Parag.
Let me confirm that first. By the way, could you please let me know how you build the driver for Windows 8?

Alex

From: Parag Sheth [mailto:parag.sheth at avagotech.com]
Sent: Thursday, June 26, 2014 11:30 AM
To: Alex Chang; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: [nvmewin] Potential bug in OFA driver 1.3

Hi Alex,

What I have seen during my testing is that windows 8 sends down SCSI_REQUEST_BLOCK if we don’t set any value for SrbTypeFlags. And that is probably the reason nobody got into the blue screen that I mentioned in my previous email.

Thanks
Parag Sheth

From: Alex Chang [mailto:Alex.Chang at pmcs.com<mailto:Alex.Chang at pmcs.com>]
Sent: Thursday, June 26, 2014 9:20 AM
To: Parag Sheth; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: [nvmewin] Potential bug in OFA driver 1.3

Hi Parag,

When we added supporting SRB Extension for Windows 8 and up, there is no plan that supports Windows 8 + SCSI_REQUEST_BLOCK. To be more specific, we need to indicate that via SrbTypeFlags of HW_INITIALIZATION_DATA. However, Windows 8 always sends down STORAGE_REQUEST_BLOCK when SrbTypeFlags is set to zero. Is that what you’re seeing on your testing?

Thanks,
Alex

From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Parag Sheth
Sent: Wednesday, June 25, 2014 4:58 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] Potential bug in OFA driver 1.3

Hi All,

With the latest 1.3 driver, STORAGE_REQUEST_BLOCK support has been added for windows 8 and up. Is this the only configuration allowed with Windows 8 or SCSI_REQUEST_BLOCK + windows 8 combination is allowed as well? If allowed, than there are couple of bugs in the way srbhelper (from wdk) is being used. Specifically SrbSetScsiData() and SrbGetScsiData() from srbhelper do not handle SCSI_REQUEST_BLOCK properly and will cause command failure.

Thanks
Parag Sheth
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20140627/a2a73182/attachment.html>