[nvmewin] OFA Release Plan: Release #1 2015 -- Call for patch volunteers

Fri Sep 11 22:03:10 PDT 2015

Does the Fuzz test fixes patch contain the fix for the race condition/synchronization FreeQList issue? We have seen it too.

Thanks,
Judy

From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Robles, Raymond C
Sent: Monday, August 24, 2015 2:15 PM
To: Iuliu Rus
Cc: nvmewin at lists.openfabrics.org
Subject: Re: [nvmewin] OFA Release Plan: Release #1 2015 -- Call for patch volunteers

Hi Iuliu,

Your patch is now next in queue to be reviewed. Once the patch from ULINK Technology has been reviewed, your patch will be next.

Thanks for your patience.

Thanks
Ray

From: Robles, Raymond C
Sent: Monday, August 03, 2015 4:32 PM
To: 'Iuliu Rus'
Cc: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: [nvmewin] OFA Release Plan: Release #1 2015 -- Call for patch volunteers

Thanks Iuliu. Your patch is third in line right now (two patches ahead of you).

I’ll go ahead and schedule an OFA meeting to discuss a few times, including migrating to github.

Thanks,
Ray

From: Iuliu Rus [mailto:iuliur at google.com]
Sent: Monday, August 03, 2015 1:40 PM
To: Robles, Raymond C
Cc: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: Re: [nvmewin] OFA Release Plan: Release #1 2015 -- Call for patch volunteers

Thank you,
I have sent the first patch containing the fuzz test fixes.
We really hope you will consider patch process changes. Sending zips across is error prone as somebody will have to manually merge changes. Besides the time spent, we run the risk of regressing some earlier change and negate half of the benefits of a source control. Also, dealing with code reviews is harder than it needs to be (as github has them associated with the precise code line and so on).

On Thu, Jul 30, 2015 at 2:25 PM, Robles, Raymond C <raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>> wrote:
Hi Iuliu,

I thought I responded to this email, but in case I didn’t….

For now, I would suggest separating the patch into smaller patches. The use of SVN is not dictated by the NVMeWin group, but rather the OFA (Open Fabrics Alliance) website, and its administrators.

If there were/are enough requests to migrate to github, I could call a meeting to discuss moving to another host website. But the process would not be quick, especially since we are starting to get patches for the end of year release.

Thanks,
Ray

From: Iuliu Rus [mailto:iuliur at google.com<mailto:iuliur at google.com>]
Sent: Thursday, June 25, 2015 12:06 PM

To: Robles, Raymond C
Cc: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: Re: [nvmewin] OFA Release Plan: Release #1 2015 -- Call for patch volunteers

Raymond, we are running the windows HCK fuzz test on the driver and it exposes several crashes. Also, on SCSIOP_START_STOP_UNIT it looks like SntiTransitionPowerState builds an io which it never submits, causing Windows to eventually reset the adapter.
Given that some of these fuzz crashes are potential security issues, we are getting ready to submit the patch next week. However it is rather big and the current patch submission process doesn't work that well. We would like to break it into separate changes, but with zipped thrunk this is not possible. Is there any way to switch this over to github so we can use pull requests instead? Or, should we do separate submissions for now?

On Tue, Jun 2, 2015 at 3:35 PM, Iuliu Rus <iuliur at google.com<mailto:iuliur at google.com>> wrote:
Raymond, given this, project we are going to wait for QEMU to accept the virtualization extensions first (http://git.infradead.org/users/kbusch/qemu-nvme.git/commit/162ec6479447abbd76308f831f36703aa3acc485), then submit our payload which includes what we previously discussed and the windows implementation for the nvme doorbell extensions.

On Fri, May 15, 2015 at 11:38 AM, Robles, Raymond C <raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>> wrote:
Hi Iuliu,

The process for submitting a patch is quite simple (by design). The steps are as follows:

1.       Download the current latest trunk source via an SVN client (i.e. TortoiseSVN). I assume you’ve already done this.

2.       In the Releases folder, under a specific release, there are readme.txt files that explain the build environment needed. Insure you can compile the trunk with the recommended tool/build set.

3.       Port your changes over to the trunk.

4.       Unit test your changes on the trunk source.

5.       Run the required testing outlined in the file attached in this email and insure all tests are passing.

6.       Send an email with the trunk source zipped (with your ported changes) to this email distribution list.

7.       The three reviewing companies will review your changes and also run the tests in the file.

8.       If all looks good, then the source maintainer will merge your changes to the trunk, and create a tag.

9.       If there are any question/comments that require a modifications to you patch, then go back to step 4 after you’ve made any changes and complete the process again.

Let me know if you have any further questions. Feel free to add both patches into a single submission.

You should be able to download all tools necessary outlined in the file. Let us know if you need assistance.

Thanks,
Ray

From: Iuliu Rus [mailto:iuliur at google.com<mailto:iuliur at google.com>]
Sent: Thursday, May 14, 2015 11:02 PM

To: Robles, Raymond C
Cc: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: Re: [nvmewin] OFA Release Plan: Release #1 2015 -- Call for patch volunteers

Can you please point me to the instructions on how to send the patch?
As for the free q list issue, we enabled driver verifier and under stress it bugchecked in RtlpCheckListEntry.

On Thu, May 14, 2015 at 10:52 PM, Robles, Raymond C <raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>> wrote:
Hello,

We always welcome companies to submit patches for candidate features. No other company has volunteered for concurrent channels at this time. We would gladly welcome your patch at your earliest convenience. The first release for 2015 is planned for ~August/September... would you like to volunteer for this patch prior to this release?

As for a race condition synchronization fix for FreeQList, could you please describe the issue you were seeing and how you addressed it?

Thanks,
Ray

From: Iuliu Rus [mailto:iuliur at google.com<mailto:iuliur at google.com>]
Sent: Thursday, May 14, 2015 7:43 PM
To: Robles, Raymond C
Cc: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: Re: [nvmewin] OFA Release Plan: Release #1 2015 -- Call for patch volunteers

Hello,
We are the google compute engine team and we already have Concurrent channels working. We're still figuring out how we can integrate between our internal repo and svn.
Do you still need this feature?
We also have a synchronization fix for a race that corrupted FreeQList.

On Thu, May 7, 2015 at 3:46 PM, Robles, Raymond C <raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>> wrote:
All,

I just wanted to send out a quick update on the release plans for 2015. We’ve had two more companies volunteer to submit patches this year: Samsung (Suman) and HGST (Tom). Thank you to both companies for volunteering!

Here is the updated release plan for 2015. Unfortunately, some of the patch submissions will be a little later than originally planned. Therefore, I would like to ask the question: is everyone ok if we push the first release out until end of August to allow for more patches to be submitted? You can response publicly or just to me.

Other alternatives would include just having smaller releases at different cadences. I’m open to any ideas since there are still many requests for features that have claimed for patch submission.

2015 Release #1 (Q2/Q3 – 2015)

Feature

Description

Submitter

Date

Concurrent Channels

Start I/O Concurrent Channels allows StartIo to be called in parallel resulting in improved IOPS.

<TBD>

<TBD>

Perf Opts

Instead of learning cores, use perf opts. Shave off 2 seconds in init code… using Storport initialize perf opts. No need for source core interrupt steering code in driver.

Samsung (Suman)

End of June

Win 8.1 Timers

Storport Notification usage. Hot plug and IOCTLs, this does not work, for Win8.1… StorportRequestTimer() function needed.

Samsung (Suman)

End of July

CFS Bit Monitoring

CFS bit monitoring and handling. Look into adding additional handling code just to monitor CSTS.CFS.

<TBD>

<TBD>

EOL - Read Only

Read only support for devices at EOL. Detection at init, hot plug, or run-time.

Samsung (Suman)

End of August

Namespace Mgmt

Namespace management - creation and deletion of namespaces.

Intel (Carolyn)

End of June

WHQL

WHQL test suite run (any bug fixes).

<TBD>

<TBD>

2015 Release #2 (Q4 – 2015)

Feature

Description

Submitter

Date

Multi-Path

Multipath feature set from 1.1 spec (Multi-path I/O, Namespace Sharing, Reservations)

HGST (Tom)

Mid-November

RTD3

Active/idle RTD3

<TBD>

<TBD>

Temp Thresholds

Temperature thresholds (Get/Set Feature and AER trigger)

<TBD>

<TBD>

Live FW Update

Live firmware update

<TBD>

<TBD>

Atomicity

Atomicity Enhancements

<TBD>

<TBD>

Win 10

Win 10 support (push to Q4 release)

<TBD>

<TBD>

SNTL

SNTL 1.5 doc updates

HGST (Tom)

End of August

WHQL

WHQL test suite run (any bug fixes) - for each release of OFA

<TBD>

<TBD>

Thanks,
Ray

From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org>] On Behalf Of Robles, Raymond C
Sent: Thursday, April 09, 2015 5:29 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] OFA Release Plan: Release #1 2015 -- Call for patch volunteers

All,

As we enter Q2, I’m happy to announce that we a have a very good feature plan in place for both Q2 and Q4 releases in 2015 of the OFA driver. The list of requested features is included below for final review.

I would like to formally ask for volunteers for patch submissions. As of today, there are no volunteers for any of the below patches.

Intel would like to start with the volunteering… we will volunteer to provide the namespace management patch.

2015 Release #1 (Q2/Q3 – 2015)

Feature

Description

Submitter

Date

Concurrent Channels