[nvmewin] Zero Length for Security Receive and Security Send command

Mon Sep 14 09:04:59 PDT 2015

Hi:

Thanks all for the review and approval.

Best Regards,

Yun Wang

ULINK Technology, Inc. |  <http://www.ulinktech.com/> http://www.ulinktech.com/| +1(408) 446-8455

From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Robles, Raymond C
Sent: Friday, September 11, 2015 1:23 PM
To: 'Alex Chang'; Kwok Kong; nvmewin at lists.openfabrics.org
Subject: Re: [nvmewin] Zero Length for Security Receive and Security Send command

Thanks Alex. The patch from ULINK (Yun) for zero length Security Send/Receive has been approved and will be pushed before Monday. 

The next review is Google’s patch (Iulius) for fuzz testing. Reviewing companies, please review Google’s patch and provide your decision by 9/25.

Thanks,

Ray

From: Alex Chang [mailto:Alex.Chang at pmcs.com] 
Sent: Friday, September 11, 2015 1:13 PM
To: Robles, Raymond C; Kwok Kong; nvmewin at lists.openfabrics.org
Subject: RE: [nvmewin] Zero Length for Security Receive and Security Send command

Hi Ray,

Sorry for the delay. PMC approves the patch.

As for reviewing the future patches, I will leave it to Kwok to make the call.

Thank you!

Alex

From: Robles, Raymond C [mailto:raymond.c.robles at intel.com] 
Sent: Tuesday, September 08, 2015 10:40 AM
To: Kwok Kong; Alex Chang
Subject: RE: [nvmewin] Zero Length for Security Receive and Security Send command

Hi Kwok/Alex,

Hope all is going well. I have not heard back from either of you on the approval on the last patch. We are waiting on your feedback for final approval. Will you be able to review this, and future, patche(s)?

 Reviewing Company

Status

Samsung

Approved

PMC-Sierra

Review In Progress

HGST

Approved

Intel

Approved

Thanks,

Ray

From: Robles, Raymond C 
Sent: Tuesday, September 01, 2015 11:32 PM
To: suman.p at samsung.com; nvmewin at lists.openfabrics.org; yun.wang at ulinktech.com; Judy Brock-SSI (judy.brock at ssi.samsung.com)
Subject: RE: [nvmewin] Zero Length for Security Receive and Security Send command

Thanks Suman!

-------- Original message --------
From: SUMAN PRAKASH B <suman.p at samsung.com> 
Date: 09/01/2015 7:06 PM (GMT-07:00) 
To: nvmewin at lists.openfabrics.org, yun.wang at ulinktech.com, "Robles, Raymond C" <raymond.c.robles at intel.com>, "Judy Brock-SSI (judy.brock at ssi.samsung.com)" <judy.brock at ssi.samsung.com> 
Subject: [nvmewin] Zero Length for Security Receive and Security Send command 

Hi Yun, Ray,

SAMSUNG approves this patch.

Thanks,
Suman

From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Robles, Raymond C
Sent: Tuesday, September 01, 2015 11:39 AM
To: Thomas Freeman; Yun Wang; nvmewin at lists.openfabrics.org
Subject: Re: [nvmewin] Zero Length for Security Receive and Security Send command

Thanks Tom.

Now just waiting on Samsung and PMC-Sierra.

Reviewing Company

Status

Samsung

Review In Progress

PMC-Sierra

Review In Progress

HGST

Approved

Intel

Approved

After this patch, there are two patches in queue to be reviewed:

1.       NVMe fuzz test fixes (Google)

2.       Namespace management (Intel)

Thanks,

Ray

From: Thomas Freeman [mailto:thomas.freeman at hgst.com] 
Sent: Monday, August 31, 2015 11:41 AM
To: Robles, Raymond C; Yun Wang; nvmewin at lists.openfabrics.org
Subject: RE: [nvmewin] Zero Length for Security Receive and Security Send command

Hi Yun,

HGST approves your patch.

Tom Freeman

Software Engineer, Device Manager and Driver Development

HGST, a Western Digital company

 <mailto:thomas.freeman at hgst.com> thomas.freeman at hgst.com

507-322-2311

HGST_Logo_email

3605 Hwy 52 N  
Rochester, MN 55901
 <https://hgst.jiveon.com/external-link.jspa?url=http://www.hgst.com/> www.hgst.com

From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Robles, Raymond C
Sent: Thursday, August 27, 2015 1:04 PM
To: Yun Wang <yun.wang at ulinktech.com>; nvmewin at lists.openfabrics.org
Subject: Re: [nvmewin] Zero Length for Security Receive and Security Send command

Hi Yun,

Intel has reviewed and tested your patch and approves your patch. Just need to hear back from the other reviewing companies.

Reviewing Company

Status

Samsung

Review In Progress

PMC-Sierra

Review In Progress

HGST

Review In Progress

Intel

Approved

Thanks,
Ray 

From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Robles, Raymond C
Sent: Monday, August 24, 2015 2:14 PM
To: Yun Wang; nvmewin at lists.openfabrics.org
Subject: Re: [nvmewin] Zero Length for Security Receive and Security Send command

Yun,

Your patch is now in line to be reviewed.

Reviewing Companies,

Please review Yun’s patch for zero length Secure Send/Receive commands and provide feedback on or before September 4th. Thanks!

Thanks,

Ray

From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Robles, Raymond C
Sent: Thursday, July 30, 2015 3:25 PM
To: Yun Wang
Cc: nvmewin at lists.openfabrics.org
Subject: Re: [nvmewin] Zero Length for Security Receive and Security Send command

Hi Yun,

Thank you for your patch submission. There is one patch in front of yours. Once that patch has been reviewed and approved, your patch will be reviewed next. 

Thanks,

Ray

From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Yun Wang
Sent: Friday, July 24, 2015 6:00 PM
To: nvmewin at lists.openfabrics.org
Subject: [nvmewin] Zero Length for Security Receive and Security Send command

Hi:

Current OFA driver doesn’t allow zero length for Security Receive and Security Send command.

Per NVMe spec., “Security Receive command with the Security Protocol field set to 00h shall return information about the security protocols supported by the controller. This command is used in the security discovery process and is not associated with a Security Send command. Refer to SPC-4 for the details of Security Protocol 00h and the SP Specific field”. 

Per SPC-4 spec., “a transfer length of zero specifies that no data transfer shall take place. This condition shall not be considered an error”, zero length of data transfer for Security Protocol 00h should be allowed.

On the other hand,  for some practices with other Security Protocol, zero length will be needed, too.

This patch is to allow zero length of data transfer for Security Receive and Security Send command. It has been tested over Win8.1 x64 platform and works as expected. Please review and help merge it into the trunk.

The password for the attachment is nvme_sec.

Best Regards,

Yun Wang

ULINK Technology, Inc.

Website: www.ulinktech.com 

Office: +1(408) 446-8455 

Email:  <mailto:joseph.chen at ulinktech.com> yun.wang at ulinktech.com

 <http://www.ulinktech.com/> ulink logo 2

DISCLAIMER: The information contained in this message is confidential and may be legally privileged. If you are not the intended recipient (or have received this e-mail in error), please notify the sender immediately and delete this e-mail. Any unauthorized copying, disclosure or distribution of the contents in this e-mail is strictly forbidden.

HGST E-mail Confidentiality Notice & Disclaimer:
This e-mail and any files transmitted with it may contain confidential or legally privileged information of HGST and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited.  If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.

Image removed by sender.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20150914/943f12be/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 4274 bytes
Desc: not available
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20150914/943f12be/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.jpg
Type: image/jpeg
Size: 1628 bytes
Desc: not available
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20150914/943f12be/attachment.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image003.gif
Type: image/gif
Size: 13168 bytes
Desc: not available
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20150914/943f12be/attachment.gif>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image004.jpg
Type: image/jpeg
Size: 823 bytes
Desc: not available
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20150914/943f12be/attachment-0001.jpg>