From raymond.c.robles at intel.com  Tue Nov  1 11:27:24 2016
From: raymond.c.robles at intel.com (Robles, Raymond C)
Date: Tue, 1 Nov 2016 18:27:24 +0000
Subject: [nvmewin] Issue with the latest OFA driver
In-Reply-To: <SN2PR04MB2239181FA5C8F073DEFB63D591A10@SN2PR04MB2239.namprd04.prod.outlook.com>
References: <SN2PR04MB2239181FA5C8F073DEFB63D591A10@SN2PR04MB2239.namprd04.prod.outlook.com>
Message-ID: <49158E750348AA499168FD41D88983607C67BEA6@fmsmsx117.amr.corp.intel.com>


Hi Tom,

Good find!

I'm of the opinion that it makes sense to get this patch in for the release we are about to announce. This is a minor fix for the Identify command that is isolated to two scenarios. Does anyone else have any objections or feel we should wait for this patch?

Depending on the feedback, we can go ahead and push a patch. I would say for now, please get the patch ready and then let's hold for feedback from the community reviewers... and go from there.

Thank you...
Ray

From: Tom Freeman [mailto:thomas.freeman at wdc.com]
Sent: Tuesday, November 01, 2016 9:08 AM
To: Robles, Raymond C <raymond.c.robles at intel.com>; nvmewin <nvmewin at lists.openfabrics.org>
Subject: Issue with the latest OFA driver

Ray,
We've run into the following issue with the latest OFA driver.
During initialization, the driver request for NVME Identify Namespace fails with a status of "invalid field in command". Because of this, initialization fails and the device does not show up.
The underlying cause is that the driver puts the controller ID value into CDW10.CNTID. According to the NVMe spec, that is only valid when CNS = 0x12 or 0x13. For all other cases, "the host shall clear this field to 0h"

I'd like to make a patch for this. The fix would remove controller ID from any of the instance of NVMe Identify command (the driver does not use CNS = 0x12 or 0x13). How would you like me to proceed to coordinate with the current 1.5 testing?
Thanks,

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:
This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161101/09d440d9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.gif
Type: image/gif
Size: 1117 bytes
Desc: image002.gif
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161101/09d440d9/attachment.gif>

From thomas.freeman at wdc.com  Tue Nov  1 09:08:24 2016
From: thomas.freeman at wdc.com (Tom Freeman)
Date: Tue, 1 Nov 2016 16:08:24 +0000
Subject: [nvmewin] Issue with the latest OFA driver
Message-ID: <SN2PR04MB2239181FA5C8F073DEFB63D591A10@SN2PR04MB2239.namprd04.prod.outlook.com>


Ray,
We've run into the following issue with the latest OFA driver.
During initialization, the driver request for NVME Identify Namespace fails with a status of "invalid field in command". Because of this, initialization fails and the device does not show up.
The underlying cause is that the driver puts the controller ID value into CDW10.CNTID. According to the NVMe spec, that is only valid when CNS = 0x12 or 0x13. For all other cases, "the host shall clear this field to 0h"

I'd like to make a patch for this. The fix would remove controller ID from any of the instance of NVMe Identify command (the driver does not use CNS = 0x12 or 0x13). How would you like me to proceed to coordinate with the current 1.5 testing?
Thanks,

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com
Office:  +1-507-322-2311

Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:

This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161101/dc0c0955/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 1117 bytes
Desc: image001.gif
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161101/dc0c0955/attachment.gif>

From thomas.freeman at wdc.com  Fri Nov 11 06:40:57 2016
From: thomas.freeman at wdc.com (Tom Freeman)
Date: Fri, 11 Nov 2016 14:40:57 +0000
Subject: [nvmewin] Issue with the latest OFA driver
In-Reply-To: <49158E750348AA499168FD41D88983607C67BEA6@fmsmsx117.amr.corp.intel.com>
References: <SN2PR04MB2239181FA5C8F073DEFB63D591A10@SN2PR04MB2239.namprd04.prod.outlook.com>
 <49158E750348AA499168FD41D88983607C67BEA6@fmsmsx117.amr.corp.intel.com>
Message-ID: <BN3PR04MB22281D88E586DAD5B24C9B2491BB0@BN3PR04MB2228.namprd04.prod.outlook.com>


Ray,
In case you decide to include this fix in the latest release, here are the details:

The attached zip file, Ident-CNTIDPatch.zip (password = nvmehgst) contains:

1.       Source subdirectory containing the modified code based on revision 139.

2.       ControllerIdFix.patch containing the SVN patch to revision 139.

3.       README.txt - description of the problem and the fix.

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com
Office:  +1-507-322-2311

From: Robles, Raymond C [mailto:raymond.c.robles at intel.com]
Sent: Tuesday, November 1, 2016 1:27 PM
To: Tom Freeman <thomas.freeman at wdc.com>; nvmewin <nvmewin at lists.openfabrics.org>
Subject: RE: Issue with the latest OFA driver

Hi Tom,

Good find!

I'm of the opinion that it makes sense to get this patch in for the release we are about to announce. This is a minor fix for the Identify command that is isolated to two scenarios. Does anyone else have any objections or feel we should wait for this patch?

Depending on the feedback, we can go ahead and push a patch. I would say for now, please get the patch ready and then let's hold for feedback from the community reviewers... and go from there.

Thank you...
Ray

From: Tom Freeman [mailto:thomas.freeman at wdc.com]
Sent: Tuesday, November 01, 2016 9:08 AM
To: Robles, Raymond C <raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: Issue with the latest OFA driver

Ray,
We've run into the following issue with the latest OFA driver.
During initialization, the driver request for NVME Identify Namespace fails with a status of "invalid field in command". Because of this, initialization fails and the device does not show up.
The underlying cause is that the driver puts the controller ID value into CDW10.CNTID. According to the NVMe spec, that is only valid when CNS = 0x12 or 0x13. For all other cases, "the host shall clear this field to 0h"

I'd like to make a patch for this. The fix would remove controller ID from any of the instance of NVMe Identify command (the driver does not use CNS = 0x12 or 0x13). How would you like me to proceed to coordinate with the current 1.5 testing?
Thanks,

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:
This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.
Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:

This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161111/46c765b0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 1117 bytes
Desc: image001.gif
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161111/46c765b0/attachment.gif>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Ident-CNTIDPatch.zip
Type: application/x-zip-compressed
Size: 216388 bytes
Desc: Ident-CNTIDPatch.zip
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161111/46c765b0/attachment.bin>

From raymond.c.robles at intel.com  Fri Nov 11 10:50:32 2016
From: raymond.c.robles at intel.com (Robles, Raymond C)
Date: Fri, 11 Nov 2016 18:50:32 +0000
Subject: [nvmewin] Issue with the latest OFA driver
In-Reply-To: <BN3PR04MB22281D88E586DAD5B24C9B2491BB0@BN3PR04MB2228.namprd04.prod.outlook.com>
References: <SN2PR04MB2239181FA5C8F073DEFB63D591A10@SN2PR04MB2239.namprd04.prod.outlook.com>
 <49158E750348AA499168FD41D88983607C67BEA6@fmsmsx117.amr.corp.intel.com>
 <BN3PR04MB22281D88E586DAD5B24C9B2491BB0@BN3PR04MB2228.namprd04.prod.outlook.com>
Message-ID: <49158E750348AA499168FD41D88983607C68244F@fmsmsx117.amr.corp.intel.com>


Thanks Tom.

Samsung (Judy/Suman), do you have any opinion on pulling in this patch for the upcoming release?

Thanks...
Ray

From: Tom Freeman [mailto:thomas.freeman at wdc.com]
Sent: Friday, November 11, 2016 7:41 AM
To: Robles, Raymond C <raymond.c.robles at intel.com>; nvmewin <nvmewin at lists.openfabrics.org>
Subject: RE: Issue with the latest OFA driver

Ray,
In case you decide to include this fix in the latest release, here are the details:

The attached zip file, Ident-CNTIDPatch.zip (password = nvmehgst) contains:

1.       Source subdirectory containing the modified code based on revision 139.

2.       ControllerIdFix.patch containing the SVN patch to revision 139.

3.       README.txt - description of the problem and the fix.

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

From: Robles, Raymond C [mailto:raymond.c.robles at intel.com]
Sent: Tuesday, November 1, 2016 1:27 PM
To: Tom Freeman <thomas.freeman at wdc.com<mailto:thomas.freeman at wdc.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: RE: Issue with the latest OFA driver

Hi Tom,

Good find!

I'm of the opinion that it makes sense to get this patch in for the release we are about to announce. This is a minor fix for the Identify command that is isolated to two scenarios. Does anyone else have any objections or feel we should wait for this patch?

Depending on the feedback, we can go ahead and push a patch. I would say for now, please get the patch ready and then let's hold for feedback from the community reviewers... and go from there.

Thank you...
Ray

From: Tom Freeman [mailto:thomas.freeman at wdc.com]
Sent: Tuesday, November 01, 2016 9:08 AM
To: Robles, Raymond C <raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: Issue with the latest OFA driver

Ray,
We've run into the following issue with the latest OFA driver.
During initialization, the driver request for NVME Identify Namespace fails with a status of "invalid field in command". Because of this, initialization fails and the device does not show up.
The underlying cause is that the driver puts the controller ID value into CDW10.CNTID. According to the NVMe spec, that is only valid when CNS = 0x12 or 0x13. For all other cases, "the host shall clear this field to 0h"

I'd like to make a patch for this. The fix would remove controller ID from any of the instance of NVMe Identify command (the driver does not use CNS = 0x12 or 0x13). How would you like me to proceed to coordinate with the current 1.5 testing?
Thanks,

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:
This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.
Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:
This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.

CAUTION: Please confirm that the password protected
.zip attachment which contains the file(s) of type
  image001.gif, Ident-CNTIDPatch.zip
is legitimate prior to opening.  To make sure this
message is not infected with a virus, it is important to
verify that you are expecting the message or else
confirm its legitimacy with the sender.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161111/b8f5d369/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.gif
Type: image/gif
Size: 1117 bytes
Desc: image002.gif
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161111/b8f5d369/attachment.gif>

From judy.brock at samsung.com  Fri Nov 11 15:28:44 2016
From: judy.brock at samsung.com (Judy Brock)
Date: Fri, 11 Nov 2016 23:28:44 +0000
Subject: [nvmewin] Issue with the latest OFA driver
In-Reply-To: <49158E750348AA499168FD41D88983607C68244F@fmsmsx117.amr.corp.intel.com>
References: <SN2PR04MB2239181FA5C8F073DEFB63D591A10@SN2PR04MB2239.namprd04.prod.outlook.com>
 <49158E750348AA499168FD41D88983607C67BEA6@fmsmsx117.amr.corp.intel.com>
 <BN3PR04MB22281D88E586DAD5B24C9B2491BB0@BN3PR04MB2228.namprd04.prod.outlook.com>
 <49158E750348AA499168FD41D88983607C68244F@fmsmsx117.amr.corp.intel.com>
 <CGME20161111232845uscas1p20c248d30b627c71879e4d74d1b113141@uscas1p2.samsung.com>
Message-ID: <36E8D38D6B771A4BBDB1C0D800158A51878B998D@SSIEXCH-MB3.ssi.samsung.com>



Personally, I think it makes good sense. Suman?

From: nvmewin [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Robles, Raymond C
Sent: Friday, November 11, 2016 10:51 AM
To: Tom Freeman; nvmewin
Subject: Re: [nvmewin] Issue with the latest OFA driver

Thanks Tom.

Samsung (Judy/Suman), do you have any opinion on pulling in this patch for the upcoming release?

Thanks...
Ray

From: Tom Freeman [mailto:thomas.freeman at wdc.com]<mailto:[mailto:thomas.freeman at wdc.com]>
Sent: Friday, November 11, 2016 7:41 AM
To: Robles, Raymond C <raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: RE: Issue with the latest OFA driver

Ray,
In case you decide to include this fix in the latest release, here are the details:

The attached zip file, Ident-CNTIDPatch.zip (password = nvmehgst) contains:

1.       Source subdirectory containing the modified code based on revision 139.

2.       ControllerIdFix.patch containing the SVN patch to revision 139.

3.       README.txt - description of the problem and the fix.

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

From: Robles, Raymond C [mailto:raymond.c.robles at intel.com]
Sent: Tuesday, November 1, 2016 1:27 PM
To: Tom Freeman <thomas.freeman at wdc.com<mailto:thomas.freeman at wdc.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: RE: Issue with the latest OFA driver

Hi Tom,

Good find!

I'm of the opinion that it makes sense to get this patch in for the release we are about to announce. This is a minor fix for the Identify command that is isolated to two scenarios. Does anyone else have any objections or feel we should wait for this patch?

Depending on the feedback, we can go ahead and push a patch. I would say for now, please get the patch ready and then let's hold for feedback from the community reviewers... and go from there.

Thank you...
Ray

From: Tom Freeman [mailto:thomas.freeman at wdc.com]
Sent: Tuesday, November 01, 2016 9:08 AM
To: Robles, Raymond C <raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: Issue with the latest OFA driver

Ray,
We've run into the following issue with the latest OFA driver.
During initialization, the driver request for NVME Identify Namespace fails with a status of "invalid field in command". Because of this, initialization fails and the device does not show up.
The underlying cause is that the driver puts the controller ID value into CDW10.CNTID. According to the NVMe spec, that is only valid when CNS = 0x12 or 0x13. For all other cases, "the host shall clear this field to 0h"

I'd like to make a patch for this. The fix would remove controller ID from any of the instance of NVMe Identify command (the driver does not use CNS = 0x12 or 0x13). How would you like me to proceed to coordinate with the current 1.5 testing?
Thanks,

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:
This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.
Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:
This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.

CAUTION: Please confirm that the password protected
.zip attachment which contains the file(s) of type
  image001.gif, Ident-CNTIDPatch.zip
is legitimate prior to opening.  To make sure this
message is not infected with a virus, it is important to
verify that you are expecting the message or else
confirm its legitimacy with the sender.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161111/059bed21/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 1117 bytes
Desc: image001.gif
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161111/059bed21/attachment.gif>

From suman.p at samsung.com  Mon Nov 14 07:05:31 2016
From: suman.p at samsung.com (=?UTF-8?B?U1VNQU4gUFJBS0FTSCBC?=)
Date: Mon, 14 Nov 2016 15:05:31 +0000
Subject: [nvmewin] =?utf-8?q?Issue_with_the_latest_OFA_driver?=
References: <SN2PR04MB2239181FA5C8F073DEFB63D591A10@SN2PR04MB2239.namprd04.prod.outlook.com>
 <49158E750348AA499168FD41D88983607C67BEA6@fmsmsx117.amr.corp.intel.com>
 <BN3PR04MB22281D88E586DAD5B24C9B2491BB0@BN3PR04MB2228.namprd04.prod.outlook.com>
 <49158E750348AA499168FD41D88983607C68244F@fmsmsx117.amr.corp.intel.com>
 <CGME20161111232845uscas1p291b96218c145468df44128e035ecf1d3@uscas1p2.samsung.com>
Message-ID: <20161114150531epcms5p6dca93db7800a35553fa1b23f7d05e783@epcms5p6>

An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161114/24da04d1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 201611142037377_BEI0XT4N.gif
Type: image/gif
Size: 1117 bytes
Desc: not available
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161114/24da04d1/attachment.gif>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 201602111742151_N3WZA6X7.png
Type: image/png
Size: 33527 bytes
Desc: not available
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161114/24da04d1/attachment.png>

From raymond.c.robles at intel.com  Mon Nov 14 13:14:02 2016
From: raymond.c.robles at intel.com (Robles, Raymond C)
Date: Mon, 14 Nov 2016 21:14:02 +0000
Subject: [nvmewin] Issue with the latest OFA driver
In-Reply-To: <20161114150531epcms5p6dca93db7800a35553fa1b23f7d05e783@epcms5p6>
References: <SN2PR04MB2239181FA5C8F073DEFB63D591A10@SN2PR04MB2239.namprd04.prod.outlook.com>
 <49158E750348AA499168FD41D88983607C67BEA6@fmsmsx117.amr.corp.intel.com>
 <BN3PR04MB22281D88E586DAD5B24C9B2491BB0@BN3PR04MB2228.namprd04.prod.outlook.com>
 <49158E750348AA499168FD41D88983607C68244F@fmsmsx117.amr.corp.intel.com>
 <CGME20161111232845uscas1p291b96218c145468df44128e035ecf1d3@uscas1p2.samsung.com>
 <20161114150531epcms5p6dca93db7800a35553fa1b23f7d05e783@epcms5p6>
Message-ID: <49158E750348AA499168FD41D88983607C684997@fmsmsx117.amr.corp.intel.com>


Thanks Suman/Judy.

I’ll go ahead and pull the fix into the current trunk. Thanks for catching this Tom.

Thanks…
Ray

From: SUMAN PRAKASH B [mailto:suman.p at samsung.com]
Sent: Monday, November 14, 2016 8:06 AM
To: Judy Brock <judy.brock at samsung.com>; Robles, Raymond C <raymond.c.robles at intel.com>; Tom Freeman <thomas.freeman at wdc.com>; nvmewin <nvmewin at lists.openfabrics.org>
Subject: RE: RE: Issue with the latest OFA driver


Ray, Judy,



Yes, it makes good sense to pull in this patch for the upcoming release.



Thanks,

Suman



--------- Original Message ---------

Sender : Judy Brock <judy.brock at samsung.com<mailto:judy.brock at samsung.com>> Engineer Staff/America Office(DS)-R&D-MSL - Enterprise Product Development - R&D/Samsung Electronics

Date : 2016-11-12 04:58 (GMT+5:30)

Title : RE: Issue with the latest OFA driver



Personally, I think it makes good sense. Suman?

From: nvmewin [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Robles, Raymond C
Sent: Friday, November 11, 2016 10:51 AM
To: Tom Freeman; nvmewin
Subject: Re: [nvmewin] Issue with the latest OFA driver

Thanks Tom.

Samsung (Judy/Suman), do you have any opinion on pulling in this patch for the upcoming release?

Thanks…
Ray

From: Tom Freeman [mailto:thomas.freeman at wdc.com]<mailto:[mailto:thomas.freeman at wdc.com]>
Sent: Friday, November 11, 2016 7:41 AM
To: Robles, Raymond C <raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: RE: Issue with the latest OFA driver

Ray,
In case you decide to include this fix in the latest release, here are the details:

The attached zip file, Ident-CNTIDPatch.zip (password = nvmehgst) contains:

1.       Source subdirectory containing the modified code based on revision 139.

2.       ControllerIdFix.patch containing the SVN patch to revision 139.

3.       README.txt – description of the problem and the fix.

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

From: Robles, Raymond C [mailto:raymond.c.robles at intel.com]
Sent: Tuesday, November 1, 2016 1:27 PM
To: Tom Freeman <thomas.freeman at wdc.com<mailto:thomas.freeman at wdc.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: RE: Issue with the latest OFA driver

Hi Tom,

Good find!

I’m of the opinion that it makes sense to get this patch in for the release we are about to announce. This is a minor fix for the Identify command that is isolated to two scenarios. Does anyone else have any objections or feel we should wait for this patch?

Depending on the feedback, we can go ahead and push a patch. I would say for now, please get the patch ready and then let’s hold for feedback from the community reviewers… and go from there.

Thank you…
Ray

From: Tom Freeman [mailto:thomas.freeman at wdc.com]
Sent: Tuesday, November 01, 2016 9:08 AM
To: Robles, Raymond C <raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: Issue with the latest OFA driver

Ray,
We’ve run into the following issue with the latest OFA driver.
During initialization, the driver request for NVME Identify Namespace fails with a status of “invalid field in command”. Because of this, initialization fails and the device does not show up.
The underlying cause is that the driver puts the controller ID value into CDW10.CNTID. According to the NVMe spec, that is only valid when CNS = 0x12 or 0x13. For all other cases, “the host shall clear this field to 0h”

I’d like to make a patch for this. The fix would remove controller ID from any of the instance of NVMe Identify command (the driver does not use CNS = 0x12 or 0x13). How would you like me to proceed to coordinate with the current 1.5 testing?
Thanks,

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:
This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.
Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:
This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.

CAUTION: Please confirm that the password protected
.zip attachment which contains the file(s) of type
  image001.gif, Ident-CNTIDPatch.zip
is legitimate prior to opening.  To make sure this
message is not infected with a virus, it is important to
verify that you are expecting the message or else
confirm its legitimacy with the sender.

[cid:image002.png at 01D23E7F.B04ADA70]

[http://ext.samsung.net/mail/ext/v1/external/status/update?userid=suman.p&do=bWFpbElEPTIwMTYxMTE0MTUwNTMxZXBjbXM1cDZkY2E5M2RiNzgwMGEzNTU1M2ZhMWIyM2Y3ZDA1ZTc4MyZyZWNpcGllbnRBZGRyZXNzPXJheW1vbmQuYy5yb2JsZXNAaW50ZWwuY29t]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161114/24cbb0e1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 1117 bytes
Desc: image001.gif
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161114/24cbb0e1/attachment.gif>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.png
Type: image/png
Size: 33527 bytes
Desc: image002.png
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161114/24cbb0e1/attachment.png>

From raymond.c.robles at intel.com  Thu Nov 17 12:54:42 2016
From: raymond.c.robles at intel.com (Robles, Raymond C)
Date: Thu, 17 Nov 2016 20:54:42 +0000
Subject: [nvmewin] OFA Reference Driver 2016 Release -- WHCK Certification
 Logo Results
Message-ID: <49158E750348AA499168FD41D88983607C69781C@fmsmsx117.amr.corp.intel.com>

Hello OFA Community,

I have the results of the WHCK certification logo test suite run on the latest OFA driver source trunk here at Intel.

The results are as follows...

Configuration:

*         NVMe Device: Intel(R) P3700 Solid-State Drive

*         OS: Windows Server 2016

Observed Failures:

  *   NVMe SCSI Compliance Test (LOGO) fails ASSERTION: INQUIRY Attempting Unit Serial Number Page 0x80; the unit serial number page length needs to be set to either 20 for EUI64 or 36 for NGUID, and actual is 30.
  *   NVMe Interrupt Modes Test (LOGO) crashed with a strange 0x34 CACHE_MANAGER BSOD the first run. Unable to replicate with two subsequent runs that passed.

Not Run:

  *   Static Tools Logo Test cannot be executed without DVL output, so not run. DVL logs not created due to no submission to MSFT.

Results:

*         All other tests look good and passed successfully :).

At this point, I feel comfortable proceeding with the release the OFA driver (from the current trunk). My plan will be to release the driver package the week after Thanksgiving holiday (US)... by Friday December 2. If anyone has any objections to releasing the current driver, please respond and we can discuss further.

NOTE: Apologies for the delay in getting these results, but other higher priority internal milestones had taken precedence here internally at Intel. While I'm happy to help out where I can, without stronger participation from the community, Intel is limited in amount of assistance (amount of work and timeline) it can provide. The OFA driver is only as strong as its contributors. Moving forward, I hope to see stronger participation to maintain a relevant and valuable open source Windows driver.

Thanks...
Ray

Raymond C. Robles
NSG ISE Host Storage Software
Intel Corporation
Office: 480-554-2600
Mobile: 480-399-0645
raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>

[cid:image001.gif at 01CB9B29.EA8D14F0]

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161117/cde36b6c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.jpg
Type: image/jpeg
Size: 1568 bytes
Desc: image002.jpg
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20161117/cde36b6c/attachment.jpg>