[nvmewin] [PATCH] ADMIN_CREATE_IO_SUBMISSION_QUEUE bug fix

subrahmanya l l.subrahmanya at mobiveil.co.in
Wed Sep 21 02:46:06 PDT 2016


All,
As of today if the CAP.MQES = 0x1F, with windows driver
code, NVMeCreateSubQueue function will set QSIZE to 0x3F, which is clearly
violation of the NVME specification, This happened because of the following
unconditional change of queue entry size in NVMeAllocQueues()

​    SysPageSizeInSubEntries = PAGE_SIZE / sizeof (NVMe_COMMAND);
    if ((QEntries % SysPageSizeInSubEntries) != 0)
        QEntries = (QEntries + SysPageSizeInSubEntries) &
                  ~(SysPageSizeInSubEntries - 1);

​Attaching the patch for the revision 1.4 source code, please consider.

-- 
Thanks,
~subbu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20160921/5dfffaa9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nvme_QEntries_fix.patch
Type: application/octet-stream
Size: 3423 bytes
Desc: not available
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20160921/5dfffaa9/attachment.obj>


More information about the nvmewin mailing list