From thomas.freeman at wdc.com  Wed Feb  8 11:31:32 2017
From: thomas.freeman at wdc.com (Tom Freeman)
Date: Wed, 8 Feb 2017 19:31:32 +0000
Subject: [nvmewin] Issue with the latest OFA driver
References: <SN2PR04MB2239181FA5C8F073DEFB63D591A10@SN2PR04MB2239.namprd04.prod.outlook.com>
 <49158E750348AA499168FD41D88983607C67BEA6@fmsmsx117.amr.corp.intel.com> 
Message-ID: <BN3PR04MB222869E492D6E76D952475A291420@BN3PR04MB2228.namprd04.prod.outlook.com>


Ray,
Unless I'm missing something, it appears the change to remove CNTID from Identify commands did not make it into 1.5

Here is the relevant code from the fix I submitted:

    /* Populate submission entry fields */
    pIdentify = &pNVMeSrbExt->nvmeSqeUnit;
    pIdentify->CDW0.OPC = ADMIN_IDENTIFY;

   pIdentifyCDW10 = (PADMIN_IDENTIFY_COMMAND_DW10) &pIdentify->CDW10;
    /* Set the type of identify command */
    pIdentifyCDW10->CNS = CNS;

    switch (CNS) {


Here is the same code in the trunk and the 1.5 release source:

/* Populate submission entry fields */

    pIdentify = &pNVMeSrbExt->nvmeSqeUnit;

    pIdentify->CDW0.OPC = ADMIN_IDENTIFY;



    pIdentifyCDW10 = (PADMIN_IDENTIFY_COMMAND_DW10) &pIdentify->CDW10;

    /* Set the type of identify command */

    pIdentifyCDW10->CNS = CNS;

    /* Select the controller to talk to */

    pIdentifyCDW10->CNTID = CNTID;



    switch (CNS) {





Can we get this updated, including the 1.5 builds?

Thanks,


Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com
Office:  +1-507-322-2311

From: Tom Freeman
Sent: Friday, November 11, 2016 8:41 AM
To: 'Robles, Raymond C' <raymond.c.robles at intel.com>; nvmewin <nvmewin at lists.openfabrics.org>
Subject: RE: Issue with the latest OFA driver

Ray,
In case you decide to include this fix in the latest release, here are the details:

The attached zip file, Ident-CNTIDPatch.zip (password = nvmehgst) contains:

1.       Source subdirectory containing the modified code based on revision 139.

2.       ControllerIdFix.patch containing the SVN patch to revision 139.

3.       README.txt - description of the problem and the fix.

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

From: Robles, Raymond C [mailto:raymond.c.robles at intel.com]
Sent: Tuesday, November 1, 2016 1:27 PM
To: Tom Freeman <thomas.freeman at wdc.com<mailto:thomas.freeman at wdc.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: RE: Issue with the latest OFA driver

Hi Tom,

Good find!

I'm of the opinion that it makes sense to get this patch in for the release we are about to announce. This is a minor fix for the Identify command that is isolated to two scenarios. Does anyone else have any objections or feel we should wait for this patch?

Depending on the feedback, we can go ahead and push a patch. I would say for now, please get the patch ready and then let's hold for feedback from the community reviewers... and go from there.

Thank you...
Ray

From: Tom Freeman [mailto:thomas.freeman at wdc.com]
Sent: Tuesday, November 01, 2016 9:08 AM
To: Robles, Raymond C <raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: Issue with the latest OFA driver

Ray,
We've run into the following issue with the latest OFA driver.
During initialization, the driver request for NVME Identify Namespace fails with a status of "invalid field in command". Because of this, initialization fails and the device does not show up.
The underlying cause is that the driver puts the controller ID value into CDW10.CNTID. According to the NVMe spec, that is only valid when CNS = 0x12 or 0x13. For all other cases, "the host shall clear this field to 0h"

I'd like to make a patch for this. The fix would remove controller ID from any of the instance of NVMe Identify command (the driver does not use CNS = 0x12 or 0x13). How would you like me to proceed to coordinate with the current 1.5 testing?
Thanks,

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:
This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.
Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:

This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20170208/d393df6b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.gif
Type: image/gif
Size: 1117 bytes
Desc: image002.gif
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20170208/d393df6b/attachment.gif>

From raymond.c.robles at intel.com  Thu Feb  9 10:09:51 2017
From: raymond.c.robles at intel.com (Robles, Raymond C)
Date: Thu, 9 Feb 2017 18:09:51 +0000
Subject: [nvmewin] Issue with the latest OFA driver
In-Reply-To: <BN3PR04MB222869E492D6E76D952475A291420@BN3PR04MB2228.namprd04.prod.outlook.com>
References: <SN2PR04MB2239181FA5C8F073DEFB63D591A10@SN2PR04MB2239.namprd04.prod.outlook.com>
 <49158E750348AA499168FD41D88983607C67BEA6@fmsmsx117.amr.corp.intel.com>
 <BN3PR04MB222869E492D6E76D952475A291420@BN3PR04MB2228.namprd04.prod.outlook.com>
Message-ID: <49158E750348AA499168FD41D88983607C6ED8D6@fmsmsx117.amr.corp.intel.com>


Hi Tom,

I'm not sure what happened. I will look into it and fix the issue. Give me a few days.

Thanks...
Ray

From: Tom Freeman [mailto:thomas.freeman at wdc.com]
Sent: Wednesday, February 08, 2017 12:32 PM
To: Robles, Raymond C <raymond.c.robles at intel.com>; nvmewin <nvmewin at lists.openfabrics.org>
Subject: RE: Issue with the latest OFA driver

Ray,
Unless I'm missing something, it appears the change to remove CNTID from Identify commands did not make it into 1.5

Here is the relevant code from the fix I submitted:

    /* Populate submission entry fields */
    pIdentify = &pNVMeSrbExt->nvmeSqeUnit;
    pIdentify->CDW0.OPC = ADMIN_IDENTIFY;

   pIdentifyCDW10 = (PADMIN_IDENTIFY_COMMAND_DW10) &pIdentify->CDW10;
    /* Set the type of identify command */
    pIdentifyCDW10->CNS = CNS;

    switch (CNS) {


Here is the same code in the trunk and the 1.5 release source:

/* Populate submission entry fields */

    pIdentify = &pNVMeSrbExt->nvmeSqeUnit;

    pIdentify->CDW0.OPC = ADMIN_IDENTIFY;



    pIdentifyCDW10 = (PADMIN_IDENTIFY_COMMAND_DW10) &pIdentify->CDW10;

    /* Set the type of identify command */

    pIdentifyCDW10->CNS = CNS;

    /* Select the controller to talk to */

    pIdentifyCDW10->CNTID = CNTID;



    switch (CNS) {





Can we get this updated, including the 1.5 builds?

Thanks,


Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

From: Tom Freeman
Sent: Friday, November 11, 2016 8:41 AM
To: 'Robles, Raymond C' <raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: RE: Issue with the latest OFA driver

Ray,
In case you decide to include this fix in the latest release, here are the details:

The attached zip file, Ident-CNTIDPatch.zip (password = nvmehgst) contains:

1.       Source subdirectory containing the modified code based on revision 139.

2.       ControllerIdFix.patch containing the SVN patch to revision 139.

3.       README.txt - description of the problem and the fix.

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

From: Robles, Raymond C [mailto:raymond.c.robles at intel.com]
Sent: Tuesday, November 1, 2016 1:27 PM
To: Tom Freeman <thomas.freeman at wdc.com<mailto:thomas.freeman at wdc.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: RE: Issue with the latest OFA driver

Hi Tom,

Good find!

I'm of the opinion that it makes sense to get this patch in for the release we are about to announce. This is a minor fix for the Identify command that is isolated to two scenarios. Does anyone else have any objections or feel we should wait for this patch?

Depending on the feedback, we can go ahead and push a patch. I would say for now, please get the patch ready and then let's hold for feedback from the community reviewers... and go from there.

Thank you...
Ray

From: Tom Freeman [mailto:thomas.freeman at wdc.com]
Sent: Tuesday, November 01, 2016 9:08 AM
To: Robles, Raymond C <raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: Issue with the latest OFA driver

Ray,
We've run into the following issue with the latest OFA driver.
During initialization, the driver request for NVME Identify Namespace fails with a status of "invalid field in command". Because of this, initialization fails and the device does not show up.
The underlying cause is that the driver puts the controller ID value into CDW10.CNTID. According to the NVMe spec, that is only valid when CNS = 0x12 or 0x13. For all other cases, "the host shall clear this field to 0h"

I'd like to make a patch for this. The fix would remove controller ID from any of the instance of NVMe Identify command (the driver does not use CNS = 0x12 or 0x13). How would you like me to proceed to coordinate with the current 1.5 testing?
Thanks,

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:
This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.
Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:
This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20170209/1030bc0c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 1117 bytes
Desc: image001.gif
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20170209/1030bc0c/attachment.gif>

From raymond.c.robles at intel.com  Fri Feb 10 11:09:20 2017
From: raymond.c.robles at intel.com (Robles, Raymond C)
Date: Fri, 10 Feb 2017 19:09:20 +0000
Subject: [nvmewin] Happy New Year... looking to 2017 and beyond...
In-Reply-To: <49158E750348AA499168FD41D88983607C6E753A@fmsmsx117.amr.corp.intel.com>
References: <49158E750348AA499168FD41D88983607C6E3EAD@fmsmsx117.amr.corp.intel.com>
 <49158E750348AA499168FD41D88983607C6E753A@fmsmsx117.amr.corp.intel.com>
Message-ID: <49158E750348AA499168FD41D88983607C6EE588@fmsmsx117.amr.corp.intel.com>

Hello...

Final reminder... today is the deadline for nominees. I will call for a vote next week.

Thank you...
Ray

From: Robles, Raymond C
Sent: Tuesday, January 31, 2017 9:16 AM
To: Robles, Raymond C <raymond.c.robles at intel.com>; nvmewin at lists.openfabrics.org
Cc: Huffman, Amber <amber.huffman at intel.com>; Olsson, Claes <claes.olsson at intel.com>; 'Uma.parepalli at viavisolutions.com' <Uma.parepalli at viavisolutions.com>
Subject: RE: Happy New Year... looking to 2017 and beyond...

Hello...

Friendly reminder on nominations for new OFA NVMe Windows chair. The deadline for nominations is Feb. 10, 2017.

Thank you...
Ray

From: nvmewin [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Robles, Raymond C
Sent: Wednesday, January 25, 2017 4:18 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Cc: Huffman, Amber <amber.huffman at intel.com<mailto:amber.huffman at intel.com>>; Olsson, Claes <claes.olsson at intel.com<mailto:claes.olsson at intel.com>>
Subject: [nvmewin] Happy New Year... looking to 2017 and beyond...

Happy new year OFA community family!

As we closed out the end of 2016, we finally released our 1.5 revision of the OFA driver. This was a great achievement and I was very happy to be a part of it. As we look forward to 2017 and beyond, we are in a good position to keep providing a robust, performant, and reliable Windows NVMe reference driver.

With that in mind, I believe it is time for me to step down as acting chair of the OFA NVMe Windows community. I've been in the chair position for about two years... and this was my second stint. As with the original intent, the chair/maintainer position was designed to rotate between companies in much the same way the NVMe promoters group works.

As I prepare to step down, I have talked to a potential candidates for replacement. As always, I believe the OFA community should nominate and vote on its new chair. In that spirit, I would like to nominate Uma Parepalli. Uma has been a strong advocate of the OFA NVMe Windows driver (and all open source NVMe drivers) and has led technical talks in previous Flash Memory Summits. I've personally spoken to Uma and I believe he would make a great chair.

At this time, I would like to call for any other nominations for the OFA NVMe Windows chair. Please submit any nominations before Feb. 10th, 2017... at which point, I will call for a vote.

Thanks...
Ray

Raymond C. Robles
NSG ISE Host Storage Software
Intel Corporation
Office: 480-554-2600
Mobile: 480-399-0645
raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>

[cid:image001.gif at 01CB9B29.EA8D14F0]

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20170210/0728e21a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.jpg
Type: image/jpeg
Size: 1568 bytes
Desc: image001.jpg
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20170210/0728e21a/attachment.jpg>

From gilad215 at gmail.com  Mon Feb  6 05:21:54 2017
From: gilad215 at gmail.com (Gilad Lekner)
Date: Mon, 06 Feb 2017 13:21:54 +0000
Subject: [nvmewin] NVMe OpenSource Driver feedback
Message-ID: <CALW7-Dq1A3wbMP3EMVDMhaUB09oSoHTvxTJuXF3de+o7obBUqA@mail.gmail.com>

Hello readers,

I installed the open source driver on my Windows 10 x64 for my Intel 600p
NVMe drive.
The performance is better than the stock driver!
BUT, the cpu is at max speed 100% of the time, not usage, but speed.
The temps are fine, but ever since i installed the driver, my i7-6700k,
stays at 100% speed (4.6ghz overclocked) 100% of the time even at complete
idle. just thought i should notice you!

Thanks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20170206/c0d99b32/attachment.html>

From moheban79 at gmail.com  Fri Feb 24 06:57:45 2017
From: moheban79 at gmail.com (david moheban)
Date: Fri, 24 Feb 2017 09:57:45 -0500
Subject: [nvmewin] Opensource NVME driver
Message-ID: <CADxnD1wA+XtAD71na95fYwLs=v2RUw6831OoXmPF9M6WK7FAtQ@mail.gmail.com>

Hi,

Stumbled across your driver by accident but the readme states you have to
disable Test Signing. Isn't there a signed driver out there already where
you don't have to do that? Second is there performance benefits to your
driver vs the standard windows NVME driver?

Thank you
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20170224/8a22b5f8/attachment.html>