[Openib-windows] RE: [PATCH] use of event log for link up/down msg

[Fab Tillier]

Hi Yossi,

> From: Yossi Leybovich [mailto:sleybo at mellanox.co.il]
> Sent: Sunday, December 11, 2005 8:23 AM
> 
> Fab
> 
> I create patch that enable to log port up\down events to the log viewer.
> I add msg file to the repository.
> In the near future I will send patch that will add more massages to the
> log viewer(I will also use the NDIS_ERROR_CODE  defines from ndis.h)

I don't see much value in reporting events that are reported through the link
state of the adapter - the adapter icon will show whether the link is up or not
via the cable unplugged icon.  The error log should be used only for errors.

That said, I think you've started something very valuable here by laying the
foundation for error reporting in the IPoIB driver.  This should be extended to
report various IPoIB specific errors:

- Failure to join multicast group (record port and MC group link width/speed).
- Failure of SA path queries (record destination Ethernet and IPoIB MAC).
- Failure of ATS registrations (record and SA status).
- Any other error that might prevent proper operation.

What do you think?

- Fab