[Openib-windows] RE: [PATCH] port num

[Fab Tillier]

> From: Yossi Leybovich [mailto:sleybo at mellanox.co.il]
> Sent: Monday, December 12, 2005 11:17 PM
> 
> > From: Fab Tillier [mailto:ftillier at silverstorm.com]
> > Sent: Monday, December 12, 2005 9:38 PM
> >
> > Hi Yossi,
> >
> > > From: Yossi Leybovich [mailto:sleybo at mellanox.co.il]
> > > Sent: Sunday, December 11, 2005 8:18 AM
> > >
> > > Fab
> > >
> > > I know its just for debug but....
> > > This patch retrive the port number from the bus ifc and store it in
> > > the adapter context.
> > > Now the debug prints show the right port.
> >
> > That print is only used in one place - would you mind if we
> > just changed it to output the port GUID?
>
> I don't mind to print the port_guid.
> 
> But since we already query the port/node guid why not to take the port
> number (the bus_port ifc has it in its struct)?

Changing the interface data structure requires changing that structure's version
(which your patch didn't do).  It just seemed a lot of change for seemingly
little value.  I'm sure if we have it though that we'll end up using it more.

> I think it will be useful (maybe for debug or when we will use the both
> adapter on both port) to have the port number in the adapter struct.

Sure, we can add it.  I'll apply your patch, but plan on changing the n_port to
port_num to be consistent with the rest of the code base.  I also plan on
incrementing the IPOIB_INTERFACE_VERSION_DATA in inc\kernel\iba\ipoib_ifc.h and
removing the use of the macro for the port number, since it's more concise to
use straight C code: p_adapter->guids.port_num.

- Fab