[Openib-windows] RE: [PATCH] port num

[Yossi Leybovich]

> -----Original Message-----
> From: Fab Tillier [mailto:ftillier at silverstorm.com] 
> Sent: Wednesday, December 14, 2005 9:45 AM
> To: 'Fab Tillier'; Yossi Leybovich
> Cc: openib-windows at openib.org
> Subject: RE: [PATCH] port num 
> 
> Hi Yossi,
> 
> I just thought of an issue with the port number - it's 
> useless without either the CA or port GUID, since a multi-HCA 
> system would introduce ambiguity with the port numbers.
> 
> I don't know if adding the port number if the port GUID is 
> already displayed makes that big of a difference.

I agree that we have to print the port GUID (there is no use of the port
number in multi HCA system)
We can print both (Remember that Mellanox keep the port number in the
last byte of the GUID and I think Silverstone keep its port number in
the 3rd byte, right?)

> 
> Note also that any debug output relative to the ipoib_port_t 
> object has access to the port number stored therein.

That right but still, the adapter is also a per HCA port struct right?
And if I recall the adapter is created before the port.
I still think it is good to keep the guid structure in the adapter the
same as the ifc_bus_port structure

> 
> Thoughts?
> 
> - Fab
>