[Openib-windows] RE: Improve error checking of ib_cm_rep (kernel)

Fab Tillier ftillier at silverstorm.com
Thu Jul 28 23:13:38 PDT 2005


> From: Tzachi Dar [mailto:tzachid at mellanox.co.il]
> Sent: Thursday, July 28, 2005 8:55 AM
> 
> There is a small bug in the error checking of this function that should
> probably be fixed.
> 
> The problem is in the function ib_cm_rep() - the one that is on al_cm_qp.c @
> 1363.
> 
> It seems that this function, checks if p_cm_rep->h_qp is null (on line 1385),
> but if it is, it still crashes two lines bellow.

Good catch - the second if should have been an else if.  Fixed, and checked in
as revision 52 (along with other changes to the CM, and a bunch of minor bug
fixes - see the logs for details).

Thanks,

- Fab




More information about the ofw mailing list