[Openib-windows] RE: [PATCH] FW version in vstat

[Fab Tillier]

Hi Yossi,

> From: Yossi Leybovich [mailto:sleybo at mellanox.co.il]
> Sent: Sunday, November 06, 2005 7:01 AM
> 
> we found it very useful to know the fw version on the HCA
> this patch add fw version to the vstat report.

I think FW version is going to be a common field for any implementation.  As
such, I think it would be better to have it as part of the ib_ca_attr_t
structure.

In the new verb API I started defining the FW version is a 32-bit field in the
CA attributes.  Can you do the same thing here?

> to make it clean I want to create access function for Mellanox specific
> attributes in the query_ca ,
> where do you think we should put this functions ?

I don't quite follow you here.  You want to add private vendor data to the CA
attributes?  Why not just use the ib_ci_call function to get this private data?
I'm worried about making the ib_query_ca call too complicated if we start to add
support for all sorts of "flexibility".  It just makes it harder for the user to
figure out how large a buffer to allocate.

Can you describe what changes you want to make in a little more detail, along
with the impact on users?

Thanks,

- Fab