[Openib-windows] RE: [PATCH] modify CQ return size value

[Fab Tillier]

Hi Yossi,

> From: Yossi Leybovich [mailto:sleybo at mellanox.co.il]
> Sent: Sunday, November 13, 2005 3:29 AM
> 
> ib_modify_cq is not consistent with ib_create and ib_query cq
> in create and query the low level driver return the requested size so it
> can utilize the DB coalescing for CQ DBs and in modify it return the
> actual size
> 
> this patch fix that
> 
> pls review and apply
> 
> 10x
> Yossi
> 
> Singed-off-by: Yossi Leybovich (sleybo at mellanox.co.il)
> Index: core/al/user/ual_cq.c
> ===================================================================
> --- core/al/user/ual_cq.c (revision 716)
> +++ core/al/user/ual_cq.c (working copy)
> @@ -269,8 +269,8 @@
>   else
>   {
>    status = cq_ioctl.out.status;
> -  if( status == IB_SUCCESS )
> -   *p_size = cq_ioctl.out.size;
> +  //if( status == IB_SUCCESS )
> +  // *p_size = cq_ioctl.out.size;
>   }

Where is the user's value returned?  Or is the idea that any rounding up of the
size doesn't get reflected to the user?  Also, in the future just delete the
lines rather than commenting them out.

Thanks,

- Fab