[Openib-windows] RE: [PATCH] modify QP

[Fab Tillier]

> From: Yossi Leybovich [mailto:sleybo at mellanox.co.il]
> Sent: Monday, October 10, 2005 11:05 AM
> 
> We found that few fields were not set in the HW while transition from
> INIT2RTR and RTR2RTS
> The issue was that the THH layer check mask even on mandatory fields
> (for example ack_timeout see vapi2qpc_modify function) so even that
> the user set the value the actual value left unchanged (left 0).
>
> This patch fix this issue by setting the mask to VAPI on each
> transition even on mandatory fields.
> This bug may cause  deadlock in a lot of scenario because timeout
> 0 in Tavor/Arbel Hw is mean ignore timeout, so if you lost 1 packet
> the QP will never retry or generate CQE with error so you left waiting
> forever.
>
> pls review and apply

Thanks, committed in revision 105.

> BTW:
> There might be other fields that were not set ,I will cont. to review this
> farther this week.

Sure, send them my way and I'll commit them.

Thanks!

- Fab