[Openib-windows] RE: [PATCH] cl_timer

[Fab Tillier]

> From: Yossi Leybovich [mailto:sleybo at mellanox.co.il]
> Sent: Thursday, September 15, 2005 3:14 AM
> 
> Fab
> Attached patch for supporting nsec in timer stamp and provide way to get the
> CPU freq
> We use this in our performance tests (I hope that we upload them, to the
> OpenIB in the near future)
> (I left the cl_get_time_stamp_sec as is so we will not require to change old
> code)

Why add the cl_get_time_stamp_usec function when cl_get_time_stamp is identical?
Why not just use the existing function?  At a minimum, why not call the existing
function rather than duplicating it?

Also, for performance tests it would probably be better (lower impact of
counters) to have two functions - one to return the raw tick count, and the
other to return the frequency.  That way, you only perform the conversion to
human readable time units after the test completes, rather than at runtime.

If this is OK, I can code this up - it will add two functions,
cl_get_tick_count, and cl_get_tick_freq.

Let me know.

Thanks,

- Fab