[Openib-windows] RE: [PATCH] async_enent

[Fab Tillier]

> From: Yossi Leybovich [mailto:sleybo at mellanox.co.il]
> Sent: Sunday, September 18, 2005 7:15 AM
> 
> Fab
> Attached bug fix for async event in user space
> Our verification team found that CQ\QP async events does not reach the user
> level applications

I had seen that too, but hadn't had time to figure out why.  Thanks for tracking
this down.

> Index: core/al/al_qp.c
> ===================================================================
> --- core/al/al_qp.c     (revision 388)
> +++ core/al/al_qp.c     (working copy)
> @@ -2010,6 +2010,7 @@
>  {
>         ib_qp_handle_t                  h_qp;
> 
> +       AL_ENTER(AL_DBG_QP);
>         CL_ASSERT( p_event_rec );
>         h_qp = (ib_qp_handle_t)p_event_rec->context;
> 
> @@ -2038,6 +2039,7 @@
> 
>         if( h_qp->pfn_event_cb )
>                 h_qp->pfn_event_cb( p_event_rec );
> +       AL_ENTER(AL_DBG_QP);
>  }

Some of the functions in IBAL don't generate enter-exit debug output on purpose,
since they get invoked a lot and don't do much internally.

> 
> 
> Index: core/al/kernel/al_ci_ca.c
> ===================================================================
> --- core/al/kernel/al_ci_ca.c   (revision 388)
> +++ core/al/kernel/al_ci_ca.c   (working copy)
> @@ -332,7 +332,7 @@
>  {
>         ib_async_event_rec_t    event_rec;
> 
> -       CL_ENTER( AL_DBG_CA, g_al_dbg_lvl );
> +       CL_ENTER( AL_DBG_ERROR, g_al_dbg_lvl );
> 
>         CL_ASSERT( p_event_record );
> 
> @@ -342,7 +342,7 @@
> 
>         ci_ca_async_event( &event_rec );
> 
> -       CL_EXIT( AL_DBG_CA, g_al_dbg_lvl );
> +       CL_EXIT( AL_DBG_ERROR, g_al_dbg_lvl );
>  }

I don't know if we should make this change - clients that register for the async
event notifications can decide for themselves if they wish to log an error.  As
far as IBAL is concerned in this case, it's just handling an event - the path
through IBAL isn't erroneous.  These should probably be AL_ENTER/AL_EXIT, too.

Other than that the patch looks good and I'll apply when I get in the office
tomorrow.

Thanks!

- Fab