[Openib-windows] [PATCH] solicited event

[Yossi Leybovich]

Fab

Our verification team found that the solicited event mechanism does not
work.
I track that down and found that in the low level driver when trying to set
the SE bit 
the code use wrong condition.

In  WQE_build_send_be_req3 function the SE bit is being set by simple 
And(&) operation ( so the input to the function if the bit is set is 0x8)


cur_loc_p = WQE_build_send_be_req3(qp, next_wqe,
 				p_wr->send_opt & IB_SEND_OPT_SIGNALED?
VAPI_SIGNALED : VAPI_UNSIGNALED,
 				p_wr,
				p_wr->send_opt & IB_SEND_OPT_SOLICITED,
 				p_wr->immediate_data
 				);

But when the THH formt the WQE it set the bit with 1 mask
THHUL_qpm.c at 687 function WQE_pack_ctrl_send
"...
 | ((u_int32_t)(se_bit & 1) << CTRL_SEND_S_BIT_OFFSET ) 
.."

so its end up that the bit is not being set even the user put 1 in the
solicited options
This patch fix the problem 

Pls apply

10x
Yossi 


Singe-off-by:Yossi Leybovich (sleybo at mellanox.co.il)

Index: hw/mt23108/vapi/Hca/hcahal/tavor/thhul_qpm/thhul_qpm.c
===================================================================
--- hw/mt23108/vapi/Hca/hcahal/tavor/thhul_qpm/thhul_qpm.c	(revision
435)
+++ hw/mt23108/vapi/Hca/hcahal/tavor/thhul_qpm/thhul_qpm.c	(working
copy)
@@ -4837,7 +4837,7 @@
 			cur_loc_p = WQE_build_send_be_req3(qp, next_wqe,
 				p_wr->send_opt & IB_SEND_OPT_SIGNALED?
VAPI_SIGNALED : VAPI_UNSIGNALED,
 				p_wr,
-				p_wr->send_opt & IB_SEND_OPT_SOLICITED,
+				p_wr->send_opt & IB_SEND_OPT_SOLICITED? 1:0,
 				p_wr->immediate_data
 				);
 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20050922/56caf5bd/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: solicited.patch
Type: application/octet-stream
Size: 572 bytes
Desc: not available
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20050922/56caf5bd/attachment.obj>