[Openib-windows] RE: [PATCH] MTHCA: Cleanup includes

Leonid Keller leonid at mellanox.co.il
Sun Apr 2 01:02:29 PST 2006


Thank you, comitted to rev 268 

> -----Original Message-----
> From: Fab Tillier [mailto:ftillier at silverstorm.com] 
> Sent: Friday, March 31, 2006 11:26 PM
> To: Leonid Keller
> Cc: openib-windows at openib.org
> Subject: [PATCH] MTHCA: Cleanup includes
> 
> Hi Leonid,
> 
> This patch does a very minor cleanup of include directories 
> to match the usage in the rest of the code base.  For complib 
> headers, includes are generally defined as 
> "complib/cl_file.h" rather than "cl_file.h", which avoids the 
> need to specify the complib include directories.
> 
> - Fab
> 
> Index: hw/mthca/kernel/mt_atomic.h
> ===================================================================
> --- hw/mthca/kernel/mt_atomic.h	(revision 266)
> +++ hw/mthca/kernel/mt_atomic.h	(working copy)
> @@ -1,7 +1,7 @@
>  #ifndef MT_ATOMIC_H
>  #define MT_ATOMIC_H
>  
> -#include "cl_atomic.h"
> +#include "complib/cl_atomic.h"
>  
>  typedef atomic32_t atomic_t;
>  
> Index: hw/mthca/kernel/hca_driver.c
> ===================================================================
> --- hw/mthca/kernel/hca_driver.c	(revision 266)
> +++ hw/mthca/kernel/hca_driver.c	(working copy)
> @@ -51,7 +51,7 @@
>  //#include "MdCard.h"
>  #pragma warning( pop )
>  #include <iba/ib_ci_ifc.h>
> -#include "mthca_vc.h"
> +#include "mthca/mthca_vc.h"
>  
>  /* from \inc\platform\evntrace.h
>  #define TRACE_LEVEL_NONE        0   // Tracing is not on
> Index: hw/mthca/kernel/SOURCES
> ===================================================================
> --- hw/mthca/kernel/SOURCES	(revision 266)
> +++ hw/mthca/kernel/SOURCES	(working copy)
> @@ -59,11 +59,8 @@
>  INCLUDES=\
>  	..; \
>  	$(TRUNK)\inc;	\
> -	$(TRUNK)\inc\complib; \
> -	$(TRUNK)\inc\mthca; \
> -	$(TRUNK)\inc\kernel; \
> -	$(TRUNK)\inc\kernel\complib; \
> -	
> +	$(TRUNK)\inc\kernel;
> +
>  C_DEFINES=$(C_DEFINES) -DDRIVER -DDEPRECATE_DDK_FUNCTIONS 
> -D__LITTLE_ENDIAN
>  
>  TARGETLIBS= \
> Index: hw/mthca/mx_abi.h
> ===================================================================
> --- hw/mthca/mx_abi.h	(revision 266)
> +++ hw/mthca/mx_abi.h	(working copy)
> @@ -37,7 +37,7 @@
>  #ifndef MX_ABI_H
>  #define MX_ABI_H
>  
> -#include <cl_types_osd.h>
> +#include <complib/cl_types_osd.h>
>  
>  /*
>   * Make sure that all structs defined in this file remain laid out so
> 



More information about the ofw mailing list