[Openib-windows] RE: [PATCH] MTHCA: Fixup INF for consistency

[Fabian Tillier]

Hi Leonid,

Sorry I haven't gotten back to you yet - I've been quite busy!

On 4/10/06, Leonid Keller <leonid at mellanox.co.il> wrote:
> > -----Original Message-----
> > From: Fab Tillier [mailto:ftillier at silverstorm.com]
> > Sent: Monday, April 10, 2006 6:30 AM
> >
> > Hi Leo,
> >
> > Here's a pretty trivial patch to the MTHCA INF.  I checked in
> > some changes already to remove the dependency on ibal.sys
> > when I checked in the changes to make KAL a static library so
> > that the INF wasn't left broken.  Here are some extra changes:
> >
> > - Change the "Provider" field to reference OpenIB
> > - Remove the mention of the catalog file, as it can mess up
> > driver updates.
> > We'll add the line once we have the drivers certified.
> > - I updated the version.  I didn't update the one in
> > MTHCA_DEV.h, and will create a patch to pull this from the
> > version header so that it's automatic.
> > - Changed %DIRID_WINDOWS%\SysWOW64 to %DIRID_SYSTEM_X86% as
> > that's the correct definition.  I know the chkinf tool
> > doesn't like it, but that's a deficiency in the tool.  It's
> > better to use the ID, in case the directory name gets changed
> > in a future version.
>
> I'm not sure about it. DIRID_SYSTEM_X86 is defined as follows:
> #define DIRID_SYSTEM_X86              16425  // system32 on RISC
>
> Not clear, what it means.
> I've once come across a problem with that and changed it to
> %DIRID_WINDOWS%\SysWOW64.
> Now I don't exactly remember what was the problem and on what OS: it
> seems to me,
> that the error message was "unknown directory" so maybe it was on x86.
> My question is - did you check that on all the supported platforms:
>        x86-WinXP, x64-WinXP, x86-Win2003, x64-Win2003 (and, maybe, CCE)
> ?

I haven't had an issue with the INF files - the other INF files for
IBAL and IPoIB use the same value without issue.

The DDK tool chkinf does complain about an unkown directory value, but
this is harmless since the results are exactly what we're looking for.

- Fab