[Openib-windows] [PATCH] access to freed object in ioc_pnp

[Jan Bottorff]

Hi Guys,

I submitted this bug, and attempted a fix almost exactly like this
patch. It prevented the crash, but the result was the system got stuck
on shutdown instead, waiting for references to some AL object to be
freed.

You might want to ponder if some more cleanup of data structures are
needed.

- Jan

> -----Original Message-----
> From: openib-windows-bounces at openib.org [mailto:openib-windows-
> bounces at openib.org] On Behalf Of Yossi Leybovich
> Sent: Thursday, August 03, 2006 1:29 AM
> To: Fab Tillier
> Cc: openib-windows at openib.org
> Subject: [Openib-windows] [PATCH] access to freed object in ioc_pnp
> 
> Fab
> 
> On system shutdown, driver verifier detects access to freed memory in
> core\al\kernel\al_ioc_pnp.c.
> Without verifier, this causes a crash moments later.
> 
> This patch fix the problem
> 
> 10x
> Yossi
> 
> Signed-off-by: Yossi Leybovich (sleybo at mellanox.co.il)
> Index: al_ioc_pnp.c
> ===================================================================
> --- al_ioc_pnp.c (revision 1551)
> +++ al_ioc_pnp.c (working copy)
> @@ -2288,6 +2288,8 @@
>   {
>    __put_iou_map( gp_ioc_pnp, &p_results->iou_map );
>    cl_free( p_results );
> +  AL_EXIT( AL_DBG_PNP );
> +  return;
>   }
> 
>   /* Walk the map of IOUs and discard any that didn't respond to IOU
> info. */