[Openib-windows] Running WSD from as a non-administrator

[Fabian Tillier]

Hi Tzachi,

Could you clarify the change below please?

Thanks,

- Fab

On 8/4/06, Fabian Tillier <ftillier at silverstorm.com> wrote:
> Hi Tzachi,
>
> I saw some intermittent failures, where IBAT IOCTL requests where
> failing.  I was unable to figure out what was causing it, but had a
> question about the changes in this patch.
>
> On 7/30/06, Tzachi Dar <tzachid at mellanox.co.il> wrote:
> > Index: ulp/wsd/user/ibsp_ip.c
> > ===================================================================
> > --- ulp/wsd/user/ibsp_ip.c (revision 420)
> > +++ ulp/wsd/user/ibsp_ip.c (working copy)
> > @@ -96,7 +96,7 @@
> >   if( g_ibsp.h_ibat_dev == INVALID_HANDLE_VALUE )
> >   {
> >    g_ibsp.h_ibat_dev = CreateFileW( IBAT_WIN32_NAME,
> > -   GENERIC_READ, FILE_SHARE_READ | FILE_SHARE_WRITE, NULL,
> > +   MAXIMUM_ALLOWED, 0, NULL,
>
> Why did you change the share disposition from shared read/write access
> to no sharing?  Wouldn't this cause only a single application to be
> able to open the device?  The change from GENERIC_READ to
> MAXIMUM_ALLOWED is granting more rights, but the share disposition is
> granting fewer.
>
> Is there any reason not to allow shared access?  Or is it because the
> IOCTL path is neither READ nor WRITE?
>
> Thanks,
>
> - Fab
>