[Openib-windows] [PATCH] IBAL Kernel WPP enable

[Tillier, Fabian]

Hi Yossi,

> -----Original Message-----
> From: Yossi Leybovich [mailto:sleybo at mellanox.co.il]
> Sent: Sunday, July 02, 2006 3:17 AM
> 
> Fab
> 
> I notice that the current stack does not enable WPP in the kernel
part,
> this patch fix enable it.
> (it also include fix for compilation error in 64 bit)
> 
> Do you want me to apply this ?

One fix is needed, after which you can apply.  See below.  Thanks!

- Fab

> singed-off-by: Yossi Leybovich (sleybo at mellanox.co.il)
> 
> Index: W:/work/latest/core/al/kernel/SOURCES
> ===================================================================
> --- W:/work/latest/core/al/kernel/SOURCES	(revision 1498)
> +++ W:/work/latest/core/al/kernel/SOURCES	(revision 1500)
> @@ -5,7 +5,7 @@
> 
> 
>  !if $(FREEBUILD)
> -#ENABLE_EVENT_TRACING=1
> +ENABLE_EVENT_TRACING=1
>  !else
>  #ENABLE_EVENT_TRACING=1
>  !endif
> Index: W:/work/latest/core/al/kernel/al_dev.c
> ===================================================================
> --- W:/work/latest/core/al/kernel/al_dev.c	(revision 1498)
> +++ W:/work/latest/core/al/kernel/al_dev.c	(revision 1500)
> @@ -442,8 +442,8 @@
>  	p_open_context = p_io_stack->FileObject->FsContext;
> 
>  	AL_PRINT( TRACE_LEVEL_INFORMATION, AL_DBG_DEV,
> -		("al_dev_ioctl: buf_size (%ld) p_buf (%p).\n",
> -		cl_ioctl_in_size( h_ioctl ), cl_ioctl_in_buf( h_ioctl ))
> );
> +		("al_dev_ioctl: buf_size (%d) p_buf (%p).\n",
> +		(int)cl_ioctl_in_size( h_ioctl ), cl_ioctl_in_buf(

You can't use %p in WPP macros, as the size of the pointer is determined
by the system analyzing the trace, not the system on which the trace was
taken.  This results in parameters being all screwed up - a trace with
traceview on a 32-bit system will not display pointers properly.

Probably best to use 64-bit hex always (%i64x), and then add the
appropriate cast (LONG_PTR so it is sign extended for kernel pointers).

> h_ioctl )) );
> 
>  	/* Process the ioctl command. */
>  	if( IS_AL_PROXY_IOCTL(cl_ioctl_ctl_code( h_ioctl )) )