[Openib-windows] assert fix

[Fab Tillier]

Hi Leo,

> -----Original Message-----
> From: Leonid Keller [mailto:leonid at mellanox.co.il]
> Sent: Monday, July 10, 2006 11:22 AM
> To: Tillier, Fabian
> Cc: openib-windows at openib.org
> Subject: RE: [Openib-windows] assert fix
> 
> > -----Original Message-----
> > From: ftillier.sst at gmail.com [mailto:ftillier.sst at gmail.com]
> > On Behalf Of Fabian Tillier
> > Sent: Monday, July 10, 2006 5:05 PM
> > To: Leonid Keller
> > Cc: openib-windows at openib.org
> > Subject: Re: [Openib-windows] assert fix
> >
> > Hi Leo,
> >
> > On 7/10/06, Leonid Keller <leonid at mellanox.co.il> wrote:
> > >
> > > Hi Fab,
> > >
> > > I suggest to change ASSERTS as shown in the patch, because system
> > > drivers sometimes return non-zero success return codes, e.g. 2
> > > (STATUS_WAIT_2)
> >
> > For these two cases, the DDK docs say that drivers must
> > return STATUS_SUCCESS, so I think these are fine.  Have you
> > seen a case where a driver returned something else?
>
> Yes, I have. I've got STATUS_WAIT_2 and the ASSERT as a consequence.
> I also saw the reports about it in Internet.

Did the MTHCA driver return STATUS_WAIT_2, or some other driver?  I'm fine
with the patch, just weary of the consequences given the DDK docs.

Go ahead and check it in if the STATUS_WAIT_2 isn't coming from any of our
code.

- Fab